fix: stop polling resource tree for app not deployed

Author: arunjaindev

src/components/app/details/appDetails/AppDetails.tsx

@@ -507,19 +507,22 @@ const Details: React.FC<DetailsType> = ({
             const response = await appDetailsAPI(params.appId, params.envId, interval - 5000, appDetailsAbortRef)
             // eslint-disable-next-line no-param-reassign
             isVirtualEnvRef.current = response.result?.isVirtualEnvironment
-            // This means the CD is not triggered and the app is not helm migrated i.e. Empty State
-            if (!response.result.isPipelineTriggered && response.result.releaseMode === ReleaseMode.NEW_DEPLOYMENT) {
-                setResourceTreeFetchTimeOut(false)
-                setLoadingResourceTree(false)
-                pollResourceTreeRef.current = false
-            }
+
             appDetailsRef.current = {
                 ...appDetailsRef.current,
                 ...response.result,
             }
             IndexStore.publishAppDetails(appDetailsRef.current, AppType.DEVTRON_APP)
             setAppDetails(appDetailsRef.current)
 
+            // This means the CD is not triggered and the app is not helm migrated i.e. Empty State
+            if (!response.result.isPipelineTriggered && response.result.releaseMode === ReleaseMode.NEW_DEPLOYMENT) {
+                setResourceTreeFetchTimeOut(false)
+                setLoadingResourceTree(false)
+                pollResourceTreeRef.current = false
+                return
+            }
+
             if (fetchExternalLinks && response.result?.clusterId) {
                 getExternalLinksAndTools(response.result.clusterId)
             }
@@ -610,6 +613,7 @@ const Details: React.FC<DetailsType> = ({
                 }}
                 isForEmptyState
                 handleSuccess={callAppDetailsAPI}
+                isAppView={isAppView}
             />
         )
 
@@ -848,7 +852,7 @@ const AppDetail = ({ detailsType, filteredResourceIds }: AppDetailProps) => {
     const envList = useMemo(
         () =>
             (otherEnvsResult?.result ?? [])
-                .filter((env) => !filteredEntityMap || filteredEntityMap.get(env.environmentId))
+                .filter((env) => !isAppView || !filteredEntityMap || filteredEntityMap.get(env.environmentId))
                 .sort((a, b) => stringComparatorBySortOrder(a.environmentName, b.environmentName)),
         [filteredResourceIds, otherEnvsResult],
     )

src/components/app/details/appDetails/AppDetailsCDButton.tsx

@@ -38,7 +38,7 @@ import { AppDetailsCDButtonType } from '../../types'
 import CDMaterial from '../triggerView/cdMaterial'
 import { TRIGGER_VIEW_PARAMS } from '../triggerView/Constants'
 import { MATERIAL_TYPE } from '../triggerView/types'
-import { DA_APP_DETAILS_GA_EVENTS } from './constants'
+import { AG_APP_DETAILS_GA_EVENTS, DA_APP_DETAILS_GA_EVENTS } from './constants'
 import { getDeployButtonConfig } from './utils'
 
 const ApprovalMaterialModal = importComponentFromFELibrary('ApprovalMaterialModal')
@@ -54,6 +54,7 @@ const AppDetailsCDButton = ({
     environmentName,
     isForEmptyState = false,
     handleSuccess,
+    isAppView,
 }: AppDetailsCDButtonType): JSX.Element => {
     const history = useHistory()
     const { searchParams } = useSearchString()
@@ -72,7 +73,9 @@ const AppDetailsCDButton = ({
             search: new URLSearchParams(newParams).toString(),
         })
 
-        ReactGA.event(DA_APP_DETAILS_GA_EVENTS.DeployButtonClicked)
+        ReactGA.event(
+            isAppView ? DA_APP_DETAILS_GA_EVENTS.DeployButtonClicked : AG_APP_DETAILS_GA_EVENTS.DeployButtonClicked,
+        )
     }
 
     const closeCDModal = (e: React.MouseEvent): void => {

src/components/app/details/appDetails/SourceInfo.tsx

@@ -53,7 +53,7 @@ import { ReactComponent as Trash } from '../../../../assets/icons/ic-delete-dots
 import { ReactComponent as ScaleDown } from '../../../../assets/icons/ic-scale-down.svg'
 import HelmAppConfigApplyStatusCard from '@Components/v2/appDetails/sourceInfo/environmentStatus/HelmAppConfigApplyStatusCard'
 import { HibernationModalTypes } from './appDetails.type'
-import { DA_APP_DETAILS_GA_EVENTS } from './constants'
+import { AG_APP_DETAILS_GA_EVENTS, DA_APP_DETAILS_GA_EVENTS } from './constants'
 import AppEnvSelector from './AppDetails.components'
 
 const AppDetailsDownloadCard = importComponentFromFELibrary('AppDetailsDownloadCard')
@@ -160,7 +160,7 @@ export const SourceInfo = ({
     }
 
     const onClickSliderVerticalButton = () => {
-        ReactGA.event(DA_APP_DETAILS_GA_EVENTS.GoToEnvironmentConfiguration)
+        ReactGA.event(isAppView ? DA_APP_DETAILS_GA_EVENTS.GoToEnvironmentConfiguration: AG_APP_DETAILS_GA_EVENTS.GoToEnvironmentConfiguration)
     }
 
     const renderDevtronAppsEnvironmentSelector = () => {
@@ -336,6 +336,7 @@ export const SourceInfo = ({
                                         deploymentUserActionState: deploymentUserActionState,
                                         triggerType: appDetails.triggerType,
                                     }}
+                                    isAppView={isAppView}
                                 />
                             </div>
                         )}

src/components/app/details/appDetails/constants.ts

@@ -36,3 +36,14 @@ export const DA_APP_DETAILS_GA_EVENTS: Record<string, Parameters<typeof ReactGA.
         action: 'DA_APP_DETAIL_METRICS_PRESET_TIME_RANGE',
     },
 }
+
+export const AG_APP_DETAILS_GA_EVENTS: Record<string, Parameters<typeof ReactGA.event>[0]> = {
+    DeployButtonClicked: {
+        category: 'App Details',
+        action: 'AG_APP_DETAIL_DEPLOY',
+    },
+    GoToEnvironmentConfiguration: {
+        category: 'App Details',
+        action: 'AG_APP_DETAIL_GO_TO_ENV_CONFIG',
+    },
+}

src/components/app/types.ts

@@ -594,7 +594,7 @@ export interface AppDetailsCDButtonType
             AppDetails,
             'appId' | 'environmentId' | 'isVirtualEnvironment' | 'deploymentAppType' | 'environmentName'
         >,
-        Pick<SourceInfoType, 'deploymentUserActionState' | 'loadingDetails'> {
+        Pick<SourceInfoType, 'deploymentUserActionState' | 'loadingDetails' | 'isAppView'> {
     isRedirectedFromAppDetails?: boolean
     cdModal: CDModalProps
     isForEmptyState?: boolean