chore: pr comments

Author: ritvikmahajan17

src/components/app/details/appDetails/appDetails.scss

@@ -246,8 +246,12 @@ table.pod__table td:last-child {
 }
 
 .no-pod {
+    display: flex;
+    align-items: center;
+    justify-content: center;
     width: 100%;
     height: 100%;
+    flex-direction: column;
 
     .no-pod__container-icon {
         height: 34px;

src/components/app/details/cIDetails/CIDetails.tsx

@@ -386,7 +386,7 @@ export const Details = ({
                             artifact={triggerDetails.artifact}
                             environmentName={triggerDetails.environmentName}
                             isJobView={isJobView}
-                            name={triggerDetails.name}
+                            workerPodName={triggerDetails.name}
                         />
                         <ul className="tab-list dc__border-bottom pl-20 pr-20">
                             <li className="tab-list__tab">

src/components/app/details/cicdHistory/Constants.ts

@@ -23,5 +23,5 @@ export const HISTORY_LABEL = {
 
 export const WORKER_POD_BASE_URL = '/resource-browser/1/devtron-ci/pod/k8sEmptyGroup'
 
-export const TIMEOUT_VALUE = '12' // in hours
+export const TIMEOUT_VALUE = '1' // in hours
 

src/components/app/details/cicdHistory/TriggerDetails.tsx

@@ -62,7 +62,7 @@ export const TriggerDetails = React.memo(
         artifact,
         environmentName,
         isJobView,
-        name,
+        workerPodName,
     }: TriggerDetailsType): JSX.Element => {
         return (
             <div className="trigger-details">
@@ -90,7 +90,7 @@ export const TriggerDetails = React.memo(
                         stage={stage}
                         type={type}
                         isJobView={isJobView}
-                        name={name}
+                        workerPodName={workerPodName}
                     />
                 </div>
             </div>
@@ -128,7 +128,7 @@ const Finished = React.memo(({ status, finishedOn, artifact, type }: FinishedTyp
 })
 
 const WorkerStatus = React.memo(
-    ({ message, podStatus, stage, name, finishedOn }: WorkerStatusType): JSX.Element | null => {
+    ({ message, podStatus, stage, workerPodName, finishedOn }: WorkerStatusType): JSX.Element | null => {
         if (!message && !podStatus) return null
         // check if finishedOn time is timed out or not
         const isTimedOut = moment(finishedOn).isBefore(moment().subtract(TIMEOUT_VALUE, 'hours'))
@@ -143,7 +143,7 @@ const WorkerStatus = React.memo(
                         {stage === 'DEPLOY' ? (
                             <div className="mr-10">Message</div>
                         ) : showLink ? (
-                            <NavLink to={`${WORKER_POD_BASE_URL}/${name}/logs`} className="anchor">
+                            <NavLink to={`${WORKER_POD_BASE_URL}/${workerPodName}/logs`} className="anchor">
                                 <div className="mr-10">Worker</div>
                             </NavLink>
                         ) : (
@@ -173,7 +173,7 @@ const WorkerStatus = React.memo(
 })
 
 const ProgressingStatus = React.memo(
-    ({ status, message, podStatus, stage, type, finishedOn, name }: ProgressingStatusType): JSX.Element => {
+    ({ status, message, podStatus, stage, type, finishedOn, workerPodName }: ProgressingStatusType): JSX.Element => {
         const [aborting, setAborting] = useState(false)
         const [abortConfirmation, setAbortConfiguration] = useState(false)
         const { buildId, triggerId, pipelineId } = useParams<{
@@ -223,7 +223,7 @@ const ProgressingStatus = React.memo(
                         podStatus={podStatus}
                         stage={stage}
                         finishedOn={finishedOn}
-                        name={name}
+                        workerPodName={workerPodName}
                     />
                 </div>
                 {abortConfirmation && (
@@ -266,7 +266,7 @@ const CurrentStatus = React.memo(
         stage,
         type,
         isJobView,
-        name,
+        workerPodName,
     }: CurrentStatusType): JSX.Element => {
         if (PROGRESSING_STATUS[status.toLowerCase()]) {
             return (
@@ -277,7 +277,7 @@ const CurrentStatus = React.memo(
                     stage={stage}
                     type={type}
                     finishedOn={finishedOn}
-                    name={name}
+                    workerPodName={workerPodName}
                 />
             )
         } else {
@@ -289,7 +289,7 @@ const CurrentStatus = React.memo(
                         podStatus={podStatus}
                         stage={stage}
                         finishedOn={finishedOn}
-                        name={name}
+                        workerPodName={workerPodName}
                     />
                 </div>
             )

src/components/app/details/cicdHistory/types.tsx

@@ -206,7 +206,7 @@ export interface TriggerDetailsType {
     artifact?: string
     environmentName?: string
     isJobView?: boolean
-    name?: string
+    workerPodName?: string
 }
 
 export interface TriggerDetailsStatusIconType {
@@ -224,7 +224,7 @@ export interface WorkerStatusType {
     podStatus: string
     stage: DeploymentStageType
     finishedOn?: string
-    name?: string
+    workerPodName?: string
 }
 export interface ProgressingStatusType {
     status: string
@@ -233,7 +233,7 @@ export interface ProgressingStatusType {
     stage: DeploymentStageType
     type: HistoryComponentType
     finishedOn?: string
-    name?: string
+    workerPodName?: string
 }
 
 export interface CurrentStatusType {
@@ -245,7 +245,7 @@ export interface CurrentStatusType {
     stage: DeploymentStageType
     type: HistoryComponentType
     isJobView?: boolean
-    name?: string
+    workerPodName?: string
 }
 
 export interface StartDetailsType {

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/Logs.component.tsx

@@ -708,7 +708,7 @@ function LogsComponent({
                     </div>
                 )}
 
-            {podContainerOptions.containerOptions.filter((_co) => _co.selected).length === 0 && (
+            {podContainerOptions.containerOptions.filter((_co) => _co.selected).length == 0 && (
                 <div className="no-pod no-pod--container ">
                     <MessageUI
                         icon={MsgUIType.MULTI_CONTAINER}
@@ -718,7 +718,6 @@ function LogsComponent({
                                 : 'No container'
                         }`}
                         size={32}
-                        minHeight={isResourceBrowserView ? 'calc(100vh - 155px)' : ''}
                     />
                 </div>
             )}