refactor: clean up unused code and improve null checks in TriggerView components

Author: AbhishekA1509

src/components/ApplicationGroup/Details/TriggerView/TriggerResponseModal.tsx

@@ -81,7 +81,7 @@ const TriggerResponseModalBody = ({ responseList, isLoading, isVirtualEnv }: Tri
         return <Progressing pageLoader />
     }
     return (
-        <div className="response-list-container bg__primary pr-20 pb-16 pl-20 flex-grow-1">
+        <div className="response-list-container bg__primary pr-20 pb-16 pl-20 flex-grow-1 h-100">
             <div
                 className="dc__position-sticky dc__top-0 bg__primary dc__border-bottom response-row dc__border-bottom pt-24 pb-8"
                 style={{ zIndex: 1 }}

src/components/app/details/triggerView/DeployImageModal/utils.tsx

@@ -246,8 +246,6 @@ const processConsumedAndApprovedImages = (materials: CDMaterialType[]) => {
             !mat.userApprovalMetadata ||
             mat.userApprovalMetadata.approvalRuntimeState !== ApprovalRuntimeStateType.approved
         ) {
-            // TODO: Check if this is needed
-            // mat.isSelected = false
             consumedImage.push(mat)
         } else {
             approvedImages.push(mat)

src/components/app/details/triggerView/TriggerView.tsx

@@ -116,9 +116,7 @@ const TriggerView = ({ isJobView, filteredEnvIds }: TriggerViewProps) => {
             location.search.includes(TRIGGER_VIEW_PARAMS.ROLLBACK_NODE)
         ) {
             const cdNode: CommonNodeAttr = getSelectedNodeFromWorkflows(workflows, location.search)
-            if (!cdNode.id) {
-                return null
-            }
+
             const materialType = location.search.includes(TRIGGER_VIEW_PARAMS.CD_NODE)
                 ? MATERIAL_TYPE.inputMaterialList
                 : MATERIAL_TYPE.rollbackMaterialList
@@ -128,30 +126,30 @@ const TriggerView = ({ isJobView, filteredEnvIds }: TriggerViewProps) => {
             const doesWorkflowContainsWebhook = selectedCINode?.type === 'WEBHOOK'
             const configurePluginURL = getCDPipelineURL(
                 appId,
-                selectedWorkflow.id,
+                selectedWorkflow?.id || '0',
                 doesWorkflowContainsWebhook ? '0' : selectedCINode?.id,
                 doesWorkflowContainsWebhook,
-                cdNode.id,
+                cdNode.id || '0',
                 true,
             )
 
             return (
                 <DeployImageModal
                     materialType={materialType}
                     appId={+appId}
-                    envId={cdNode?.environmentId}
+                    envId={cdNode.environmentId}
                     appName={currentAppName}
                     stageType={cdNode.type as DeploymentNodeType}
-                    envName={cdNode?.environmentName}
+                    envName={cdNode.environmentName}
                     pipelineId={Number(cdNode.id)}
                     handleClose={revertToPreviousURL}
                     handleSuccess={reloadWorkflowStatus}
-                    deploymentAppType={cdNode?.deploymentAppType}
+                    deploymentAppType={cdNode.deploymentAppType}
                     isVirtualEnvironment={cdNode.isVirtualEnvironment}
-                    showPluginWarningBeforeTrigger={cdNode?.showPluginWarning}
-                    consequence={cdNode?.pluginBlockState}
+                    showPluginWarningBeforeTrigger={cdNode.showPluginWarning}
+                    consequence={cdNode.pluginBlockState}
                     configurePluginURL={configurePluginURL}
-                    isTriggerBlockedDueToPlugin={cdNode?.showPluginWarning && cdNode?.isTriggerBlocked}
+                    isTriggerBlockedDueToPlugin={cdNode.showPluginWarning && cdNode.isTriggerBlocked}
                     triggerType={cdNode.triggerType}
                     parentEnvironmentName={cdNode.parentEnvironmentName}
                 />

src/components/app/details/triggerView/TriggerView.utils.tsx

@@ -22,7 +22,6 @@ import {
     DeploymentNodeType,
     DeploymentWithConfigType,
     handleAnalyticsEvent,
-    showError,
     WorkflowType,
 } from '@devtron-labs/devtron-fe-common-lib'
 
@@ -216,7 +215,6 @@ export const getSelectedNodeFromWorkflows = (workflows: WorkflowType[], search:
     const { cdNodeId, nodeType } = getNodeIdAndTypeFromSearch(search)
 
     if (!cdNodeId) {
-        showError('Invalid node id')
         return {} as CommonNodeAttr
     }
 
@@ -228,7 +226,6 @@ export const getSelectedNodeFromWorkflows = (workflows: WorkflowType[], search:
         return foundNode
     }
 
-    showError('Invalid node id')
     return {} as CommonNodeAttr
 }