Skip to content

Commit ca2d42b

Browse files
committed
refactor: rename hideAppDetailsStatus to handleCloseAppStatusModal and update loading prop in AppDetails component
1 parent f20a1a8 commit ca2d42b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/components/app/details/appDetails/AppDetails.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ const Details: React.FC<DetailsType> = ({
591591
}
592592
}
593593

594-
const hideAppDetailsStatus = (): void => {
594+
const handleCloseAppStatusModal = (): void => {
595595
if (detailedStatus) {
596596
toggleDetailedStatus(false)
597597
}
@@ -790,7 +790,7 @@ const Details: React.FC<DetailsType> = ({
790790
{(detailedStatus || location.search.includes(DEPLOYMENT_STATUS_QUERY_PARAM)) && (
791791
<AppStatusModal
792792
titleSegments={[appDetailsFromIndexStore.appName, appDetailsFromIndexStore.environmentName]}
793-
handleClose={hideAppDetailsStatus}
793+
handleClose={handleCloseAppStatusModal}
794794
type="devtron-app"
795795
appDetails={appDetailsFromIndexStore}
796796
isConfigDriftEnabled={isConfigDriftEnabled}
@@ -799,7 +799,7 @@ const Details: React.FC<DetailsType> = ({
799799
detailedStatus ? AppStatusModalTabType.APP_STATUS : AppStatusModalTabType.DEPLOYMENT_STATUS
800800
}
801801
deploymentStatusDetailsBreakdownData={deploymentStatusDetailsBreakdownData}
802-
isLoading={isInitialTimelineDataLoading}
802+
isDeploymentTimelineLoading={isInitialTimelineDataLoading}
803803
/>
804804
)}
805805
{location.search.includes('deployment-window-status') && DeploymentWindowStatusModal && (

src/components/v2/appDetails/AppDetails.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ const AppDetailsComponent = ({
247247
configDriftModal={null}
248248
// TODO: Test virtual environment deployment data
249249
deploymentStatusDetailsBreakdownData={deploymentStatusDetailsBreakdownData}
250-
isLoading={isInitialTimelineDataLoading}
250+
isDeploymentTimelineLoading={isInitialTimelineDataLoading}
251251
initialTab={AppStatusModalTabType.DEPLOYMENT_STATUS}
252252
/>
253253
)}

0 commit comments

Comments
 (0)