chore: replace 'CHECKED' with enums in direct <Checbbox>

AbhishekA1509 · AbhishekA1509 · commit d16ca87fffca · 2024-01-22T12:59:10.000+05:30
diff --git a/src/components/app/details/triggerView/ciMaterial.tsx b/src/components/app/details/triggerView/ciMaterial.tsx
@@ -1,5 +1,5 @@
 import React, { Component } from 'react'
-import { showError, ServerErrors, Checkbox, noop } from '@devtron-labs/devtron-fe-common-lib'
+import { showError, ServerErrors, Checkbox, noop, CHECKBOX_VALUE } from '@devtron-labs/devtron-fe-common-lib'
 import { CIMaterialProps, CIMaterialState, RegexValueType } from './types'
 import { ReactComponent as Play } from '../../../../assets/icons/misc/arrow-solid-right.svg'
 import { ReactComponent as Info } from '../../../../assets/icons/info-filled.svg'
@@ -106,7 +106,7 @@ export class CIMaterial extends Component<CIMaterialProps, CIMaterialState> {
                     isChecked={this.context.invalidateCache}
                     onClick={this.onClickStopPropagation}
                     rootClassName="form__checkbox-label--ignore-cache mb-0"
-                    value={'CHECKED'}
+                    value={CHECKBOX_VALUE.CHECKED}
                     onChange={this.context.toggleInvalidateCache}
                     data-testid="set-clone-directory"
                 >
diff --git a/src/components/charts/ChartHeaderFilters.tsx b/src/components/charts/ChartHeaderFilters.tsx
@@ -1,6 +1,6 @@
 import React from 'react'
 import { ReactComponent as Search } from '../../assets/icons/ic-search.svg'
-import { Checkbox } from '@devtron-labs/devtron-fe-common-lib'
+import { CHECKBOX_VALUE, Checkbox } from '@devtron-labs/devtron-fe-common-lib'
 import { ReactComponent as Clear } from '../../assets/icons/ic-error.svg'
 import { ReactComponent as Grid } from '../../assets/icons/ic-grid-view.svg'
 import { ReactComponent as List } from '../../assets/icons/ic-list-view.svg'
@@ -180,7 +180,7 @@ function ChartHeaderFilter({
                 <Checkbox
                     rootClassName="fs-13 dc__hover-n50 pt-8 pb-8 pl-8 ml-8"
                     isChecked={includeDeprecated === 1}
-                    value={'CHECKED'}
+                    value={CHECKBOX_VALUE.CHECKED}
                     onChange={toggleDeprecated}
                     dataTestId="chart-store-filter-checkbox"
                 >
diff --git a/src/components/charts/list/DeployedChartFilters.tsx b/src/components/charts/list/DeployedChartFilters.tsx
@@ -2,7 +2,7 @@ import React from 'react'
 import { ReactComponent as Search } from '../../../assets/icons/ic-search.svg';
 import { ReactComponent as Clear } from '../../../assets/icons/ic-error.svg';
 import ReactSelect, { components } from 'react-select';
-import { Checkbox, multiSelectStyles, Option } from '@devtron-labs/devtron-fe-common-lib'
+import { Checkbox, CHECKBOX_VALUE, multiSelectStyles, Option } from '@devtron-labs/devtron-fe-common-lib'
 import { DropdownIndicator, ValueContainer } from '../charts.util';
 
 export default function DeployedChartFilters({ handleFilterQueryChanges, appStoreName, searchApplied, handleCloseFilter, handleAppStoreName, selectedChartRepo, onlyDeprecated, chartRepos, environment, handleSelectedFilters, selectedEnvironment }) {
@@ -79,7 +79,7 @@ export default function DeployedChartFilters({ handleFilterQueryChanges, appStor
                             styles={{ ...multiSelectStyles }} />
                         <Checkbox rootClassName="ml-16 mb-0 fs-13 cursor bcn-0 pt-8 pb-8 pr-12 date-align-left--deprecate"
                             isChecked={onlyDeprecated == true}
-                            value={"CHECKED"}
+                            value={CHECKBOX_VALUE.CHECKED}
                             onChange={(e) => {
                                 let value =  !onlyDeprecated;
                                 handleFilterQueryChanges(value, "deprecated") }} >
diff --git a/src/components/cluster/ClusterForm.tsx b/src/components/cluster/ClusterForm.tsx
@@ -747,7 +747,7 @@ export default function ClusterForm({
                             <Checkbox
                                 isChecked={isTlsConnection}
                                 rootClassName="form__checkbox-label--ignore-cache mb-0"
-                                value={'CHECKED'}
+                                value={CHECKBOX_VALUE.CHECKED}
                                 onChange={toggleCheckTlsConnection}
                             >
                                 <div data-testid="use_secure_tls_connection_checkbox" className="mr-4 flex center">
diff --git a/src/components/material/MaterialView.tsx b/src/components/material/MaterialView.tsx
@@ -737,7 +737,7 @@ export class MaterialView extends Component<MaterialViewProps, MaterialViewState
                     <div className="pt-16 ">
                         <Checkbox
                             isChecked={this.props.material.fetchSubmodules}
-                            value={'CHECKED'}
+                            value={CHECKBOX_VALUE.CHECKED}
                             tabIndex={5}
                             onChange={this.props.handleSubmoduleCheckbox}
                             rootClassName="fs-14 cn-9 flex top"
diff --git a/src/components/notifications/AddNotification.tsx b/src/components/notifications/AddNotification.tsx
@@ -12,6 +12,7 @@ import {
     MultiValueRemove,
     RadioGroup,
     RadioGroupItem,
+    CHECKBOX_VALUE,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { ReactComponent as Slack } from '../../assets/img/slack-logo.svg'
 import { ReactComponent as Add } from '../../assets/icons/ic-add.svg'
@@ -694,7 +695,7 @@ export class AddNotification extends Component<AddNotificationsProps, AddNotific
                                                     dataTestId={`trigger-notification-checkbox-${rowIndex}`}
                                                     rootClassName="gray"
                                                     isChecked={row.trigger}
-                                                    value={'CHECKED'}
+                                                    value={CHECKBOX_VALUE.CHECKED}
                                                     onChange={(e) => {
                                                         this.handlePipelineEventType(rowIndex, 'trigger')
                                                     }}
@@ -724,7 +725,7 @@ export class AddNotification extends Component<AddNotificationsProps, AddNotific
                                                     dataTestId={`failure-notification-checkbox-${rowIndex}`}
                                                     rootClassName="red"
                                                     isChecked={row.failure}
-                                                    value={'CHECKED'}
+                                                    value={CHECKBOX_VALUE.CHECKED}
                                                     onChange={(e) => {
                                                         this.handlePipelineEventType(rowIndex, 'failure')
                                                     }}
diff --git a/src/components/notifications/SESConfigModal.tsx b/src/components/notifications/SESConfigModal.tsx
@@ -1,6 +1,6 @@
 import React, { Component } from 'react'
 import { validateEmail } from '../common'
-import { showError, Progressing, Checkbox, Drawer, CustomInput } from '@devtron-labs/devtron-fe-common-lib'
+import { showError, Progressing, Checkbox, Drawer, CustomInput, CHECKBOX_VALUE } from '@devtron-labs/devtron-fe-common-lib'
 import { saveEmailConfiguration, getSESConfiguration } from './notifications.service'
 import { ReactComponent as Close } from '../../assets/icons/ic-close.svg'
 import { ReactComponent as Error } from '../../assets/icons/ic-warning.svg'
@@ -363,7 +363,7 @@ export class SESConfigModal extends Component<SESConfigModalProps, SESConfigModa
                     <div className="form__button-group-bottom flexbox flex-justify">
                         <Checkbox
                             isChecked={this.state.form.default}
-                            value={'CHECKED'}
+                            value={CHECKBOX_VALUE.CHECKED}
                             tabIndex={6}
                             disabled={this.props.shouldBeDefault}
                             onChange={this.handleCheckbox}
diff --git a/src/components/notifications/SMTPConfigModal.tsx b/src/components/notifications/SMTPConfigModal.tsx
@@ -1,6 +1,6 @@
 import React, { Component } from 'react'
 import { validateEmail } from '../common'
-import { showError, Progressing, Checkbox, Drawer, CustomInput } from '@devtron-labs/devtron-fe-common-lib'
+import { showError, Progressing, Checkbox, Drawer, CustomInput, CHECKBOX_VALUE } from '@devtron-labs/devtron-fe-common-lib'
 import { getSMTPConfiguration, saveEmailConfiguration } from './notifications.service'
 import { ReactComponent as Close } from '../../assets/icons/ic-close.svg'
 import { ReactComponent as Error } from '../../assets/icons/ic-warning.svg'
@@ -264,7 +264,7 @@ export class SMTPConfigModal extends Component<SMTPConfigModalProps, SMTPConfigM
                     <div className="form__button-group-bottom flexbox flex-justify">
                         <Checkbox
                             isChecked={this.state.form.default}
-                            value={'CHECKED'}
+                            value={CHECKBOX_VALUE.CHECKED}
                             tabIndex={6}
                             disabled={this.props.shouldBeDefault}
                             onChange={this.handleCheckbox}

Original file line number	Diff line number	Diff line change
`@@ -747,7 +747,7 @@ export default function ClusterForm({`
`747`	`747`	`<Checkbox`
`748`	`748`	`isChecked={isTlsConnection}`
`749`	`749`	`rootClassName="form__checkbox-label--ignore-cache mb-0"`
`750`		`- value={'CHECKED'}`
	`750`	`+ value={CHECKBOX_VALUE.CHECKED}`
`751`	`751`	`onChange={toggleCheckTlsConnection}`
`752`	`752`	`>`
`753`	`753`	`<div data-testid="use_secure_tls_connection_checkbox" className="mr-4 flex center">`