Merge pull request #2742 from devtron-labs/feat/live-config-diff

feat: add support for strategy change live diff in deploy modal

Author: arunjaindev

.eslintignore

@@ -88,7 +88,6 @@ src/components/app/details/appDetails/utils.tsx
 src/components/app/details/cIDetails/CIDetails.tsx
 src/components/app/details/cIDetails/cIDetails.util.tsx
 src/components/app/details/cdDetails/CDDetails.tsx
-src/components/app/details/cdDetails/service.ts
 src/components/app/details/cicdHistory/History.components.tsx
 src/components/app/details/main.tsx
 src/components/app/details/metrics/BenchmarkModal.tsx

package.json

@@ -4,7 +4,7 @@
     "private": true,
     "homepage": "/dashboard",
     "dependencies": {
-        "@devtron-labs/devtron-fe-common-lib": "1.15.0-pre-5",
+        "@devtron-labs/devtron-fe-common-lib": "1.15.0-pre-6",
         "@esbuild-plugins/node-globals-polyfill": "0.2.3",
         "@rjsf/core": "^5.13.3",
         "@rjsf/utils": "^5.13.3",

src/components/ApplicationGroup/Details/EnvCDDetails/__mock__/EnvCDDetails.mock.ts

@@ -14,9 +14,7 @@
  * limitations under the License.
  */
 
-import { ResponseType } from '@devtron-labs/devtron-fe-common-lib'
-
-import { ModuleConfigResponse } from '../../../../app/details/appDetails/appDetails.type'
+import { ModuleConfigResponse, ResponseType } from '@devtron-labs/devtron-fe-common-lib'
 
 export async function mockCDList(): Promise<ResponseType> {
     const response = {

src/components/app/details/appDetails/SourceInfo.tsx

@@ -307,7 +307,7 @@ export const SourceInfo = ({
                     <>
                         {!isdeploymentAppDeleting && (
                             <div style={{ marginLeft: 'auto' }} className="flex dc__gap-8">
-                                <div className="app-details-action-buttons flex border__primary br-6 dc__overflow-hidden">
+                                <div className="app-details-action-buttons flexbox border__primary br-6 dc__overflow-hidden">
                                     {!isVirtualEnvironment && showUrlInfo && (
                                         <>
                                             <Button
@@ -319,7 +319,7 @@ export const SourceInfo = ({
                                                 style={ButtonStyleType.neutral}
                                                 ariaLabel="URLs"
                                             />
-                                            <div className="divider__primary h-100" />
+                                            <div className="divider__secondary" />
                                         </>
                                     )}
 
@@ -355,7 +355,7 @@ export const SourceInfo = ({
                                                 }}
                                                 ariaLabel={isHibernated ? 'Unhibernate' : 'Hibernate'}
                                             />
-                                            <div className="divider__primary h-100" />
+                                            <div className="divider__secondary" />
                                         </>
                                     )}
 
@@ -387,7 +387,7 @@ export const SourceInfo = ({
                                                     }}
                                                     ariaLabel="restart workloads"
                                                 />
-                                                <div className="divider__primary h-100" />
+                                                <div className="divider__secondary" />
                                             </>
                                         )}
 

src/components/app/details/appDetails/appDetails.service.ts

@@ -18,6 +18,7 @@ import {
     DeploymentStatusDetailsResponse,
     get,
     getUrlWithSearchParams,
+    ModuleConfigResponse,
     ResponseType,
     trash,
 } from '@devtron-labs/devtron-fe-common-lib'
@@ -30,7 +31,6 @@ import {
     DataSourceDetailsDTO,
     DataSourceDetailsQueryParams,
     DataSourceDetailsType,
-    ModuleConfigResponse,
 } from './appDetails.type'
 
 export const getDataSourceDetailsFromEnvironment = async (envName: string): Promise<DataSourceDetailsType> => {

src/components/app/details/appDetails/appDetails.type.ts

@@ -65,12 +65,6 @@ export interface AppDetailsPathParams {
     envId?: string
 }
 
-export interface ModuleConfigResponse extends ResponseType {
-    result?: {
-        enabled: boolean
-    }
-}
-
 export interface DataSourceDetailsDTO {
     id: number
     name: string
@@ -92,18 +86,6 @@ export interface ClusterConnectionResponse extends ResponseType {
     }
 }
 
-export type DeleteResponseType = {
-    clusterName: string
-    clusterReachable: boolean
-    deleteInitiated: boolean
-}
-
-export interface DeploymentStatusDetailRowType {
-    type: string
-    hideVerticalConnector?: boolean
-    deploymentDetailedData: DeploymentStatusDetailsBreakdownDataType
-}
-
 export type SocketConnectionType = 'CONNECTED' | 'CONNECTING' | 'DISCONNECTED' | 'DISCONNECTING'
 
 export interface NodeSelectorsType {

src/components/app/details/cdDetails/cd.type.ts

@@ -28,7 +28,7 @@ import { URLS } from '@Config/routes'
 import { PipelineConfigDiffProps } from './types'
 
 export const PipelineConfigDiff = ({
-    deploymentConfigSelectorProps,
+    radioSelectConfig,
     scopeVariablesConfig,
     urlFilters,
     ...props
@@ -63,8 +63,8 @@ export const PipelineConfigDiff = ({
             },
             {
                 id: 'deployment-config-selector',
-                type: 'selectPicker',
-                selectPickerProps: deploymentConfigSelectorProps,
+                type: 'radio-group',
+                radioSelectConfig,
             },
         ],
         hideDivider: true,