Skip to content

Commit d9fdac3

Browse files
Merge pull request #1614 from devtron-labs/remove-redundant-component
chore: remove radioGroup and ConditionalWrap from dashboard
2 parents 23aae1a + b7c8d5d commit d9fdac3

File tree

26 files changed

+94
-234
lines changed

26 files changed

+94
-234
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "0.0.67",
7+
"@devtron-labs/devtron-fe-common-lib": "0.0.68",
88
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
99
"@rjsf/core": "^5.13.3",
1010
"@rjsf/utils": "^5.13.3",

src/components/CIPipelineN/TaskDetailComponent.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
import React, { useState, useContext } from 'react'
2-
import { CustomInput, PluginType, ScriptType } from '@devtron-labs/devtron-fe-common-lib'
32
import YAML from 'yaml'
43
import { ConfigurationType, BuildStageVariable } from '../../config'
5-
import { RadioGroup } from '../common'
64
import { ConditionContainerType, PluginVariableType } from '../ciPipeline/types'
75
import { VariableContainer } from './VariableContainer'
86
import { ConditionContainer } from './ConditionContainer'
7+
import {
8+
CustomInput,
9+
PluginType,
10+
ScriptType,
11+
StyledRadioGroup as RadioGroup,
12+
} from '@devtron-labs/devtron-fe-common-lib'
913
import { YAMLScriptComponent } from './YAMLScriptComponent'
1014
import CustomInputOutputVariables from './CustomInputOutputVariables'
1115
import { TaskTypeDetailComponent } from './TaskTypeDetailComponent'

src/components/CodeEditor/CodeEditor.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,18 @@
11
import React, { useEffect, useCallback, useReducer, useRef } from 'react'
22
import MonacoEditor, { MonacoDiffEditor } from 'react-monaco-editor'
3-
import { MODES, Progressing, copyToClipboard, useWindowSize } from '@devtron-labs/devtron-fe-common-lib'
3+
import {
4+
MODES,
5+
Progressing,
6+
copyToClipboard,
7+
useWindowSize,
8+
StyledRadioGroup as RadioGroup,
9+
} from '@devtron-labs/devtron-fe-common-lib'
410
import YAML from 'yaml'
511
import ReactGA from 'react-ga4'
612
import * as monaco from 'monaco-editor/esm/vs/editor/editor.api'
713
import { configureMonacoYaml } from 'monaco-yaml'
814

9-
import { useJsonYaml, Select, RadioGroup } from '../common'
15+
import { useJsonYaml, Select } from '../common'
1016
import { ReactComponent as ClipboardIcon } from '../../assets/icons/ic-copy.svg'
1117
import { ReactComponent as Info } from '../../assets/icons/ic-info-filled.svg'
1218
import { ReactComponent as ErrorIcon } from '../../assets/icons/ic-error-exclamation.svg'

src/components/ConfigMapSecret/ConfigMapSecretDataEditorContainer.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// @ts-nocheck
22
import React from 'react'
33
import YAML from 'yaml'
4-
import { Info, RadioGroup } from '../common'
4+
import { Info } from '../common'
55
import { KeyValueInput, useKeyValueYaml } from './ConfigMapSecret.components'
66
import CodeEditor from '../CodeEditor/CodeEditor'
77
import { PATTERNS } from '../../config'
@@ -18,6 +18,7 @@ import {
1818
VIEW_MODE,
1919
} from './Secret/secret.utils'
2020
import { KeyValueFileInput } from '../util/KeyValueFileInput'
21+
import { StyledRadioGroup as RadioGroup } from '@devtron-labs/devtron-fe-common-lib'
2122
import { CM_SECRET_STATE } from './Constants'
2223
import { ReactComponent as ShowIcon } from '../../assets/icons/ic-visibility-on.svg'
2324
import { ReactComponent as HideIcon } from '../../assets/icons/ic-visibility-off.svg'

src/components/ResourceBrowser/ResourceList/ResourceFilterOptions.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,12 @@ import { ResourceFilterOptionsProps } from '../Types'
77
import { ReactComponent as Search } from '../../../assets/icons/ic-search.svg'
88
import { ReactComponent as Clear } from '../../../assets/icons/ic-error.svg'
99
import { ResourceValueContainerWithIcon, tippyWrapper } from './ResourceList.component'
10-
import { ALL_NAMESPACE_OPTION, FILTER_SELECT_COMMON_STYLES, NAMESPACE_NOT_APPLICABLE_OPTION } from '../Constants'
11-
import { ConditionalWrap } from '../../common'
10+
import {
11+
ALL_NAMESPACE_OPTION,
12+
FILTER_SELECT_COMMON_STYLES,
13+
NAMESPACE_NOT_APPLICABLE_OPTION
14+
} from '../Constants'
15+
import { ConditionalWrap } from '@devtron-labs/devtron-fe-common-lib'
1216
import { OptionType } from '../../app/types'
1317
import { ShortcutKeyBadge } from '../../common/formFields/Widgets/Widgets'
1418

src/components/app/Overview/Overview.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import React, { useEffect, useMemo, useState } from 'react'
22
import moment from 'moment'
33
import { Link, useHistory, useLocation, useParams } from 'react-router-dom'
44
import { toast } from 'react-toastify'
5+
import { ModuleNameMap, Moment12HourFormat, URLS } from '../../../config'
6+
import { getJobCIPipeline, getTeamList } from '../../../services/service'
57
import {
68
showError,
79
Progressing,
@@ -10,11 +12,10 @@ import {
1012
useAsync,
1113
getRandomColor,
1214
noop,
15+
StyledRadioGroup as RadioGroup,
1316
} from '@devtron-labs/devtron-fe-common-lib'
1417
import ReactGA from 'react-ga4'
15-
import { ModuleNameMap, Moment12HourFormat, URLS } from '../../../config'
16-
import { getJobCIPipeline, getTeamList } from '../../../services/service'
17-
import { EditableTextArea, RadioGroup, handleUTCTime, importComponentFromFELibrary } from '../../common'
18+
import { EditableTextArea, handleUTCTime, importComponentFromFELibrary } from '../../common'
1819
import { AppOverviewProps, EditAppRequest, JobPipeline } from '../types'
1920
import { ReactComponent as EditIcon } from '../../../assets/icons/ic-pencil.svg'
2021
import { ReactComponent as TagIcon } from '../../../assets/icons/ic-tag.svg'

src/components/app/details/appConfig/AppConfig.tsx

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,5 @@
11
import React, { useState, useEffect, lazy } from 'react'
22
import { useParams, useLocation, useRouteMatch, useHistory, NavLink, Link } from 'react-router-dom'
3-
4-
import {
5-
showError,
6-
Progressing,
7-
ErrorScreenManager,
8-
DeleteDialog,
9-
ConfirmationDialog,
10-
TippyCustomized,
11-
TippyTheme,
12-
} from '@devtron-labs/devtron-fe-common-lib'
133
import { toast } from 'react-toastify'
144
import {
155
URLS,
@@ -19,7 +9,17 @@ import {
199
ViewType,
2010
isCDPipelineCreated,
2111
} from '../../../../config'
22-
import { ConditionalWrap, importComponentFromFELibrary } from '../../../common'
12+
import { importComponentFromFELibrary } from '../../../common'
13+
import {
14+
showError,
15+
Progressing,
16+
ErrorScreenManager,
17+
DeleteDialog,
18+
ConfirmationDialog,
19+
TippyCustomized,
20+
TippyTheme,
21+
ConditionalWrap,
22+
} from '@devtron-labs/devtron-fe-common-lib'
2323
import { getAppConfigStatus, getAppOtherEnvironmentMin, getWorkflowList } from '../../../../services/service'
2424
import { deleteApp } from './appConfig.service'
2525
import { ReactComponent as Lock } from '../../../../assets/icons/ic-locked.svg'

src/components/app/details/cicdHistory/Sidebar.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import React, { useEffect, useRef } from 'react'
2+
import { createGitCommitUrl } from '../../../common'
23
import { useRouteMatch, useParams, useHistory, generatePath, useLocation } from 'react-router'
34
import ReactSelect, { components } from 'react-select'
45
import moment from 'moment'
56
import TippyHeadless from '@tippyjs/react/headless'
67
import { NavLink } from 'react-router-dom'
78
import ReactGA from 'react-ga4'
8-
import { ConditionalWrap, createGitCommitUrl } from '../../../common'
99
import { DropdownIndicator, getCustomOptionSelectionStyle } from '../../../v2/common/ReactSelect.utils'
1010
import { Moment12HourFormat, SourceTypeMap } from '../../../../config'
1111
import { CiPipelineSourceConfig } from '../../../ciPipeline/CiPipelineSourceConfig'
@@ -24,6 +24,7 @@ import { ReactComponent as ICArrowBackward } from '../../../../assets/icons/ic-a
2424
import DetectBottom from '../../../common/DetectBottom'
2525
import { FILTER_STYLE, HISTORY_LABEL } from './Constants'
2626
import { triggerStatus } from './History.components'
27+
import { ConditionalWrap } from '@devtron-labs/devtron-fe-common-lib'
2728

2829
const Sidebar = React.memo(
2930
({

src/components/app/details/triggerView/triggerViewConfigDiff/TriggerViewConfigDiff.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React, { Fragment, useEffect, useState } from 'react'
22
import YAML from 'yaml'
33
import Tippy from '@tippyjs/react'
4-
import { Toggle, useSearchString } from '@devtron-labs/devtron-fe-common-lib'
54
import { DeploymentHistorySingleValue } from '../../cdDetails/cd.type'
65
import CodeEditor from '../../../../CodeEditor/CodeEditor'
76
import { MODES } from '../../../../../config'
@@ -10,13 +9,14 @@ import { DEPLOYMENT_CONFIGURATION_NAV_MAP, getDeployConfigOptions } from '../Tri
109
import ReactSelect, { components } from 'react-select'
1110
import { DropdownIndicator, Option } from '../../../../v2/common/ReactSelect.utils'
1211
import { getCommonConfigSelectStyles } from '../config'
13-
import { ConditionalWrap } from '../../../../common'
1412
import { TriggerViewConfigDiffProps } from '../types'
1513
import { ReactComponent as ManifestIcon } from '../../../../../assets/icons/ic-file-code.svg'
1614
import { ReactComponent as DownArrowFull } from '../../../../../assets/icons/ic-down-arrow-full.svg'
1715
import { ReactComponent as ViewVariablesIcon } from '../../../../../assets/icons/ic-view-variable-toggle.svg'
16+
import { Toggle, ConditionalWrap,useSearchString } from '@devtron-labs/devtron-fe-common-lib'
1817
import { useHistory } from 'react-router-dom'
1918

19+
2020
export default function TriggerViewConfigDiff({
2121
currentConfiguration,
2222
baseTemplateConfiguration,

src/components/cdPipeline/CDPipeline.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {
2020
DeploymentAppTypes,
2121
PipelineType,
2222
CustomInput,
23+
ConditionalWrap,
2324
} from '@devtron-labs/devtron-fe-common-lib'
2425
import yamlJsParser from 'yaml'
2526
import ReactSelect from 'react-select'
@@ -67,12 +68,7 @@ import {
6768
} from '../v2/common/ReactSelect.utils'
6869
import './cdPipeline.scss'
6970
import dropdown from '../../assets/icons/ic-chevron-down.svg'
70-
import {
71-
ConditionalWrap,
72-
createClusterEnvGroup,
73-
getDeploymentAppType,
74-
importComponentFromFELibrary,
75-
} from '../common/helpers/Helpers'
71+
import { createClusterEnvGroup, getDeploymentAppType, importComponentFromFELibrary } from '../common/helpers/Helpers'
7672
import {
7773
DEPLOY_IMAGE_EXTERNALSOURCE,
7874
EDIT_DEPLOYMENT_PIPELINE,

0 commit comments

Comments
 (0)