chore: remove dead and unreachable code from app details and related areas

Author: arunjaindev

.eslintignore

@@ -330,7 +330,6 @@ src/components/v2/appDetails/ReleaseStatusEmptyState.tsx
 src/components/v2/appDetails/SyncError.component.tsx
 src/components/v2/appDetails/__tests__/index.store.test.ts
 src/components/v2/appDetails/appDetails.api.ts
-src/components/v2/appDetails/appDetails.type.ts
 src/components/v2/appDetails/ea/EAAppDetail.component.tsx
 src/components/v2/appDetails/k8Resource/FilterResource.tsx
 src/components/v2/appDetails/k8Resource/nodeDetail/EphemeralContainerDrawer.tsx
@@ -367,7 +366,6 @@ src/components/v2/devtronStackManager/DevtronStackManager.service.tsx
 src/components/v2/devtronStackManager/DevtronStackManager.tsx
 src/components/v2/devtronStackManager/DevtronStackManager.utils.ts
 src/components/v2/devtronStackManager/SuccessModalComponent.tsx
-src/components/v2/headers/AppHeader.component.tsx
 src/components/v2/headers/ChartHeader.component.tsx
 src/components/v2/headers/EAHeader.component.tsx
 src/components/v2/index.tsx

src/components/ApplicationGroup/AppGroup.types.ts

@@ -29,9 +29,10 @@ import {
     CommonNodeAttr,
     ApprovalConfigDataType,
     RuntimePluginVariables,
+    OptionType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { CDMaterialProps, RuntimeParamsErrorState } from '../app/details/triggerView/types'
-import { EditDescRequest, NodeType, Nodes, OptionType } from '../app/types'
+import { EditDescRequest, NodeType, Nodes } from '../app/types'
 import { MultiValue } from 'react-select'
 import { AppFilterTabs, BulkResponseStatus } from './Constants'
 import { WorkloadCheckType } from '../v2/appDetails/sourceInfo/scaleWorkloads/scaleWorkloadsModal.type'

src/components/ApplicationGroup/AppGroupDetailsRoute.tsx

@@ -41,6 +41,7 @@ import {
     URLS as CommonURLS,
     DeleteConfirmationModal,
     useMainContext,
+    OptionType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import ReactGA from 'react-ga4'
 import { MultiValue } from 'react-select'
@@ -78,7 +79,7 @@ import {
     FilterParentType,
     GroupOptionType,
 } from './AppGroup.types'
-import { EditDescRequest, OptionType } from '../app/types'
+import { EditDescRequest } from '../app/types'
 import AppGroupAppFilter from './AppGroupAppFilter'
 import EnvCIDetails from './Details/EnvCIDetails/EnvCIDetails'
 import EnvCDDetails from './Details/EnvCDDetails/EnvCDDetails'

src/components/ApplicationGroup/Details/EnvironmentOverview/__mock__/EnvironmentOverview.mock.ts

@@ -16,7 +16,8 @@
 
 import { MultiValue } from 'react-select'
 
-import { OptionType } from '../../../../app/types'
+import { OptionType } from '@devtron-labs/devtron-fe-common-lib'
+
 import { AppGroupListType, EnvDeploymentStatus, EnvDeploymentStatusType } from '../../../AppGroup.types'
 
 const result = (): EnvDeploymentStatus[] => [

src/components/CIPipelineN/AdvancedConfigOptions.tsx

@@ -15,15 +15,14 @@
  */
 
 import { useContext, useEffect, useState } from 'react'
-import { CIBuildConfigType, CIBuildType, KeyValueTableProps, noop } from '@devtron-labs/devtron-fe-common-lib'
+import { CIBuildConfigType, CIBuildType, KeyValueTableProps, noop, OptionType } from '@devtron-labs/devtron-fe-common-lib'
 import CIConfig from '../ciConfig/CIConfig'
 import DockerArgs from './DockerArgs'
 import CustomImageTags from './CustomImageTags'
 import TargetPlatformSelector from '../ciConfig/TargetPlatformSelector'
 import { ComponentStates } from '../../Pages/Shared/EnvironmentOverride/EnvironmentOverrides.types'
 import { AdvancedConfigOptionsProps, CIConfigParentState } from '../ciConfig/types'
 import { DockerConfigOverrideKeys } from '../ciPipeline/types'
-import { OptionType } from '../app/types'
 import { getTargetPlatformMap } from '../ciConfig/CIConfig.utils'
 import { pipelineContext } from '../workflowEditor/workflowEditor'
 import '../ciConfig/CIConfig.scss'

src/components/CIPipelineN/TaskTypeDetailComponent.tsx

@@ -26,6 +26,7 @@ import {
     CustomInput,
     ClipboardButton,
     SelectPicker,
+    OptionType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { components } from 'react-select'
 import { TaskFieldDescription, TaskFieldLabel } from '../ciPipeline/types'
@@ -36,7 +37,6 @@ import MountFromHost from './MountFromHost'
 import CustomScript from './CustomScript'
 import { ReactComponent as AlertTriangle } from '../../assets/icons/ic-alert-triangle.svg'
 import { getCustomOptionSelectionStyle } from '../v2/common/ReactSelect.utils'
-import { OptionType } from '../app/types'
 import { ValidationRules } from '../ciPipeline/validationRules'
 import { ReactComponent as Info } from '../../assets/icons/ic-info-filled.svg'
 import { pipelineContext } from '../workflowEditor/workflowEditor'

src/components/ClusterNodes/NodeActions/EditTaintsModal.tsx

@@ -22,7 +22,6 @@ import {
     TippyCustomized,
     TippyTheme,
     stopPropagation,
-    InfoColourBar,
     SelectPicker,
     ToastVariantType,
     ToastManager,
@@ -32,15 +31,14 @@ import {
     ButtonVariantType,
     ButtonStyleType,
     InfoBlock,
+    OptionType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { useParams } from 'react-router-dom'
-import { ReactComponent as InfoIcon } from '../../../assets/icons/info-filled.svg'
 import { ReactComponent as Add } from '../../../assets/icons/ic-add.svg'
 import { ReactComponent as DeleteIcon } from '../../../assets/icons/ic-delete-interactive.svg'
 import { ReactComponent as HelpIcon } from '../../../assets/icons/ic-help.svg'
 import { ReactComponent as Close } from '../../../assets/icons/ic-close.svg'
 import { updateTaints } from '../clusterNodes.service'
-import { OptionType } from '../../app/types'
 import { EditTaintsModalType, EditTaintsRequest, EFFECT_TYPE, TaintErrorObj, TaintType } from '../types'
 import { ValidationRules } from './validationRules'
 import { EDIT_TAINTS_MODAL_MESSAGING, TAINT_OPTIONS } from '../constants'

src/components/ClusterNodes/types.ts

@@ -20,13 +20,14 @@ import {
     K8sResourceDetailDataType,
     NodeActionRequest,
     NodeTaintType,
+    OptionType,
     ResourceDetail,
     ResponseType,
 } from '@devtron-labs/devtron-fe-common-lib'
 
 import { UpdateTabUrlParamsType, UseTabsReturnType } from '@Components/common/DynamicTabs/types'
 
-import { LabelTag, OptionType } from '../app/types'
+import { LabelTag } from '../app/types'
 import { ClusterOptionType, K8SResourceListType, ResourceBrowserActionMenuType } from '../ResourceBrowser/Types'
 import { EditModeType } from '../v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/constants'
 import { CLUSTER_PAGE_TAB } from './constants'

src/components/app/details/appDetails/AppDetails.tsx

@@ -22,7 +22,6 @@ import {
     aggregateNodes,
     ArtifactInfoModal,
     Button,
-    ButtonComponentType,
     DeploymentAppTypes,
     GenericEmptyState,
     getAppsInfoForEnv,
@@ -43,7 +42,6 @@ import {
 import { ReactComponent as ForwardArrow } from '@Icons/ic-arrow-forward.svg'
 import { ReactComponent as Trash } from '@Icons/ic-delete-dots.svg'
 import AppNotConfiguredIcon from '@Images/app-not-configured.png'
-import AppNotDeployedIcon from '@Images/app-not-deployed.svg'
 import noGroups from '@Images/[email protected]'
 
 import {
@@ -53,7 +51,6 @@ import {
     DEPLOYMENT_STATUS_QUERY_PARAM,
     DOCUMENTATION,
     getAppDetailsURL,
-    getAppTriggerURL,
     HELM_DEPLOYMENT_STATUS_TEXT,
     RESOURCES_NOT_FOUND,
 } from '../../../../config'
@@ -172,41 +169,6 @@ export const AppNotConfigured = ({
     )
 }
 
-const EnvironmentNotConfigured = ({ environments }: Record<string, any>) => {
-    const environmentsMap = Array.isArray(environments)
-        ? environments.reduce((agg, curr) => {
-              // eslint-disable-next-line no-param-reassign
-              agg[curr.environmentId] = curr.environmentName
-              return agg
-          }, {})
-        : {}
-    const { envId, appId } = useParams<{ appId; envId }>()
-
-    const renderButton = () => (
-        <Button
-            dataTestId="go-to-trigger"
-            component={ButtonComponentType.link}
-            text="Go to Trigger"
-            linkProps={{
-                to: getAppTriggerURL(appId),
-            }}
-        />
-    )
-
-    return (
-        <GenericEmptyState
-            image={environmentsMap[+envId] ? AppNotDeployedIcon : AppNotConfiguredIcon}
-            title={
-                environmentsMap[+envId]
-                    ? `This app is not deployed on ${environmentsMap[+envId]}`
-                    : `Please select an environment to view app details`
-            }
-            isButtonAvailable={environmentsMap[+envId]}
-            renderButton={renderButton}
-        />
-    )
-}
-
 const DeletedAppComponent: React.FC<DeletedAppComponentType> = ({
     resourceTreeFetchTimeOut,
     showApplicationDetailedModal,
@@ -915,7 +877,12 @@ const AppDetail = ({ detailsType, filteredResourceIds }: AppDetailProps) => {
     const renderAppNotConfigured = () => (
         <>
             {envList.length === 0 && !isAppDeleted && <AppNotConfigured />}
-            {!params.envId && envList.length > 0 && <EnvironmentNotConfigured environments={envList} />}
+            {!params.envId && envList.length > 0 && (
+                <GenericEmptyState
+                    image={AppNotConfiguredIcon}
+                    title="Please select an environment to view app details"
+                />
+            )}
         </>
     )
 

src/components/app/details/appDetails/appDetails.type.ts

@@ -18,6 +18,7 @@ import {
     ACTION_STATE,
     AppEnvironment,
     EnvAppsMetaDTO,
+    OptionType,
     ResponseType,
     ScanResultDTO,
     SelectPickerProps,
@@ -27,7 +28,7 @@ import {
 import { fetchAppDetailsInTime } from '@Components/app/service'
 
 import { AppDetails, SyncErrorType } from '../../../v2/appDetails/appDetails.type'
-import { AggregatedNodes, OptionType } from '../../types'
+import { AggregatedNodes } from '../../types'
 
 export enum AppMetricsTab {
     Aggregate = 'aggregate',