Skip to content

Commit e42cb9b

Browse files
committed
fix: remove useless ? from param promise list
1 parent b767c4e commit e42cb9b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/components/ApplicationGroup/Details/TriggerView/BulkCITrigger.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,8 @@ const BulkCITrigger = ({
131131
getMaterialData()
132132
}, [])
133133

134-
135-
const getRunTimeParamsData = (_materialListMap: Record<string, any[]>): void => {
136-
const runTimeParamsPromiseList = appList.map((appDetails) => {
134+
const getRuntimeParamsData = (_materialListMap: Record<string, any[]>): void => {
135+
const runtimeParamsPromiseList = appList.map((appDetails) => {
137136
if (getIsAppUnorthodox(appDetails) || !_materialListMap[appDetails.appId]) {
138137
return {
139138
[appDetails.ciPipelineId]: [],
@@ -142,8 +141,8 @@ const BulkCITrigger = ({
142141
return getRuntimeParams(appDetails.ciPipelineId)
143142
})
144143

145-
if (runTimeParamsPromiseList?.length) {
146-
Promise.all(runTimeParamsPromiseList)
144+
if (runtimeParamsPromiseList.length) {
145+
Promise.all(runtimeParamsPromiseList)
147146
.then((responses) => {
148147
const _runtimeParams: Record<string, KeyValueListType[]> = {}
149148
responses.forEach((res, index) => {
@@ -177,11 +176,12 @@ const BulkCITrigger = ({
177176
responses.forEach((res, index) => {
178177
_materialListMap[appList[index]?.appId] = res?.['result']
179178
})
179+
// These two handlers should be imported from elsewhere
180180
if (getCIBlockState) {
181181
getPolicyEnforcementData(_materialListMap)
182182
}
183183
if (getRuntimeParams) {
184-
getRunTimeParamsData(_materialListMap)
184+
getRuntimeParamsData(_materialListMap)
185185
}
186186
updateBulkInputMaterial(_materialListMap)
187187
if (!getIsAppUnorthodox(selectedApp)) {

0 commit comments

Comments
 (0)