Skip to content

Commit e5875d5

Browse files
committed
chore: css fixes
1 parent 1cff500 commit e5875d5

File tree

7 files changed

+31
-24
lines changed

7 files changed

+31
-24
lines changed

src/Pages/GlobalConfigurations/DeploymentCharts/List/UploadChartModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ const UploadChartModal = ({ closeUploadPopup }: UploadChartModalType) => {
199199
2. Image descriptor template file - .image_descriptor_template.json.
200200
</div>
201201
<div className="cn-7 fw-4 fs-14 cn-7 mb-20">3. Custom chart packaged in the *.tgz format.</div>
202-
<div className="sidebar-action-container pr-20">
202+
<div className="flexbox-col dc__align-start">
203203
<div className="fw-6 fs-13 cn-9 mb-8">
204204
📙 Need help?&nbsp;
205205
<DocLink

src/components/CIPipelineN/Sidebar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ export const Sidebar = ({
403403
)}
404404
</div>
405405
) : (
406-
<div className="sidebar-action-container pr-20 flexbox-col dc__gap-4">
406+
<div className="flexbox-col dc__gap-4">
407407
<div className="dc__uppercase fw-6 fs-12 cn-6">Trigger {isJobCard ? 'JOB' : 'BUILD'} PIPELINE</div>
408408
<div>
409409
<RadioGroup
@@ -448,7 +448,7 @@ export const Sidebar = ({
448448
)}
449449

450450
{!isCdPipeline && (
451-
<div className="sidebar-action-container pr-20">
451+
<div className="sidebar-action-container flexbox-col dc__align-start pr-20">
452452
<div className="fw-6 fs-13 cn-9 mb-8">📙 Need help?</div>
453453
<DocLink
454454
docLinkKey={helpData.docLink}

src/components/app/details/triggerView/TriggerView.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import {
3636
getEnvironmentListMinPublic,
3737
CIPipelineNodeType,
3838
DocLink,
39+
getDocumentationUrl,
3940
} from '@devtron-labs/devtron-fe-common-lib'
4041
import ReactGA from 'react-ga4'
4142
import { withRouter, Route, Switch } from 'react-router-dom'
@@ -1430,11 +1431,9 @@ class TriggerView extends Component<TriggerViewProps, TriggerViewState> {
14301431
return (
14311432
<>
14321433
{APP_DETAILS.JOB_FULLY_NOT_CONFIGURED.subTitle}&nbsp;
1433-
<DocLink
1434-
text={APP_DETAILS.NEED_HELP}
1435-
docLinkKey="APP_CREATE"
1436-
dataTestId="learn-more-about-creating-job-link"
1437-
/>
1434+
<a href={getDocumentationUrl({ docLinkKey: 'APP_CREATE' })} target="_blank noopener noreferrer">
1435+
{APP_DETAILS.NEED_HELP}
1436+
</a>
14381437
</>
14391438
)
14401439
}

src/components/app/list-new/HelmAppList.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import {
3131
useStickyEvent,
3232
getClassNameForStickyHeaderWithShadow,
3333
DocLink,
34+
ComponentSizeType,
3435
} from '@devtron-labs/devtron-fe-common-lib'
3536
import { Link } from 'react-router-dom'
3637
import Tippy from '@tippyjs/react'
@@ -469,10 +470,10 @@ const HelmAppList = ({
469470
<span className="mr-8 flex">
470471
<InfoFillPurple className="icon-dim-20" />
471472
</span>
472-
<span>
473+
<div className="flexbox">
473474
{SELECT_CLUSTER_FROM_FILTER_NOTE}&nbsp;
474-
<DocLink docLinkKey="HYPERION" dataTestId="learn-more-about-hyperion-link" />
475-
</span>
475+
<DocLink docLinkKey="HYPERION" dataTestId="learn-more-about-hyperion-link" size={ComponentSizeType.xs} />
476+
</div>
476477
</div>
477478
</div>
478479
)}

src/components/charts/SavedValues/SavedValuesList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export default function SavedValuesList() {
171171
const renderSubtitleAndNewButton = (subtitleText: string): JSX.Element => {
172172
return (
173173
<>
174-
<p className="fs-13 fw-4">
174+
<p className="flexbox fs-13 fw-4">
175175
{subtitleText}&nbsp;
176176
<DocLink docLinkKey="CUSTOM_VALUES" dataTestId="preset-values-learn-more-link" />
177177
</p>

src/components/charts/list/DiscoverCharts.tsx

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import {
3030
Button,
3131
ComponentSizeType,
3232
ButtonVariantType,
33+
getDocumentationUrl,
3334
} from '@devtron-labs/devtron-fe-common-lib'
3435
import { Switch, Route, NavLink, useHistory, useLocation, useRouteMatch, Prompt } from 'react-router-dom'
3536
import Tippy from '@tippyjs/react'
@@ -751,11 +752,15 @@ const ChartListHeader = ({ charts }) => {
751752
</h3>
752753
<p className="mb-0 mt-4 pl-20" data-testid="chart-store-list-subheading">
753754
Select chart to deploy. &nbsp;
754-
<DocLink
755-
docLinkKey="CHART_LIST"
756-
dataTestId="chart-store-link"
757-
text="Learn more about deploying charts"
758-
/>
755+
<a
756+
href={getDocumentationUrl({ docLinkKey: 'CHART_GROUP' })}
757+
rel="noreferrer noopener"
758+
target="_blank"
759+
className="dc__link"
760+
data-testid="chart-group-link"
761+
>
762+
Learn more about chart groups
763+
</a>
759764
</p>
760765
</div>
761766
)
@@ -784,11 +789,15 @@ export const EmptyChartGroup = ({
784789
{subTitle || 'Use chart groups to preconfigure and deploy frequently used charts together.'}
785790
</div>
786791
{!removeLearnMore && (
787-
<DocLink
788-
docLinkKey={'CHART_GROUP'}
789-
text="Learn more about chart groups"
790-
dataTestId="chart-group-link"
791-
/>
792+
<a
793+
href={getDocumentationUrl({ docLinkKey: 'CHART_GROUP' })}
794+
rel="noreferrer noopener"
795+
target="_blank"
796+
className="dc__link"
797+
data-testid="chart-group-link"
798+
>
799+
Learn more about chart groups
800+
</a>
792801
)}
793802
{typeof onClickViewChartButton === 'function' ? (
794803
<button type="button" onClick={onClickViewChartButton} className="cta ghosted flex mb-24 mt-24">
@@ -844,7 +853,6 @@ export const ChartGroupListMin = ({
844853
'Use chart groups to pre-configure and deploy frequently used charts together.'
845854
}
846855
docLink='CHART_GROUP'
847-
docLinkText="Learn more"
848856
dataTestId="chart-store"
849857
showInfoIconTippy
850858
/>

src/components/ciPipeline/Webhook/WebhookDetailsModal.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,6 @@ export const WebhookDetailsModal = ({ close, isTemplateView }: WebhookDetailType
478478
text="How to generate API tokens?"
479479
dataTestId="learn-more-about-generating-api-tokens"
480480
/>
481-
482481
)
483482
}
484483
return !showTokenSection ? (

0 commit comments

Comments
 (0)