fix: review comments

AbhishekA1509 · AbhishekA1509 · commit e922d017ee39 · 2025-05-14T17:31:36.000+05:30
diff --git a/src/components/app/details/appDetails/AppDetails.tsx b/src/components/app/details/appDetails/AppDetails.tsx
@@ -650,9 +650,7 @@ const Details: React.FC<DetailsType> = ({
         />
     )
 
-    const handleUpdateDeploymentStatusDetailsBreakdownData = (
-        updatedTimelines: DeploymentStatusDetailsBreakdownDataType,
-    ) => {
+    const updateDeploymentStatusDetailsBreakdownData = (updatedTimelines: DeploymentStatusDetailsBreakdownDataType) => {
         setDeploymentStatusDetailsBreakdownData(updatedTimelines)
     }
 
@@ -724,7 +722,7 @@ const Details: React.FC<DetailsType> = ({
                         showAppStatusModal ? AppStatusModalTabType.APP_STATUS : AppStatusModalTabType.DEPLOYMENT_STATUS
                     }
                     processVirtualEnvironmentDeploymentData={processVirtualEnvironmentDeploymentData}
-                    handleUpdateDeploymentStatusDetailsBreakdownData={handleUpdateDeploymentStatusDetailsBreakdownData}
+                    updateDeploymentStatusDetailsBreakdownData={updateDeploymentStatusDetailsBreakdownData}
                     debugWithAIButton={ExplainWithAIButton}
                 />
             )}
diff --git a/src/components/app/details/appDetails/appDetails.scss b/src/components/app/details/appDetails/appDetails.scss
@@ -1365,10 +1365,6 @@ table.resource-tree {
     }
 }
 
-.deployment-approval-container + .deployment-status-breakdown-container {
-    padding-top: 0px;
-}
-
 .env-select {
     font-weight: 600 !important;
     color: var(--B500);
diff --git a/src/components/app/details/appDetails/appDetails.service.ts b/src/components/app/details/appDetails/appDetails.service.ts
@@ -95,7 +95,7 @@ export function getDeploymentStatusDetail(
         appendUrl = Routes.DEPLOYMENT_STATUS
     }
     return get(
-        `${appendUrl}/${appId}/${envId}${`?showTimeline=${false}`}${triggerId ? `&wfrId=${triggerId}` : ``}${installedAppVersionHistoryId ? `&installedAppVersionHistoryId=${installedAppVersionHistoryId}` : ''}`,
+        `${appendUrl}/${appId}/${envId}?showTimeline=false${triggerId ? `&wfrId=${triggerId}` : ``}${installedAppVersionHistoryId ? `&installedAppVersionHistoryId=${installedAppVersionHistoryId}` : ''}`,
     )
 }
 
diff --git a/src/components/v2/appDetails/AppDetails.component.tsx b/src/components/v2/appDetails/AppDetails.component.tsx
@@ -142,7 +142,7 @@ const AppDetailsComponent = ({
         })
     }
 
-    const handleUpdateDeploymentStatusDetailsBreakdownData = (
+    const updateDeploymentStatusDetailsBreakdownData = (
         updatedTimelineData: typeof deploymentStatusDetailsBreakdownData,
     ) => {
         setDeploymentStatusDetailsBreakdownData(updatedTimelineData)
@@ -204,9 +204,7 @@ const AppDetailsComponent = ({
                                 loadingResourceTree={loadingResourceTree || !appDetails?.appType}
                                 deploymentStatusDetailsBreakdownData={deploymentStatusDetailsBreakdownData}
                                 isVirtualEnvironment={isVirtualEnv.current}
-                                handleUpdateDeploymentStatusDetailsBreakdownData={
-                                    handleUpdateDeploymentStatusDetailsBreakdownData
-                                }
+                                updateDeploymentStatusDetailsBreakdownData={updateDeploymentStatusDetailsBreakdownData}
                             />
                         )}
                     </div>
@@ -236,9 +234,7 @@ const AppDetailsComponent = ({
                             configDriftModal={null}
                             initialTab={AppStatusModalTabType.DEPLOYMENT_STATUS}
                             processVirtualEnvironmentDeploymentData={processVirtualEnvironmentDeploymentData}
-                            handleUpdateDeploymentStatusDetailsBreakdownData={
-                                handleUpdateDeploymentStatusDetailsBreakdownData
-                            }
+                            updateDeploymentStatusDetailsBreakdownData={updateDeploymentStatusDetailsBreakdownData}
                             debugWithAIButton={ExplainWithAIButton}
                         />
                     )}
diff --git a/src/components/v2/appDetails/sourceInfo/environment.type.ts b/src/components/v2/appDetails/sourceInfo/environment.type.ts
@@ -29,7 +29,7 @@ export interface EnvironmentStatusComponentType {
     loadingResourceTree: boolean
     deploymentStatusDetailsBreakdownData: DeploymentStatusDetailsBreakdownDataType
     isVirtualEnvironment?: boolean
-    handleUpdateDeploymentStatusDetailsBreakdownData: (data: DeploymentStatusDetailsBreakdownDataType) => void
+    updateDeploymentStatusDetailsBreakdownData: (data: DeploymentStatusDetailsBreakdownDataType) => void
 }
 export interface AppEnvironment extends BaseAppEnvironmentType {
     isSelected?: boolean
diff --git a/src/components/v2/appDetails/sourceInfo/environmentStatus/EnvironmentStatus.component.tsx b/src/components/v2/appDetails/sourceInfo/environmentStatus/EnvironmentStatus.component.tsx
@@ -56,7 +56,7 @@ const EnvironmentStatusComponent = ({
     loadingResourceTree,
     deploymentStatusDetailsBreakdownData,
     isVirtualEnvironment,
-    handleUpdateDeploymentStatusDetailsBreakdownData,
+    updateDeploymentStatusDetailsBreakdownData,
 }: EnvironmentStatusComponentType) => {
     const [appDetails] = useSharedState(IndexStore.getAppDetails(), IndexStore.getAppDetailsObservable())
     const [showAppStatusDetail, setShowAppStatusDetail] = useState(false)
@@ -214,7 +214,7 @@ const EnvironmentStatusComponent = ({
                     isConfigDriftEnabled={false}
                     configDriftModal={null}
                     initialTab={AppStatusModalTabType.APP_STATUS}
-                    handleUpdateDeploymentStatusDetailsBreakdownData={handleUpdateDeploymentStatusDetailsBreakdownData}
+                    updateDeploymentStatusDetailsBreakdownData={updateDeploymentStatusDetailsBreakdownData}
                     processVirtualEnvironmentDeploymentData={processVirtualEnvironmentDeploymentData}
                     debugWithAIButton={ExplainWithAIButton}
                 />
diff --git a/src/components/v2/devtronStackManager/DevtronStackManager.tsx b/src/components/v2/devtronStackManager/DevtronStackManager.tsx
@@ -595,7 +595,7 @@ export default function DevtronStackManager({
                                         configDriftModal={null}
                                         initialTab={AppStatusModalTabType.APP_STATUS}
                                         processVirtualEnvironmentDeploymentData={noop}
-                                        handleUpdateDeploymentStatusDetailsBreakdownData={noop}
+                                        updateDeploymentStatusDetailsBreakdownData={noop}
                                         debugWithAIButton={ExplainWithAIButton}
                                     />
                                 )}

Original file line number	Diff line number	Diff line change
`@@ -650,9 +650,7 @@ const Details: React.FC<DetailsType> = ({`
`650`	`650`	`/>`
`651`	`651`	`)`
`652`	`652`
`653`		`- const handleUpdateDeploymentStatusDetailsBreakdownData = (`
`654`		`- updatedTimelines: DeploymentStatusDetailsBreakdownDataType,`
`655`		`- ) => {`
	`653`	`+ const updateDeploymentStatusDetailsBreakdownData = (updatedTimelines: DeploymentStatusDetailsBreakdownDataType) => {`
`656`	`654`	`setDeploymentStatusDetailsBreakdownData(updatedTimelines)`
`657`	`655`	`}`
`658`	`656`
`@@ -724,7 +722,7 @@ const Details: React.FC<DetailsType> = ({`
`724`	`722`	`showAppStatusModal ? AppStatusModalTabType.APP_STATUS : AppStatusModalTabType.DEPLOYMENT_STATUS`
`725`	`723`	`}`
`726`	`724`	`processVirtualEnvironmentDeploymentData={processVirtualEnvironmentDeploymentData}`
`727`		`- handleUpdateDeploymentStatusDetailsBreakdownData={handleUpdateDeploymentStatusDetailsBreakdownData}`
	`725`	`+ updateDeploymentStatusDetailsBreakdownData={updateDeploymentStatusDetailsBreakdownData}`
`728`	`726`	`debugWithAIButton={ExplainWithAIButton}`
`729`	`727`	`/>`
`730`	`728`	`)}`
Original file line number	Diff line number	Diff line change
`@@ -1365,10 +1365,6 @@ table.resource-tree {`
`1365`	`1365`	`}`
`1366`	`1366`	`}`
`1367`	`1367`
`1368`		`-.deployment-approval-container + .deployment-status-breakdown-container {`
`1369`		`- padding-top: 0px;`
`1370`		`-}`
`1371`		`-`
`1372`	`1368`	`.env-select {`
`1373`	`1369`	`font-weight: 600 !important;`
`1374`	`1370`	`color: var(--B500);`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ export function getDeploymentStatusDetail(`
`95`	`95`	`appendUrl = Routes.DEPLOYMENT_STATUS`
`96`	`96`	`}`
`97`	`97`	`return get(`
`98`		- `${appendUrl}/${appId}/${envId}${`?showTimeline=${false}`}${triggerId ? `&wfrId=${triggerId}` : ``}${installedAppVersionHistoryId ? `&installedAppVersionHistoryId=${installedAppVersionHistoryId}` : ''}`,
	`98`	+ `${appendUrl}/${appId}/${envId}?showTimeline=false${triggerId ? `&wfrId=${triggerId}` : ``}${installedAppVersionHistoryId ? `&installedAppVersionHistoryId=${installedAppVersionHistoryId}` : ''}`,
`99`	`99`	`)`
`100`	`100`	`}`
`101`	`101`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export interface EnvironmentStatusComponentType {`
`29`	`29`	`loadingResourceTree: boolean`
`30`	`30`	`deploymentStatusDetailsBreakdownData: DeploymentStatusDetailsBreakdownDataType`
`31`	`31`	`isVirtualEnvironment?: boolean`
`32`		`- handleUpdateDeploymentStatusDetailsBreakdownData: (data: DeploymentStatusDetailsBreakdownDataType) => void`
	`32`	`+ updateDeploymentStatusDetailsBreakdownData: (data: DeploymentStatusDetailsBreakdownDataType) => void`
`33`	`33`	`}`
`34`	`34`	`export interface AppEnvironment extends BaseAppEnvironmentType {`
`35`	`35`	`isSelected?: boolean`