Skip to content

Commit e9e37db

Browse files
committed
Merge branch 'main' of github.com:devtron-labs/dashboard into feat/toast-manager
2 parents 0e6ff44 + 320d1d6 commit e9e37db

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/Pages/GlobalConfigurations/Authorization/Shared/components/AppPermissions/AppPermissions.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ const AppPermissions = () => {
329329

330330
return [
331331
...defaultValueArr,
332-
...(selectedCluster.environments?.map((env) => ({
332+
...(selectedCluster?.environments?.map((env) => ({
333333
label: env.environmentName,
334334
value: env.environmentIdentifier,
335335
namespace: env.namespace,

src/Pages/GlobalConfigurations/Authorization/Shared/components/AppPermissions/common.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,17 +113,11 @@ export const ClusterValueContainer = (props) => {
113113
} else {
114114
count = `${length} environment${length !== 1 ? 's' : ''}`
115115
}
116+
116117
return (
117118
<components.ValueContainer {...props}>
118-
{length > 0 ? (
119-
<>
120-
{!props.selectProps.menuIsOpen && count}
121-
{React.cloneElement(props.children[1])}
122-
</>
123-
) : (
124-
// eslint-disable-next-line react/jsx-no-useless-fragment
125-
<>{props.children}</>
126-
)}
119+
{!props.selectProps.menuIsOpen && (length > 0 ? count : props.selectProps.placeholder)}
120+
{React.cloneElement(props.children[1])}
127121
</components.ValueContainer>
128122
)
129123
}

0 commit comments

Comments
 (0)