Skip to content

Commit f33613e

Browse files
committed
chore: GA event added
1 parent 4194d64 commit f33613e

File tree

4 files changed

+23
-6
lines changed

4 files changed

+23
-6
lines changed

src/components/app/details/AppHeader.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import {
2828
useBreadcrumb,
2929
} from '@devtron-labs/devtron-fe-common-lib'
3030

31-
import { ReactComponent as Settings } from '../../../assets/icons/ic-settings.svg'
3231
import { URLS } from '../../../config'
3332
import { FilterParentType } from '../../ApplicationGroup/AppGroup.types'
3433
import AppGroupAppFilter from '../../ApplicationGroup/AppGroupAppFilter'
@@ -231,7 +230,7 @@ export const AppHeader = ({
231230
id: 'app-configuration-tab',
232231
label: 'Configurations',
233232
tabType: 'navLink',
234-
icon: Settings,
233+
icon: 'ic-sliders-vertical',
235234
props: {
236235
to: `${match.url}/${CommonURLS.APP_CONFIG}`,
237236
'data-action': 'App Configuration Clicked',

src/components/app/details/appDetails/AppDetailsCDButton.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616

1717
import React from 'react'
18+
import ReactGA from 'react-ga4'
1819
import { useHistory, useLocation } from 'react-router-dom'
1920

2021
import {
@@ -39,6 +40,7 @@ import { AppDetailsCDButtonType } from '../../types'
3940
import CDMaterial from '../triggerView/cdMaterial'
4041
import { TRIGGER_VIEW_PARAMS } from '../triggerView/Constants'
4142
import { MATERIAL_TYPE } from '../triggerView/types'
43+
import { DA_APP_DETAILS_GA_EVENTS } from './constants'
4244
import { getDeployButtonStyle } from './utils'
4345

4446
const ApprovalMaterialModal = importComponentFromFELibrary('ApprovalMaterialModal')
@@ -69,6 +71,8 @@ const AppDetailsCDButton = ({
6971
history.push({
7072
search: new URLSearchParams(newParams).toString(),
7173
})
74+
75+
ReactGA.event(DA_APP_DETAILS_GA_EVENTS.DeployButtonClicked)
7276
}
7377

7478
const closeCDModal = (e: React.MouseEvent): void => {

src/components/app/details/appDetails/SourceInfo.tsx

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import { useMemo, useState } from 'react'
1818
import { Link, useHistory, useParams } from 'react-router-dom'
19+
import ReactGA from 'react-ga4'
1920
import moment from 'moment'
2021
import {
2122
Button,
@@ -33,7 +34,7 @@ import {
3334
Tooltip,
3435
} from '@devtron-labs/devtron-fe-common-lib'
3536
import { ReactComponent as ICCamera } from '@Icons/ic-camera.svg'
36-
import { URLS } from '../../../../config'
37+
import { APP_COMPOSE_STAGE, getAppComposeURL, URLS } from '../../../../config'
3738
import { EnvSelector } from './AppDetails'
3839
import { DeploymentAppTypeNameMapping } from '../../../../config/constantMessaging'
3940
import { Nodes, SourceInfoType } from '../../types'
@@ -52,6 +53,7 @@ import { ReactComponent as Trash } from '../../../../assets/icons/ic-delete-dots
5253
import { ReactComponent as ScaleDown } from '../../../../assets/icons/ic-scale-down.svg'
5354
import HelmAppConfigApplyStatusCard from '@Components/v2/appDetails/sourceInfo/environmentStatus/HelmAppConfigApplyStatusCard'
5455
import { HibernationModalTypes } from './appDetails.type'
56+
import { DA_APP_DETAILS_GA_EVENTS } from './constants'
5557

5658
const AppDetailsDownloadCard = importComponentFromFELibrary('AppDetailsDownloadCard')
5759
const DeploymentWindowStatusCard = importComponentFromFELibrary('DeploymentWindowStatusCard')
@@ -155,7 +157,8 @@ export const SourceInfo = ({
155157
}
156158

157159
const onClickSliderVerticalButton = () => {
158-
history.push(`${URLS.APP}/${params.appId}/edit/${URLS.APP_ENV_OVERRIDE_CONFIG}/${params.envId}`)
160+
history.push(`${getAppComposeURL(params.appId, APP_COMPOSE_STAGE.ENV_OVERRIDE, false, false)}/${params.envId}`)
161+
ReactGA.event(DA_APP_DETAILS_GA_EVENTS.GoToEnvironmentConfiguration)
159162
}
160163

161164
const renderDevtronAppsEnvironmentSelector = (environment) => {
@@ -286,14 +289,14 @@ export const SourceInfo = ({
286289
/>
287290
)}
288291
<Button
289-
dataTestId="deploy-button"
292+
dataTestId="app-details-env-config-button"
290293
size={ComponentSizeType.small}
291294
icon={<Icon name="ic-sliders-vertical" color={null} />}
292295
variant={ButtonVariantType.secondary}
293296
onClick={onClickSliderVerticalButton}
294297
component={ButtonComponentType.button}
295298
style={ButtonStyleType.neutral}
296-
ariaLabel="Go to Env Configuration"
299+
ariaLabel="Go to Environment Configuration"
297300
/>
298301
{window._env_.FEATURE_SWAP_TRAFFIC_ENABLE &&
299302
SwapTraffic &&

src/components/app/details/appDetails/constants.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,14 @@
1515
*/
1616

1717
export const APP_METRICS_CALENDAR_INPUT_DATE_FORMAT = 'DD-MM-YYYY hh:mm:ss'
18+
19+
export const DA_APP_DETAILS_GA_EVENTS = {
20+
DeployButtonClicked: {
21+
category: 'App Details',
22+
action: 'DA_APP_DETAIL_DEPLOY',
23+
},
24+
GoToEnvironmentConfiguration: {
25+
category: 'App Details',
26+
action: 'DA_APP_DETAIL_GO_TO_ENV_CONFIG',
27+
},
28+
}

0 commit comments

Comments
 (0)