Skip to content

Commit f6aa7c4

Browse files
Merge branch 'main' into fix/ci-pipeline-override
2 parents d7e6536 + ff5e786 commit f6aa7c4

File tree

5 files changed

+29
-16
lines changed

5 files changed

+29
-16
lines changed

src/components/app/Overview/Overview.tsx

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import { EnvironmentList } from './EnvironmentList'
3535
import { MAX_LENGTH_350 } from '../../../config/constantMessaging'
3636
import { getModuleInfo } from '../../v2/devtronStackManager/DevtronStackManager.service'
3737
import { MODAL_STATE, OVERVIEW_TABS, TAB_SEARCH_KEY } from './constants'
38+
import ReactGA from 'react-ga4'
3839
const MandatoryTagWarning = importComponentFromFELibrary('MandatoryTagWarning')
3940
const Catalog = importComponentFromFELibrary('Catalog')
4041
const DependencyList = importComponentFromFELibrary('DependencyList')
@@ -87,6 +88,15 @@ export default function AppOverview({ appMetaInfo, getAppMetaInfoRes, filteredEn
8788
history.replace({ search: searchParams.toString() })
8889
}
8990

91+
const handleEditDependencyClick = () => {
92+
ReactGA.event({
93+
category: 'Application Dependency',
94+
action: 'Edit Dependency click',
95+
label: 'Edit Dependency click',
96+
})
97+
toggleUpdateDependencyModal()
98+
}
99+
90100
useEffect(() => {
91101
// add a default tab if not set
92102
if (!activeTab || !Object.values(OVERVIEW_TABS).includes(activeTab)) {
@@ -481,6 +491,7 @@ export default function AppOverview({ appMetaInfo, getAppMetaInfoRes, filteredEn
481491
isUpdateModalOpen={isUpdateDependencyModalOpen}
482492
toggleUpdateModalOpen={toggleUpdateDependencyModal}
483493
toggleButtonDisabledState={setIsEditDependencyButtonDisabled}
494+
filteredEnvIds={filteredEnvIds}
484495
/>
485496
) : null,
486497
}
@@ -507,7 +518,7 @@ export default function AppOverview({ appMetaInfo, getAppMetaInfoRes, filteredEn
507518
<button
508519
type="button"
509520
className={`cta flex h-28 dc__gap-4 ${isEditDependencyButtonDisabled ? 'disabled-opacity' : ''}`}
510-
onClick={isEditDependencyButtonDisabled ? noop : toggleUpdateDependencyModal}
521+
onClick={isEditDependencyButtonDisabled ? noop : handleEditDependencyClick}
511522
>
512523
<EditIcon className="mw-14 icon-dim-14 scn-0 dc__no-svg-fill" />
513524
Edit Dependency

src/components/ciPipeline/Webhook/WebhookDetailsModal.tsx

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -361,18 +361,16 @@ export function WebhookDetailsModal({ close }: WebhookDetailType) {
361361

362362
const renderWebhookURLTokenContainer = (): JSX.Element => {
363363
return (
364-
<div className="mb-16">
365-
<div className="flexbox w-100 dc__position-rel en-2 bw-1 br-4 h-32">
366-
<CustomInput
367-
name="api-token"
368-
label={renderWebhhokTokenLabel()}
369-
placeholder="Enter API token"
370-
rootClassName="bcn-0 dc__no-border"
371-
onChange={handleTokenChange}
372-
value={tryoutAPIToken}
373-
error={showTryoutAPITokenError && WEBHOOK_NO_API_TOKEN_ERROR}
374-
/>
375-
</div>
364+
<div className="flexbox w-100 dc__position-rel en-2 bw-1 br-4 h-32 mb-16">
365+
{renderWebhhokTokenLabel()}
366+
<CustomInput
367+
name="api-token"
368+
placeholder="Enter API token"
369+
rootClassName="bcn-0 dc__no-border-imp w-100 h-32 pt-5-imp p-0-8-imp"
370+
onChange={handleTokenChange}
371+
value={tryoutAPIToken}
372+
error={showTryoutAPITokenError && WEBHOOK_NO_API_TOKEN_ERROR}
373+
/>
376374
</div>
377375
)
378376
}

src/components/deploymentGroups/BulkActionEdit.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ function TitledCard({ number, completed = false, title, next, onClick, children
400400
<div className={`title-container ${completed ? 'active' : ''}`}>
401401
<div className="index flex">{number}</div>
402402
<div className="title flex left cn-9">{title}</div>
403-
<div className="next flex">{completed && typeof next === 'function' && <button className="cta" onClick={next} type="button">Next</button>}</div>
403+
<div className="next flex">{completed && typeof next === 'function' && <button className="cta flex" onClick={next} type="button">Next</button>}</div>
404404
</div>
405405
{children}
406406
</div>

src/components/material/MaterialView.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,9 +395,9 @@ export class MaterialView extends Component<MaterialViewProps, MaterialViewState
395395

396396
renderGitRepoUrlLabel = (): JSX.Element => {
397397
return (
398-
<label className="form__label">
398+
<>
399399
Git Repo URL<span className="cr-5">* </span>(use {this.gitAuthType('host')})
400-
</label>
400+
</>
401401
)
402402
}
403403

src/css/base.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3421,6 +3421,10 @@ textarea,
34213421
padding: 6px 12px !important;
34223422
}
34233423

3424+
.p-0-8-imp {
3425+
padding: 0px 8px !important;
3426+
}
3427+
34243428
// Margin in pixels
34253429
.dc__m-auto {
34263430
margin: auto;

0 commit comments

Comments
 (0)