Skip to content

Commit fa54d51

Browse files
committed
chore: code refactoring
1 parent 4e742e6 commit fa54d51

File tree

5 files changed

+18
-7
lines changed

5 files changed

+18
-7
lines changed

src/Pages/Applications/DevtronApps/Details/AppConfigurations/AppConfig.utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ export const getNavItems = ({
255255
href: `${basePath}/edit/workflow`,
256256
stage: STAGE_NAME.WORKFLOW,
257257
isLocked: !_isUnlocked.workflowEditor,
258-
supportDocumentURL: 'test',
258+
supportDocumentURL: getDocumentationUrl({ docLinkKey: 'APP_CREATE_WORKFLOW' }),
259259
flowCompletionPercent: completedPercent,
260260
currentStep: completedSteps,
261261
required: true,

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DTChartSelector.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ const ChartSelectorDropdown = ({
185185
<DocLink
186186
docLinkKey={CHART_DOCUMENTATION_LINK[chart.name]}
187187
dataTestId="chart-doc-link"
188+
onClick={stopPropagation}
188189
/>
189190
)}
190191
</div>

src/Pages/Applications/DevtronApps/Details/AppConfigurations/Navigation/EnvironmentOverrideRouter.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import { Fragment, useEffect, useState } from 'react'
1818
import { Link, NavLink, useLocation, useParams, useRouteMatch } from 'react-router-dom'
1919

2020
import {
21+
ComponentSizeType,
2122
ConfirmationDialog,
2223
DeleteConfirmationModal,
2324
DocLink,
@@ -50,7 +51,11 @@ const EnvOverridesHelpNote = () => (
5051
<div className="fs-12 fw-4 lh-18">
5152
Environment overrides allow you to manage environment specific configurations after you’ve created deployment
5253
pipelines. &nbsp;
53-
<DocLink docLinkKey="APP_CREATE_ENVIRONMENT_OVERRIDE" dataTestId="env-overrides-learn-more" />
54+
<DocLink
55+
docLinkKey="APP_CREATE_ENVIRONMENT_OVERRIDE"
56+
dataTestId="env-overrides-learn-more"
57+
size={ComponentSizeType.xs}
58+
/>
5459
</div>
5560
)
5661

src/components/externalLinks/ExternalLinks.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ const ExternalLinks = ({ isAppConfigView, userRole }: ExternalLinksProps) => {
265265
infoText="Configure links to third-party applications (e.g. Kibana, New Relic) for quick access. Configured
266266
links will be available in the App details page."
267267
documentationLink="EXTERNAL_LINKS"
268+
documentationLinkText="View Documentation"
268269
iconClassName="icon-dim-20 fcn-6 ml-8"
269270
/>
270271
</h3>

src/components/material/MaterialList.tsx

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {
2121
ErrorScreenManager,
2222
sortCallback,
2323
AppListConstants,
24-
DocLink,
24+
getDocumentationUrl,
2525
} from '@devtron-labs/devtron-fe-common-lib'
2626
import { getGitProviderListAuth, getSourceConfig } from '../../services/service'
2727
import { AppConfigStatus, ViewType, DEVTRON_NODE_DEPLOY_VIDEO } from '../../config'
@@ -164,10 +164,14 @@ class MaterialList extends Component<MaterialListProps, MaterialListState> {
164164
</h2>
165165
<p className="form__subtitle form__subtitle--artifacts">
166166
Manage source code repositories for this {this.props.isJobView ? 'job' : 'application'}.&nbsp;
167-
<DocLink
168-
docLinkKey={this.props.isJobView ? "JOB_SOURCE_CODE" : "GLOBAL_CONFIG_GIT"}
169-
dataTestId="learn-more-about-git-repositories-link"
170-
/>
167+
<a
168+
rel="noreferrer noopener"
169+
target="_blank"
170+
className="dc__link"
171+
href={getDocumentationUrl({ docLinkKey: this.props.isJobView ? "JOB_SOURCE_CODE" : "GLOBAL_CONFIG_GIT"})}
172+
>
173+
Learn more
174+
</a>
171175
</p>
172176
</>
173177
)

0 commit comments

Comments
 (0)