Skip to content

Commit fe661e4

Browse files
Merge pull request #1472 from devtron-labs/app_details_pod_fix
fix: app detail pods fix
2 parents c24a48f + 0266587 commit fe661e4

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

src/components/v2/appDetails/k8Resource/nodeType/Node.component.tsx

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,11 @@ function NodeComponent({ handleFocusTabs, externalLinks, monitoringTools, isDevt
124124
let podsType = []
125125
if (isPodAvailable) {
126126
podsType = _selectedNodes.filter((el) =>
127-
podMetaData?.some((f) => f.name === el.name && f.isNew === podType),
127+
podMetaData?.some((f) => {
128+
// Set f.isNew to false if it is undefined
129+
f.isNew = f.isNew || false
130+
return f.name === el.name && f.isNew === podType
131+
}),
128132
)
129133
}
130134

@@ -260,10 +264,10 @@ function NodeComponent({ handleFocusTabs, externalLinks, monitoringTools, isDevt
260264
</TippyCustomized>
261265
</>
262266
)
263-
} else if(node.port?.length === 1){
267+
} else if (node.port?.length === 1) {
264268
return `${node.name}.${node.namespace}:${node.port}`
265269
} else {
266-
return "Port Number is missing"
270+
return 'Port Number is missing'
267271
}
268272
}
269273

@@ -438,11 +442,11 @@ function NodeComponent({ handleFocusTabs, externalLinks, monitoringTools, isDevt
438442
</div>
439443
</div>
440444
{params.nodeType === NodeType.Service.toLowerCase() && node.kind !== "Endpoints" && node.kind !== "EndpointSlice" && (
441-
<div className={'col-5 pt-9 pb-9 flex left cn-9 dc__hover-icon'}>
442-
{portNumberPlaceHolder(node)}
443-
{node.port > 1 ? renderClipboardInteraction(nodeName) : null}
444-
</div>
445-
)}
445+
<div className={'col-5 pt-9 pb-9 flex left cn-9 dc__hover-icon'}>
446+
{portNumberPlaceHolder(node)}
447+
{node.port > 1 ? renderClipboardInteraction(nodeName) : null}
448+
</div>
449+
)}
446450

447451
{params.nodeType === NodeType.Pod.toLowerCase() && (
448452
<div data-testid="pod-ready-count" className={'flex left col-1 pt-9 pb-9'}>
@@ -484,10 +488,10 @@ function NodeComponent({ handleFocusTabs, externalLinks, monitoringTools, isDevt
484488
</div>
485489
)}
486490
{node?.kind !== NodeType.Containers && node?.kind !== "Endpoints" && node?.kind !== "EndpointSlice" && (
487-
<div className="flex col-1 pt-9 pb-9 flex-row-reverse">
488-
<NodeDeleteComponent nodeDetails={node} appDetails={appDetails} />
489-
</div>
490-
)}
491+
<div className="flex col-1 pt-9 pb-9 flex-row-reverse">
492+
<NodeDeleteComponent nodeDetails={node} appDetails={appDetails} />
493+
</div>
494+
)}
491495
</div>
492496

493497
{node.childNodes?.length > 0 && _isSelected && (

0 commit comments

Comments
 (0)