Skip to content

Commit 168dd93

Browse files
committed
added a check in TerminateDanglingWorkflow for argo wf exec
1 parent 6080ec9 commit 168dd93

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

pkg/pipeline/executors/ArgoWorkflowExecutor.go

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,17 @@ func (impl *ArgoWorkflowExecutorImpl) TerminateDanglingWorkflow(workflowGenerate
109109
break
110110
}
111111
}
112-
_, err = wfClient.Get(context.Background(), wfToDelete.Name, v1.GetOptions{})
113-
if err != nil {
114-
impl.logger.Errorw("cannot find workflow", "name", wfToDelete.Name, "err", err)
115-
return errors.New("cannot find workflow " + wfToDelete.Name)
116-
}
117-
err = util.TerminateWorkflow(context.Background(), wfClient, wfToDelete.Name)
118-
if err != nil {
119-
impl.logger.Errorw("error in terminating argo executor workflow", "name", wfToDelete.Name, "err", err)
120-
return err
112+
if len(wfToDelete.Name) > 0 {
113+
_, err = wfClient.Get(context.Background(), wfToDelete.Name, v1.GetOptions{})
114+
if err != nil {
115+
impl.logger.Errorw("cannot find workflow", "name", wfToDelete.Name, "err", err)
116+
return errors.New("cannot find workflow " + wfToDelete.Name)
117+
}
118+
err = util.TerminateWorkflow(context.Background(), wfClient, wfToDelete.Name)
119+
if err != nil {
120+
impl.logger.Errorw("error in terminating argo executor workflow", "name", wfToDelete.Name, "err", err)
121+
return err
122+
}
121123
}
122124
return nil
123125
}

0 commit comments

Comments
 (0)