Merge pull request #6436 from devtron-labs/dev-notif

prkhrkat · web-flow · commit 2be0bd46968f · 2025-03-10T10:59:16.000+05:30
fix: envId check in EventBuilder.go
diff --git a/client/events/EventBuilder.go b/client/events/EventBuilder.go
@@ -82,7 +82,7 @@ func (impl *EventSimpleFactoryImpl) Build(eventType util.EventType, sourceId *in
 		event.PipelineId = *sourceId
 	}
 	event.AppId = appId
-	if envId != nil {
+	if envId != nil && *envId > 0 {
 		env, err := impl.envRepository.FindById(*envId)
 		if err != nil {
 			impl.logger.Errorw("error in getting env", "envId", *envId, "err", err)

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ func (impl EventSimpleFactoryImpl) Build(eventType util.EventType, sourceId in`
`82`	`82`	`event.PipelineId = *sourceId`
`83`	`83`	`}`
`84`	`84`	`event.AppId = appId`
`85`		`- if envId != nil {`
	`85`	`+ if envId != nil && *envId > 0 {`
`86`	`86`	`env, err := impl.envRepository.FindById(*envId)`
`87`	`87`	`if err != nil {`
`88`	`88`	`impl.logger.Errorw("error in getting env", "envId", *envId, "err", err)`