name suggestion util

Author: kartik-579

api/restHandler/app/pipeline/configure/PipelineConfigRestHandler.go

@@ -35,6 +35,7 @@ import (
 	security2 "github.com/devtron-labs/devtron/pkg/policyGovernance/security/imageScanning"
 	"github.com/devtron-labs/devtron/pkg/policyGovernance/security/imageScanning/read"
 	read3 "github.com/devtron-labs/devtron/pkg/team/read"
+	"github.com/devtron-labs/devtron/util/beHelper"
 	"io"
 	"net/http"
 	"strconv"
@@ -60,7 +61,6 @@ import (
 	"github.com/devtron-labs/devtron/pkg/bean"
 	"github.com/devtron-labs/devtron/pkg/pipeline"
 	"github.com/devtron-labs/devtron/pkg/team"
-	util2 "github.com/devtron-labs/devtron/util"
 	"github.com/devtron-labs/devtron/util/rbac"
 	"github.com/gorilla/mux"
 	"go.uber.org/zap"
@@ -663,7 +663,7 @@ func (handler *PipelineConfigRestHandlerImpl) PipelineNameSuggestion(w http.Resp
 		common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
 		return
 	}
-	suggestedName := fmt.Sprintf("%s-%d-%s", pType, appId, util2.Generate(4))
+	suggestedName := beHelper.GetPipelineNameByPipelineType(pType, appId)
 	resourceName := handler.enforcerUtil.GetAppRBACName(app.AppName)
 	ok := handler.enforcerUtil.CheckAppRbacForAppOrJob(token, resourceName, casbin.ActionGet)
 	if !ok {

pkg/pipeline/CiCdPipelineOrchestrator.go

@@ -40,6 +40,7 @@ import (
 	constants3 "github.com/devtron-labs/devtron/pkg/pipeline/constants"
 	util4 "github.com/devtron-labs/devtron/pkg/pipeline/util"
 	"github.com/devtron-labs/devtron/pkg/plugin"
+	"github.com/devtron-labs/devtron/util/beHelper"
 	"github.com/devtron-labs/devtron/util/sliceUtil"
 	"golang.org/x/exp/slices"
 	"net/http"
@@ -2276,7 +2277,7 @@ func (impl CiCdPipelineOrchestratorImpl) AddPipelineToTemplate(createRequest *be
 	if createRequest.AppWorkflowId == 0 {
 		// create workflow
 		wf := &appWorkflow.AppWorkflow{
-			Name:   fmt.Sprintf("wf-%d-%s", createRequest.AppId, util2.Generate(4)),
+			Name:   beHelper.GetAppWorkflowName(createRequest.AppId),
 			AppId:  createRequest.AppId,
 			Active: true,
 			AuditLog: sql.AuditLog{

pkg/pipeline/DeploymentPipelineConfigService.go

@@ -78,6 +78,7 @@ import (
 	"github.com/devtron-labs/devtron/pkg/variables"
 	repository3 "github.com/devtron-labs/devtron/pkg/variables/repository"
 	globalUtil "github.com/devtron-labs/devtron/util"
+	"github.com/devtron-labs/devtron/util/beHelper"
 	"github.com/devtron-labs/devtron/util/rbac"
 	"github.com/go-pg/pg"
 	errors2 "github.com/juju/errors"
@@ -2024,7 +2025,7 @@ func (impl *CdPipelineConfigServiceImpl) createCdPipeline(ctx context.Context, a
 	if (pipeline.AppWorkflowId == 0 || pipeline.IsSwitchCiPipelineRequest()) && pipeline.ParentPipelineType == "WEBHOOK" {
 		if pipeline.AppWorkflowId == 0 {
 			wf := &appWorkflow.AppWorkflow{
-				Name:     fmt.Sprintf("wf-%d-%s", app.Id, globalUtil.Generate(4)),
+				Name:     beHelper.GetAppWorkflowName(app.Id),
 				AppId:    app.Id,
 				Active:   true,
 				AuditLog: sql.AuditLog{CreatedBy: userId, CreatedOn: time.Now(), UpdatedOn: time.Now(), UpdatedBy: userId},

util/beHelper/nameSuggestionUtil.go

@@ -0,0 +1,23 @@
+package beHelper
+
+import (
+	"fmt"
+	"github.com/devtron-labs/common-lib/git-manager/util"
+	util2 "github.com/devtron-labs/devtron/util"
+)
+
+func GetCIPipelineName(appId int) string {
+	return fmt.Sprintf("ci-%d-%s", appId, util2.Generate(4))
+}
+
+func GetCDPipelineName(appId int) string {
+	return fmt.Sprintf("cd-%d-%s", appId, util2.Generate(4))
+}
+
+func GetAppWorkflowName(appId int) string {
+	return fmt.Sprintf("wf-%d-%s", appId, util2.Generate(4))
+}
+
+func GetPipelineNameByPipelineType(pipelineType string, appId int) string {
+	return fmt.Sprintf("%s-%d-%s", pipelineType, appId, util.Generate(4))
+}