Skip to content

Commit 403a305

Browse files
authored
misc: cm/ cs not working in cd pipeline stage (#6324)
* fix: cm/ cs not working in cd pipeline stage * chore: removed unused wire dep
1 parent ce3f516 commit 403a305

File tree

2 files changed

+95
-79
lines changed

2 files changed

+95
-79
lines changed

pkg/pipeline/WorkflowService.go

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import (
2828
"github.com/devtron-labs/common-lib/utils/k8s/commonBean"
2929
"github.com/devtron-labs/devtron/api/bean"
3030
"github.com/devtron-labs/devtron/internal/sql/repository/pipelineConfig/bean/workflow/cdWorkflow"
31-
"github.com/devtron-labs/devtron/pkg/app"
3231
bean2 "github.com/devtron-labs/devtron/pkg/build/pipeline/bean"
3332
repository2 "github.com/devtron-labs/devtron/pkg/cluster/environment/repository"
3433
"github.com/devtron-labs/devtron/pkg/config/read"
@@ -66,7 +65,6 @@ type WorkflowServiceImpl struct {
6665
config *rest.Config
6766
ciCdConfig *types.CiCdConfig
6867
configMapService read.ConfigReadService
69-
appService app.AppService
7068
envRepository repository2.EnvironmentRepository
7169
globalCMCSService GlobalCMCSService
7270
argoWorkflowExecutor executors.ArgoWorkflowExecutor
@@ -78,15 +76,20 @@ type WorkflowServiceImpl struct {
7876

7977
// TODO: Move to bean
8078

81-
func NewWorkflowServiceImpl(Logger *zap.SugaredLogger, envRepository repository2.EnvironmentRepository, ciCdConfig *types.CiCdConfig,
82-
appService app.AppService, globalCMCSService GlobalCMCSService, argoWorkflowExecutor executors.ArgoWorkflowExecutor,
79+
func NewWorkflowServiceImpl(Logger *zap.SugaredLogger,
80+
envRepository repository2.EnvironmentRepository,
81+
ciCdConfig *types.CiCdConfig,
82+
configMapService read.ConfigReadService,
83+
globalCMCSService GlobalCMCSService,
84+
argoWorkflowExecutor executors.ArgoWorkflowExecutor,
8385
k8sUtil *k8s.K8sServiceImpl,
84-
systemWorkflowExecutor executors.SystemWorkflowExecutor, k8sCommonService k8s2.K8sCommonService,
86+
systemWorkflowExecutor executors.SystemWorkflowExecutor,
87+
k8sCommonService k8s2.K8sCommonService,
8588
infraProvider infraProviders.InfraProvider) (*WorkflowServiceImpl, error) {
8689
commonWorkflowService := &WorkflowServiceImpl{
8790
Logger: Logger,
8891
ciCdConfig: ciCdConfig,
89-
appService: appService,
92+
configMapService: configMapService,
9093
envRepository: envRepository,
9194
globalCMCSService: globalCMCSService,
9295
argoWorkflowExecutor: argoWorkflowExecutor,
@@ -277,6 +280,19 @@ func (impl *WorkflowServiceImpl) addExistingCmCsInWorkflowForCDStage(workflowReq
277280
return nil, nil, err
278281
}
279282
impl.Logger.Debugw("existing cm", "cm", existingConfigMap, "secrets", existingSecrets)
283+
if existingConfigMap != nil {
284+
for i := range existingConfigMap.Maps {
285+
workflowConfigMaps = append(workflowConfigMaps, existingConfigMap.Maps[i])
286+
}
287+
}
288+
if existingSecrets != nil {
289+
for i := range existingSecrets.Secrets {
290+
if existingSecrets.Secrets[i] == nil {
291+
continue
292+
}
293+
workflowSecrets = append(workflowSecrets, *existingSecrets.Secrets[i])
294+
}
295+
}
280296
return workflowConfigMaps, workflowSecrets, nil
281297
}
282298

0 commit comments

Comments
 (0)