Skip to content

Commit 457febe

Browse files
committed
mask secret in case of view only when request is for only one secret
1 parent e3ae3a0 commit 457febe

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

pkg/configDiff/DeploymentConfigurationService.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -581,9 +581,16 @@ func (impl *DeploymentConfigurationServiceImpl) getCmCsEditDataForPublishedOnly(
581581
}
582582
cmcsConfigData, err := fetchConfigFunc(configDataQueryParams.ResourceName, configDataQueryParams.ResourceId, envId, appId)
583583
if err != nil {
584-
impl.logger.Errorw("getCmCsEditDataForPublishedOnly, error in getting config response", "resourceName", configDataQueryParams.ResourceName, "envName", configDataQueryParams.EnvName, "err", err)
584+
impl.logger.Errorw("error in getting config response", "resourceName", configDataQueryParams.ResourceName, "envName", configDataQueryParams.EnvName, "err", err)
585585
return nil, err
586586
}
587+
if configDataQueryParams.IsResourceTypeSecret() && !userHasAdminAccess {
588+
_, err := utils.GetKeyValMapForSecretConfigDataAndMaskData(cmcsConfigData.ConfigData)
589+
if err != nil {
590+
impl.logger.Errorw("error in getting config response", "resourceName", configDataQueryParams.ResourceName, "envName", configDataQueryParams.EnvName, "err", err)
591+
return nil, err
592+
}
593+
}
587594

588595
respJson, err := utils.ConvertToJsonRawMessage(cmcsConfigData)
589596
if err != nil {

0 commit comments

Comments
 (0)