Skip to content

Commit 583b1ca

Browse files
committed
Merge branch 'main' into bypass-ns-check
# Conflicts: # env_gen.md
2 parents 822fa30 + 649f6c3 commit 583b1ca

File tree

14 files changed

+2344
-77
lines changed

14 files changed

+2344
-77
lines changed

api/helm-app/gRPC/applicationClient.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ func NewHelmAppClientImpl(logger *zap.SugaredLogger,
7272
}
7373
}
7474

75+
// CATEGORY=INFRA_SETUP
7576
type HelmClientConfig struct {
7677
Url string `env:"HELM_CLIENT_URL" envDefault:"127.0.0.1:50051"`
7778
}

api/helm-app/service/HelmAppService.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ func NewHelmAppServiceImpl(Logger *zap.SugaredLogger, clusterService cluster.Clu
146146
}
147147
}
148148

149+
// CATEGORY=CD
149150
type HelmReleaseConfig struct {
150151
RevisionHistoryLimitDevtronApp int `env:"REVISION_HISTORY_LIMIT_DEVTRON_APP" envDefault:"1"`
151152
RevisionHistoryLimitHelmApp int `env:"REVISION_HISTORY_LIMIT_HELM_APP" envDefault:"1"`

api/restHandler/app/appList/AppListingRestHandler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ func (handler AppListingRestHandlerImpl) FetchAppDetailsV2(w http.ResponseWriter
493493
return
494494
}
495495

496-
err = handler.updateApprovalConfigDataInAppDetailResp(appDetail, appId, envId)
496+
appDetail, err = handler.updateApprovalConfigDataInAppDetailResp(appDetail, appId, envId)
497497
if err != nil {
498498
common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
499499
return

api/restHandler/app/appList/AppListingRestHandler_ent.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ func (handler AppListingRestHandlerImpl) FetchAutocompleteJobCiPipelines(w http.
1414
func (handler AppListingRestHandlerImpl) GetAllAppEnvsFromResourceNames(w http.ResponseWriter, r *http.Request) {
1515
}
1616

17-
func (handler AppListingRestHandlerImpl) updateApprovalConfigDataInAppDetailResp(appDetail AppView.AppDetailContainer, appId, envId int) error {
18-
return nil
17+
func (handler AppListingRestHandlerImpl) updateApprovalConfigDataInAppDetailResp(appDetail AppView.AppDetailContainer, appId, envId int) (AppView.AppDetailContainer, error) {
18+
return AppView.AppDetailContainer{}, nil
1919
}

client/dashboard/Config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"github.com/caarlos0/env"
2121
)
2222

23+
// CATEGORY=INFRA_SETUP
2324
type Config struct {
2425
Host string `env:"DASHBOARD_HOST" envDefault:"localhost"`
2526
Port string `env:"DASHBOARD_PORT" envDefault:"3000"`

client/gitSensor/GitSensorClient.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ func NewGitSensorClient(logger *zap.SugaredLogger, config *ClientConfig) (*Clien
7979
return client, nil
8080
}
8181

82+
// CATEGORY=INFRA_SETUP
8283
type ClientConfig struct {
8384
Url string `env:"GIT_SENSOR_URL" envDefault:"127.0.0.1:7070"`
8485
Protocol string `env:"GIT_SENSOR_PROTOCOL" envDefault:"REST"`

0 commit comments

Comments
 (0)