Skip to content

Commit 61c8b9a

Browse files
added logs for deployment trigger (#6180)
1 parent c3039db commit 61c8b9a

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

pkg/deployment/trigger/devtronApps/TriggerService.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -829,8 +829,10 @@ func (impl *TriggerServiceImpl) TriggerRelease(overrideRequest *bean3.ValuesOver
829829
if err != nil {
830830
return releaseNo, err
831831
}
832+
impl.logger.Debugw("processing TriggerRelease", "wfrId", overrideRequest.WfrId, "triggerEvent", triggerEvent)
832833
// request has already been served, skipping
833834
if skipRequest {
835+
impl.logger.Infow("request already served, skipping", "wfrId", overrideRequest.WfrId)
834836
return releaseNo, nil
835837
}
836838
// build merged values and save PCO history for the release
@@ -856,6 +858,7 @@ func (impl *TriggerServiceImpl) TriggerRelease(overrideRequest *bean3.ValuesOver
856858
impl.logger.Errorw("error in building merged manifest for trigger", "err", err)
857859
return releaseNo, err
858860
}
861+
impl.logger.Debugw("triggering pipeline for release", "wfrId", overrideRequest.WfrId, "builtChartPath", builtChartPath)
859862
releaseNo, err = impl.triggerPipeline(overrideRequest, valuesOverrideResponse, builtChartPath, triggerEvent, newCtx)
860863
if err != nil {
861864
return 0, err
@@ -866,6 +869,7 @@ func (impl *TriggerServiceImpl) TriggerRelease(overrideRequest *bean3.ValuesOver
866869
if dbErr != nil {
867870
impl.logger.Errorw("error in creating timeline status for deployment completed", "err", dbErr, "timeline", timeline)
868871
}
872+
impl.logger.Debugw("triggered pipeline for release successfully", "wfrId", overrideRequest.WfrId, "builtChartPath", builtChartPath)
869873
return releaseNo, nil
870874
}
871875

@@ -937,11 +941,13 @@ func (impl *TriggerServiceImpl) triggerPipeline(overrideRequest *bean3.ValuesOve
937941
newCtx, span := otel.Tracer("orchestrator").Start(ctx, "TriggerServiceImpl.triggerPipeline")
938942
defer span.End()
939943
if triggerEvent.PerformChartPush {
944+
impl.logger.Debugw("performing chart push operation in triggerPipeline", "cdWfrId", overrideRequest.WfrId)
940945
err = impl.performGitOps(newCtx, overrideRequest, valuesOverrideResponse, builtChartPath, triggerEvent)
941946
if err != nil {
942947
impl.logger.Errorw("error in performing GitOps", "cdWfrId", overrideRequest.WfrId, "err", err)
943948
return releaseNo, err
944949
}
950+
impl.logger.Debugw("chart push operation completed successfully", "cdWfrId", overrideRequest.WfrId)
945951
}
946952
if triggerEvent.PerformDeploymentOnCluster {
947953
err = impl.deployApp(newCtx, overrideRequest, valuesOverrideResponse, triggerEvent)

pkg/eventProcessor/in/WorkflowEventProcessorService.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -773,6 +773,7 @@ func (impl *WorkflowEventProcessorImpl) extractAsyncCdDeployRequestFromEventMsg(
773773
impl.logger.Errorw("error in unmarshalling CD async install request nats message", "err", err)
774774
return nil, err
775775
}
776+
impl.logger.Infow("received async cd pipeline deployment request", "appId", cdAsyncInstallReq.ValuesOverrideRequest.AppId, "envId", cdAsyncInstallReq.ValuesOverrideRequest.EnvId)
776777
if cdAsyncInstallReq.Id == 0 && cdAsyncInstallReq.ValuesOverrideRequest == nil {
777778
impl.logger.Errorw("invalid async cd pipeline deployment request", "msg", msg.Data)
778779
return nil, fmt.Errorf("invalid async cd pipeline deployment request")
@@ -936,6 +937,7 @@ func (impl *WorkflowEventProcessorImpl) ProcessConcurrentAsyncDeploymentReq(ctx
936937
impl.logger.Errorw("err on fetching cd workflow runner by id", "err", err, "cdWfrId", cdWfrId)
937938
return err
938939
}
940+
impl.logger.Debugw("currently in ProcessConcurrentAsyncDeploymentReq", "pipelineId", pipelineId, "cdWfrId", cdWfrId)
939941
acdCtx, err := impl.argoUserService.GetACDContext(newCtx)
940942
if err != nil {
941943
impl.logger.Errorw("error in creating ArgoCd context", "err", err)

pkg/workflow/dag/WorkflowDagExecutor.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,7 @@ func (impl *WorkflowDagExecutorImpl) ProcessDevtronAsyncInstallRequest(cdAsyncIn
389389
return err
390390
}
391391
if util.IsHelmApp(overrideRequest.DeploymentAppType) {
392+
impl.logger.Debugw("processing async install request for helm app", "cdWfrId", cdWfr.Id)
392393
// update workflow runner status, used in app workflow view
393394
err = impl.cdWorkflowCommonService.UpdateNonTerminalStatusInRunner(newCtx, overrideRequest.WfrId, overrideRequest.UserId, cdWorkflow2.WorkflowStarting)
394395
if err != nil {
@@ -403,6 +404,7 @@ func (impl *WorkflowDagExecutorImpl) ProcessDevtronAsyncInstallRequest(cdAsyncIn
403404
}
404405
releaseId, releaseErr := impl.cdTriggerService.TriggerRelease(overrideRequest, envDeploymentConfig, newCtx, cdAsyncInstallReq.TriggeredAt, cdAsyncInstallReq.TriggeredBy)
405406
if releaseErr != nil {
407+
impl.logger.Errorw("error encountered in ProcessDevtronAsyncInstallRequest", "err", releaseErr, "cdWfrId", cdWfr.Id)
406408
impl.handleAsyncTriggerReleaseError(newCtx, releaseErr, cdWfr, overrideRequest)
407409
return releaseErr
408410
} else {

0 commit comments

Comments
 (0)