createDockerRepoIfNeeded error handling

prkhrkat · prkhrkat · commit 698950f29318 · 2025-03-05T18:44:57.000+05:30
diff --git a/pkg/pipeline/CiCdPipelineOrchestrator.go b/pkg/pipeline/CiCdPipelineOrchestrator.go
@@ -1111,7 +1111,7 @@ func (impl CiCdPipelineOrchestratorImpl) CreateCiConf(createRequest *bean.CiConf
 			}
 			if !ciPipeline.IsExternal { //pipeline is not [linked, webhook] and overridden, then create template override
 				err = impl.createDockerRepoIfNeeded(ciPipeline.DockerConfigOverride.DockerRegistry, ciPipeline.DockerConfigOverride.DockerRepository)
-				// silently ignore the error, since we don't want to fail the pipeline creation
+				// silently ignoring the error, since we don't want to fail the pipeline creation
 				if err != nil {
 					impl.logger.Errorw("error, createDockerRepoIfNeeded", "err", err, "dockerRegistryId", ciPipeline.DockerConfigOverride.DockerRegistry, "dockerRegistry", ciPipeline.DockerConfigOverride.DockerRepository)
 				}

Original file line number	Diff line number	Diff line change
`@@ -1111,7 +1111,7 @@ func (impl CiCdPipelineOrchestratorImpl) CreateCiConf(createRequest *bean.CiConf`
`1111`	`1111`	`}`
`1112`	`1112`	`if !ciPipeline.IsExternal { //pipeline is not [linked, webhook] and overridden, then create template override`
`1113`	`1113`	`err = impl.createDockerRepoIfNeeded(ciPipeline.DockerConfigOverride.DockerRegistry, ciPipeline.DockerConfigOverride.DockerRepository)`
`1114`		`- // silently ignore the error, since we don't want to fail the pipeline creation`
	`1114`	`+ // silently ignoring the error, since we don't want to fail the pipeline creation`
`1115`	`1115`	`if err != nil {`
`1116`	`1116`	`impl.logger.Errorw("error, createDockerRepoIfNeeded", "err", err, "dockerRegistryId", ciPipeline.DockerConfigOverride.DockerRegistry, "dockerRegistry", ciPipeline.DockerConfigOverride.DockerRepository)`
`1117`	`1117`	`}`