Fix: summary events (#1487)

* Summary events[1436]

* Summary events[1436]

* temporary changes[1436]

* temporary changes[1436]

* adding logs[1436]

* adding logs[1436]

* adding logs[1436]

* adding logs[1436]

* removing logs, refactoring[1436]

* removing logs, refactoring[1436]

* removing logs, refactoring[1436]

* removing logs, refactoring[1436]

* removing logs, refactoring[1436]

* updating installation-script [1436]

Author: snehith57624

Wire.go

@@ -597,8 +597,8 @@ func InitializeApp() (*App, error) {
 		wire.Bind(new(restHandler.TelemetryRestHandler), new(*restHandler.TelemetryRestHandlerImpl)),
 		telemetry.NewPosthogClient,
 
-		telemetry.NewTelemetryEventClientImpl,
-		wire.Bind(new(telemetry.TelemetryEventClient), new(*telemetry.TelemetryEventClientImpl)),
+		telemetry.NewTelemetryEventClientImplExtended,
+		wire.Bind(new(telemetry.TelemetryEventClient), new(*telemetry.TelemetryEventClientImplExtended)),
 
 		router.NewBulkUpdateRouterImpl,
 		wire.Bind(new(router.BulkUpdateRouter), new(*router.BulkUpdateRouterImpl)),

client/telemetry/TelemetryEventClient.go

@@ -57,7 +57,7 @@ func NewTelemetryEventClientImpl(logger *zap.SugaredLogger, client *http.Client,
 	}
 
 	watcher.HeartbeatEventForTelemetry()
-	_, err := cron.AddFunc(SummaryCronExpr, watcher.SummaryEventForTelemetry)
+	_, err := cron.AddFunc(SummaryCronExpr, watcher.SummaryEventForTelemetryEA)
 	if err != nil {
 		logger.Errorw("error in starting summery event", "err", err)
 		return nil, err
@@ -142,7 +142,7 @@ func (impl *TelemetryEventClientImpl) SummaryDetailsForTelemetry() (cluster []cl
 	return clusters, users, k8sServerVersion
 }
 
-func (impl *TelemetryEventClientImpl) SummaryEventForTelemetry() {
+func (impl *TelemetryEventClientImpl) SummaryEventForTelemetryEA() {
 	ucid, err := impl.getUCID()
 	if err != nil {
 		impl.logger.Errorw("exception caught inside telemetry summary event", "err", err)
@@ -222,6 +222,7 @@ func (impl *TelemetryEventClientImpl) HeartbeatEventForTelemetry() {
 		impl.logger.Errorw("exception caught inside telemetry heartbeat event", "err", err)
 		return
 	}
+
 	k8sServerVersion, err := discoveryClient.ServerVersion()
 	if err != nil {
 		impl.logger.Errorw("exception caught inside telemetry heartbeat event", "err", err)
@@ -244,13 +245,12 @@ func (impl *TelemetryEventClientImpl) HeartbeatEventForTelemetry() {
 	}
 
 	err = impl.EnqueuePostHog(ucid, Heartbeat, prop)
-	if err == nil {
-		if err != nil {
-			impl.logger.Warnw("HeartbeatEventForTelemetry, failed to push event", "error", err)
-		} else {
-			impl.logger.Debugw("HeartbeatEventForTelemetry success")
-		}
+	if err != nil {
+		impl.logger.Warnw("HeartbeatEventForTelemetry, failed to push event", "error", err)
+		return
 	}
+	impl.logger.Debugw("HeartbeatEventForTelemetry success")
+	return
 }
 
 func (impl *TelemetryEventClientImpl) GetTelemetryMetaInfo() (*TelemetryMetaInfo, error) {

client/telemetry/TelemetryEventClientExtended.go

@@ -24,7 +24,7 @@ type TelemetryEventClientImplExtended struct {
 	*TelemetryEventClientImpl
 }
 
-func (impl *TelemetryEventClientImplExtended) NewTelemetryEventClientImplExtended(logger *zap.SugaredLogger, client *http.Client, clusterService cluster.ClusterService,
+func NewTelemetryEventClientImplExtended(logger *zap.SugaredLogger, client *http.Client, clusterService cluster.ClusterService,
 	K8sUtil *util2.K8sUtil, aCDAuthConfig *util3.ACDAuthConfig,
 	environmentService cluster.EnvironmentService, userService user.UserService,
 	appListingRepository repository.AppListingRepository, PosthogClient *PosthogClient,
@@ -101,7 +101,6 @@ func (impl *TelemetryEventClientImplExtended) SummaryEventForTelemetry() {
 	}
 
 	clusters, users, k8sServerVersion := impl.SummaryDetailsForTelemetry()
-
 	payload := &TelemetryEventDto{UCID: ucid, Timestamp: time.Now(), EventType: Summary, DevtronVersion: "v1"}
 	payload.ServerVersion = k8sServerVersion.String()