Skip to content

Commit 881dbc7

Browse files
committed
review comments resolved
1 parent 664883c commit 881dbc7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/cluster/environment/EnvironmentService.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,10 @@ func NewEnvironmentServiceImpl(environmentRepository repository.EnvironmentRepos
109109
func (impl EnvironmentServiceImpl) GetDataSourceName(bean *bean2.EnvironmentBean) (*bean2.DataSourceMetaData, error) {
110110
datasource := &bean2.DataSourceMetaData{}
111111
if bean.DataSourceId == 0 || bean.PrometheusEndpoint == "" {
112-
return datasource, fmt.Errorf("prometheus endpoint not found")
112+
impl.logger.Debugw("grafana data source not configured for given", "dataSourceId", bean.DataSourceId)
113+
return datasource, nil
113114
} else {
114-
impl.logger.Debugw("environment datasource name", "datasource", bean.DataSourceId)
115+
impl.logger.Debugw("environment datasource", "datasource", bean.DataSourceId)
115116
data, err := impl.grafanaClient.GetDatasource(bean.DataSourceId)
116117
if err != nil {
117118
impl.logger.Errorw("error in fetching datasource", "err", err)

0 commit comments

Comments
 (0)