cdworflow read service (#6172)

Author: ayu-devtron

pkg/eventProcessor/in/WorkflowEventProcessorService.go

@@ -49,6 +49,7 @@ import (
 	"github.com/devtron-labs/devtron/pkg/workflow/cd"
 	"github.com/devtron-labs/devtron/pkg/workflow/cd/adapter"
 	cdWorkflowBean "github.com/devtron-labs/devtron/pkg/workflow/cd/bean"
+	"github.com/devtron-labs/devtron/pkg/workflow/cd/read"
 	"github.com/devtron-labs/devtron/pkg/workflow/dag"
 	wrokflowDagBean "github.com/devtron-labs/devtron/pkg/workflow/dag/bean"
 	globalUtil "github.com/devtron-labs/devtron/util"
@@ -70,6 +71,7 @@ type WorkflowEventProcessorImpl struct {
 	logger                       *zap.SugaredLogger
 	pubSubClient                 *pubsub.PubSubClientServiceImpl
 	cdWorkflowService            cd.CdWorkflowService
+	cdWorkflowReadService        read.CdWorkflowReadService
 	cdWorkflowRunnerService      cd.CdWorkflowRunnerService
 	workflowDagExecutor          dag.WorkflowDagExecutor
 	argoUserService              argo.ArgoUserService
@@ -100,6 +102,7 @@ type WorkflowEventProcessorImpl struct {
 func NewWorkflowEventProcessorImpl(logger *zap.SugaredLogger,
 	pubSubClient *pubsub.PubSubClientServiceImpl,
 	cdWorkflowService cd.CdWorkflowService,
+	cdWorkflowReadService read.CdWorkflowReadService,
 	cdWorkflowRunnerService cd.CdWorkflowRunnerService,
 	workflowDagExecutor dag.WorkflowDagExecutor,
 	argoUserService argo.ArgoUserService,
@@ -121,6 +124,7 @@ func NewWorkflowEventProcessorImpl(logger *zap.SugaredLogger,
 		logger:                          logger,
 		pubSubClient:                    pubSubClient,
 		cdWorkflowService:               cdWorkflowService,
+		cdWorkflowReadService:           cdWorkflowReadService,
 		cdWorkflowRunnerService:         cdWorkflowRunnerService,
 		argoUserService:                 argoUserService,
 		ciHandler:                       ciHandler,
@@ -244,7 +248,7 @@ func (impl *WorkflowEventProcessorImpl) SubscribeTriggerBulkAction() error {
 			PipelineId:   cdWorkflow.PipelineId,
 			UserId:       userBean.SYSTEM_USER_ID,
 		}
-		latest, err := impl.cdWorkflowService.CheckIfLatestWf(cdWorkflow.PipelineId, cdWorkflow.Id)
+		latest, err := impl.cdWorkflowReadService.CheckIfLatestWf(cdWorkflow.PipelineId, cdWorkflow.Id)
 		if err != nil {
 			impl.logger.Errorw("error in determining latest", "wf", cdWorkflow, "err", err)
 			wf.WorkflowStatus = cdWorkflowModelBean.DEQUE_ERROR

pkg/workflow/cd/CdWorkflowService.go

@@ -24,7 +24,6 @@ import (
 )
 
 type CdWorkflowService interface {
-	CheckIfLatestWf(pipelineId, cdWfId int) (latest bool, err error)
 	UpdateWorkFlow(dto *bean.CdWorkflowDto) error
 }
 
@@ -41,15 +40,6 @@ func NewCdWorkflowServiceImpl(logger *zap.SugaredLogger,
 	}
 }
 
-func (impl *CdWorkflowServiceImpl) CheckIfLatestWf(pipelineId, cdWfId int) (latest bool, err error) {
-	latest, err = impl.cdWorkflowRepository.IsLatestWf(pipelineId, cdWfId)
-	if err != nil {
-		impl.logger.Errorw("error in checking if wf is latest", "pipelineId", pipelineId, "cdWfId", cdWfId, "err", err)
-		return false, err
-	}
-	return latest, nil
-}
-
 func (impl *CdWorkflowServiceImpl) UpdateWorkFlow(dto *bean.CdWorkflowDto) error {
 	dbObj := adapter.ConvertCdWorkflowDtoToDbObj(dto)
 	err := impl.cdWorkflowRepository.UpdateWorkFlow(dbObj)

pkg/workflow/cd/read/CdWorkflowReadService.go

@@ -0,0 +1,32 @@
+package read
+
+import (
+	"github.com/devtron-labs/devtron/internal/sql/repository/pipelineConfig"
+	"go.uber.org/zap"
+)
+
+type CdWorkflowReadService interface {
+	CheckIfLatestWf(pipelineId, cdWfId int) (latest bool, err error)
+}
+
+type CdWorkflowReadServiceImpl struct {
+	logger               *zap.SugaredLogger
+	cdWorkflowRepository pipelineConfig.CdWorkflowRepository
+}
+
+func NewCdWorkflowReadServiceImpl(logger *zap.SugaredLogger,
+	cdWorkflowRepository pipelineConfig.CdWorkflowRepository) *CdWorkflowReadServiceImpl {
+	return &CdWorkflowReadServiceImpl{
+		logger:               logger,
+		cdWorkflowRepository: cdWorkflowRepository,
+	}
+}
+
+func (impl *CdWorkflowReadServiceImpl) CheckIfLatestWf(pipelineId, cdWfId int) (latest bool, err error) {
+	latest, err = impl.cdWorkflowRepository.IsLatestWf(pipelineId, cdWfId)
+	if err != nil {
+		impl.logger.Errorw("error in checking if wf is latest", "pipelineId", pipelineId, "cdWfId", cdWfId, "err", err)
+		return false, err
+	}
+	return latest, nil
+}

pkg/workflow/cd/wire_workflowCd.go

@@ -16,13 +16,18 @@
 
 package cd
 
-import "github.com/google/wire"
+import (
+	"github.com/devtron-labs/devtron/pkg/workflow/cd/read"
+	"github.com/google/wire"
+)
 
 var CdWorkflowWireSet = wire.NewSet(
 	NewCdWorkflowCommonServiceImpl,
 	wire.Bind(new(CdWorkflowCommonService), new(*CdWorkflowCommonServiceImpl)),
 	NewCdWorkflowServiceImpl,
 	wire.Bind(new(CdWorkflowService), new(*CdWorkflowServiceImpl)),
+	read.NewCdWorkflowReadServiceImpl,
+	wire.Bind(new(read.CdWorkflowReadService), new(*read.CdWorkflowReadServiceImpl)),
 	NewCdWorkflowRunnerServiceImpl,
 	wire.Bind(new(CdWorkflowRunnerService), new(*CdWorkflowRunnerServiceImpl)),
 )