Skip to content

Commit 9cf81fe

Browse files
committed
fix
1 parent 3bad55c commit 9cf81fe

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

pkg/pipeline/PipelineStageService.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -680,16 +680,15 @@ func (impl *PipelineStageServiceImpl) CreateStageSteps(steps []*bean.PipelineSta
680680
impl.logger.Errorw("error in creating script and mapping for inline step", "err", err, "inlineStepDetail", inlineStepDetail)
681681
return err
682682
}
683-
// TODO: silenly filtering reserved paths, not throwing error as of now since this flow is not in tx
684-
step.OutputDirectoryPath = helper.FilterReservedPathFromOutputDirPath(step.OutputDirectoryPath)
683+
685684
inlineStep := &repository.PipelineStageStep{
686685
PipelineStageId: stageId,
687686
Name: step.Name,
688687
Description: step.Description,
689688
Index: step.Index,
690689
StepType: step.StepType,
691690
ScriptId: scriptEntryId,
692-
OutputDirectoryPath: step.OutputDirectoryPath,
691+
OutputDirectoryPath: helper.FilterReservedPathFromOutputDirPath(step.OutputDirectoryPath), // TODO: silently filtering reserved paths, not throwing error as of now since this flow is not in tx
693692
DependentOnStep: dependentOnStep,
694693
Deleted: false,
695694
AuditLog: sql.AuditLog{
@@ -1208,7 +1207,7 @@ func (impl *PipelineStageServiceImpl) UpdateStageStepsWithTx(steps []*bean.Pipel
12081207
Description: step.Description,
12091208
Index: step.Index,
12101209
StepType: step.StepType,
1211-
OutputDirectoryPath: step.OutputDirectoryPath,
1210+
OutputDirectoryPath: helper.FilterReservedPathFromOutputDirPath(step.OutputDirectoryPath),
12121211
DependentOnStep: dependentOnStep,
12131212
Deleted: false,
12141213
AuditLog: sql.AuditLog{
@@ -1247,7 +1246,6 @@ func (impl *PipelineStageServiceImpl) UpdateStageStepsWithTx(steps []*bean.Pipel
12471246
outputVariables = step.RefPluginStepDetail.OutputVariables
12481247
conditionDetails = step.RefPluginStepDetail.ConditionDetails
12491248
} else if step.StepType == repository.PIPELINE_STEP_TYPE_INLINE {
1250-
step.OutputDirectoryPath = helper.FilterReservedPathFromOutputDirPath(step.OutputDirectoryPath)
12511249
if savedStep.StepType == repository.PIPELINE_STEP_TYPE_REF_PLUGIN {
12521250
//step changed from ref plugin to inline, create script and mapping
12531251
scriptEntryId, err := impl.CreateScriptAndMappingForInlineStep(step.InlineStepDetail, userId, tx)

0 commit comments

Comments
 (0)