@@ -680,16 +680,15 @@ func (impl *PipelineStageServiceImpl) CreateStageSteps(steps []*bean.PipelineSta
680
680
impl .logger .Errorw ("error in creating script and mapping for inline step" , "err" , err , "inlineStepDetail" , inlineStepDetail )
681
681
return err
682
682
}
683
- // TODO: silenly filtering reserved paths, not throwing error as of now since this flow is not in tx
684
- step .OutputDirectoryPath = helper .FilterReservedPathFromOutputDirPath (step .OutputDirectoryPath )
683
+
685
684
inlineStep := & repository.PipelineStageStep {
686
685
PipelineStageId : stageId ,
687
686
Name : step .Name ,
688
687
Description : step .Description ,
689
688
Index : step .Index ,
690
689
StepType : step .StepType ,
691
690
ScriptId : scriptEntryId ,
692
- OutputDirectoryPath : step .OutputDirectoryPath ,
691
+ OutputDirectoryPath : helper . FilterReservedPathFromOutputDirPath ( step .OutputDirectoryPath ), // TODO: silently filtering reserved paths, not throwing error as of now since this flow is not in tx
693
692
DependentOnStep : dependentOnStep ,
694
693
Deleted : false ,
695
694
AuditLog : sql.AuditLog {
@@ -1208,7 +1207,7 @@ func (impl *PipelineStageServiceImpl) UpdateStageStepsWithTx(steps []*bean.Pipel
1208
1207
Description : step .Description ,
1209
1208
Index : step .Index ,
1210
1209
StepType : step .StepType ,
1211
- OutputDirectoryPath : step .OutputDirectoryPath ,
1210
+ OutputDirectoryPath : helper . FilterReservedPathFromOutputDirPath ( step .OutputDirectoryPath ) ,
1212
1211
DependentOnStep : dependentOnStep ,
1213
1212
Deleted : false ,
1214
1213
AuditLog : sql.AuditLog {
@@ -1247,7 +1246,6 @@ func (impl *PipelineStageServiceImpl) UpdateStageStepsWithTx(steps []*bean.Pipel
1247
1246
outputVariables = step .RefPluginStepDetail .OutputVariables
1248
1247
conditionDetails = step .RefPluginStepDetail .ConditionDetails
1249
1248
} else if step .StepType == repository .PIPELINE_STEP_TYPE_INLINE {
1250
- step .OutputDirectoryPath = helper .FilterReservedPathFromOutputDirPath (step .OutputDirectoryPath )
1251
1249
if savedStep .StepType == repository .PIPELINE_STEP_TYPE_REF_PLUGIN {
1252
1250
//step changed from ref plugin to inline, create script and mapping
1253
1251
scriptEntryId , err := impl .CreateScriptAndMappingForInlineStep (step .InlineStepDetail , userId , tx )
0 commit comments