Skip to content

Commit a30e5c7

Browse files
feat: added support for extraconfigs in app-sync and increased the job ttl to 1000 (#6021)
* added support for extraconfigs in app-sync and increased the ttl to 1000 * added USE_DEPLOYMENT_CONFIG_DATA in devtron configmap * added if conditions in apiVersion postgresql-miscellaneous job * Update Chart.yaml * Update devtron-bom.yaml * Update values.yaml --------- Co-authored-by: Pawan Mehta <[email protected]>
1 parent d5bcc52 commit a30e5c7

File tree

8 files changed

+34
-12
lines changed

8 files changed

+34
-12
lines changed

charts/devtron/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: v2
22
name: devtron-operator
3-
appVersion: 0.7.4-rc.0
3+
appVersion: 0.7.4
44
description: Chart to configure and install Devtron. Devtron is a Kubernetes Orchestration system.
55
keywords:
66
- Devtron
@@ -11,7 +11,7 @@ keywords:
1111
- argocd
1212
- Hyperion
1313
engine: gotpl
14-
version: 0.22.75
14+
version: 0.22.76
1515
sources:
1616
- https://github.com/devtron-labs/charts
1717
dependencies:

charts/devtron/devtron-bom.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ global:
1010
containerRegistry: "quay.io/devtron"
1111
extraManifests: []
1212
installer:
13-
release: "v0.7.4-rc.0"
13+
release: "v0.7.4"
1414
registry: ""
1515
image: "inception"
1616
tag: "473deaa4-185-21582"
@@ -155,6 +155,8 @@ components:
155155
chartSync:
156156
registry: ""
157157
image: chart-sync:13ffae06-150-25515
158+
schedule: "0 19 * * *"
159+
extraConfigs: {}
158160
# values for argocd integration
159161
argo-cd:
160162
global:

charts/devtron/templates/app-sync-job.yaml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,12 @@ metadata:
7070
annotations:
7171
"helm.sh/resource-policy": keep
7272
spec:
73-
schedule: "0 19 * * *"
73+
schedule: {{ $.Values.components.chartSync.schedule | quote }}
7474
jobTemplate:
7575
spec:
7676
template:
7777
spec:
78+
activeDeadlineSeconds: 15000
7879
serviceAccountName: chart-sync
7980
{{- include "common.schedulerConfig" (dict "nodeSelector" $.Values.components.chartSync.nodeSelector "tolerations" $.Values.components.chartSync.tolerations "imagePullSecrets" $.Values.components.chartSync.imagePullSecrets "global" $.Values.global) | indent 10 }}
8081
{{- if and $.Values.global $.Values.global.podSecurityContext }}
@@ -98,6 +99,8 @@ spec:
9899
envFrom:
99100
- secretRef:
100101
name: devtron-secret
102+
- configMapRef:
103+
name: app-sync-cm
101104
{{- if .Values.components.migrator }}
102105
{{- if .Values.components.migrator.appSync }}
103106
{{- if .Values.components.migrator.appSync.resources }}
@@ -108,3 +111,16 @@ spec:
108111
{{- end }}
109112
restartPolicy: Never
110113
backoffLimit: 4
114+
---
115+
apiVersion: v1
116+
kind: ConfigMap
117+
metadata:
118+
name: app-sync-cm
119+
labels:
120+
app: app-sync-cronjob
121+
release: devtron
122+
data:
123+
{{- if $.Values.components.chartSync.extraConfigs }}
124+
{{ toYaml $.Values.components.chartSync.extraConfigs | indent 2 }}
125+
{{- end }}
126+
---

charts/devtron/templates/devtron.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ data:
122122
FEATURE_RESTART_WORKLOAD_WORKER_POOL_SIZE: "5"
123123
USE_GIT_CLI: "false"
124124
PROPAGATE_EXTRA_LABELS: "false"
125+
USE_DEPLOYMENT_CONFIG_DATA: "false"
125126
{{- if $.Values.configs }}
126127
{{- if or ($.Values.minio.enabled) ($.Values.configs.BLOB_STORAGE_PROVIDER) }}
127128
BLOB_STORAGE_ENABLED: "true"

charts/devtron/templates/grafana.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ kind: Job
1212
metadata:
1313
name: grafana-org-job
1414
spec:
15-
ttlSecondsAfterFinished: 100
15+
ttlSecondsAfterFinished: 1000
1616
template:
1717
spec:
1818
{{- include "common.schedulerConfig" (dict "nodeSelector" $.Values.monitoring.grafana.nodeSelector "tolerations" $.Values.monitoring.grafana.tolerations "imagePullSecrets" $.Values.monitoring.grafana.imagePullSecrets "global" $.Values.global) | indent 6 }}

charts/devtron/templates/migrator.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,15 +373,19 @@ spec:
373373

374374
{{- end }}
375375
---
376+
{{- if $.Capabilities.APIVersions.Has "batch/v1/Job" }}
376377
apiVersion: batch/v1
378+
{{- else }}
379+
apiVersion: batch/v1beta1
380+
{{- end }}
377381
#this job is added for creating new database(clairv4).
378382
#This database is needed for clair upgrade (v2 to v4), since old database does not support migration for new clair.
379383
#Without this job, database can be created for new users, but not for existing users.
380384
kind: Job
381385
metadata:
382386
name: postgresql-miscellaneous
383387
spec:
384-
ttlSecondsAfterFinished: 100
388+
ttlSecondsAfterFinished: 1000
385389
template:
386390
spec:
387391
{{- include "common.schedulerConfig" (dict "nodeSelector" $.Values.components.migrator.nodeSelector "tolerations" $.Values.components.migrator.tolerations "imagePullSecrets" $.Values.components.migrator.imagePullSecrets "global" $.Values.global) | indent 6 }}

charts/devtron/templates/minio.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ metadata:
322322
release: {{ $.Release.Name }}
323323
heritage: Helm
324324
spec:
325-
ttlSecondsAfterFinished: 100
325+
ttlSecondsAfterFinished: 1000
326326
template:
327327
metadata:
328328
labels:

charts/devtron/values.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ global:
2424
extraManifests: []
2525
installer:
2626
repo: "devtron-labs/devtron"
27-
release: "v0.7.4-rc.0"
27+
release: "v0.7.4"
2828
registry: ""
2929
image: inception
3030
tag: 473deaa4-185-21582
@@ -223,6 +223,9 @@ components:
223223
chartSync:
224224
registry: ""
225225
image: chart-sync:13ffae06-150-25515
226+
schedule: "0 19 * * *"
227+
extraConfigs: {}
228+
226229
# values for argocd integration
227230
argo-cd:
228231
enabled: false
@@ -245,10 +248,6 @@ argo-cd:
245248
statusProcessors: "50"
246249
# -- define the application controller `--operation-processors`
247250
operationProcessors: "25"
248-
# -- define the application controller `--app-hard-resync`
249-
appHardResyncPeriod: "0"
250-
# -- define the application controller `--app-resync`
251-
appResyncPeriod: "180"
252251
# -- define the application controller `--self-heal-timeout-seconds`
253252
selfHealTimeout: "5"
254253
# -- define the application controller `--repo-server-timeout-seconds`

0 commit comments

Comments
 (0)