Skip to content

Commit a6821af

Browse files
prkhrkatprkhrkat
committed
createDownwardAPIVolume
1 parent edd184a commit a6821af

File tree

8 files changed

+62
-16
lines changed

8 files changed

+62
-16
lines changed

‎go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,8 @@ require gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
288288

289289
replace (
290290
github.com/argoproj/argo-workflows/v3 v3.5.10 => github.com/devtron-labs/argo-workflows/v3 v3.5.10
291-
github.com/devtron-labs/authenticator => github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241216110450-9f2f2d5a0281
292-
github.com/devtron-labs/common-lib => github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241216110450-9f2f2d5a0281
291+
github.com/devtron-labs/authenticator => github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241220103339-f61a1734c0f4
292+
github.com/devtron-labs/common-lib => github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241220103339-f61a1734c0f4
293293
github.com/go-check/check => github.com/go-check/check v0.0.0-20180628173108-788fd7840127
294294
github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.5.5
295295
k8s.io/api => k8s.io/api v0.29.7

‎go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -792,10 +792,10 @@ github.com/denisenkom/go-mssqldb v0.0.0-20200428022330-06a60b6afbbc h1:VRRKCwnzq
792792
github.com/denisenkom/go-mssqldb v0.0.0-20200428022330-06a60b6afbbc/go.mod h1:xbL0rPBG9cCiLr28tMa8zpbdarY27NDyej4t/EjAShU=
793793
github.com/devtron-labs/argo-workflows/v3 v3.5.10 h1:6rxQOesOzDz6SgQCMDQNHaehsKFW3C7U8CZeEek5kgQ=
794794
github.com/devtron-labs/argo-workflows/v3 v3.5.10/go.mod h1:/vqxcovDPT4zqr4DjR5v7CF8ggpY1l3TSa2CIG3jmjA=
795-
github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241216110450-9f2f2d5a0281 h1:UX4HklNLOH7nuTRJQGes3H2T3XgdA+mqoC0+ENfDPAI=
796-
github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241216110450-9f2f2d5a0281/go.mod h1:vFJ3M7akwAWCtugDXRW+5Q9P+cp0RiH+K/D5FBbb/JA=
797-
github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241216110450-9f2f2d5a0281 h1:BuvKKBLDujIOtWFYjx0XvhWW0weIFZ6mVorA05EswpY=
798-
github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241216110450-9f2f2d5a0281/go.mod h1:NJSMdv+zTUK3p7rML12RZSeAUKHeLaoY3sR/oK0xhwo=
795+
github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241220103339-f61a1734c0f4 h1:rUpKHFiDOl8LHgWqFeFTHTcEUChwwbZTKVTZl7fyN0A=
796+
github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241220103339-f61a1734c0f4/go.mod h1:vFJ3M7akwAWCtugDXRW+5Q9P+cp0RiH+K/D5FBbb/JA=
797+
github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241220103339-f61a1734c0f4 h1:c4ubgwjt6+HfCwMX7O/JyDiOMMYTg/oAS7jC0zMmjmc=
798+
github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241220103339-f61a1734c0f4/go.mod h1:NJSMdv+zTUK3p7rML12RZSeAUKHeLaoY3sR/oK0xhwo=
799799
github.com/devtron-labs/go-bitbucket v0.9.60-beta h1:VEx1jvDgdtDPS6A1uUFoaEi0l1/oLhbr+90xOwr6sDU=
800800
github.com/devtron-labs/go-bitbucket v0.9.60-beta/go.mod h1:GnuiCesvh8xyHeMCb+twm8lBR/kQzJYSKL28ZfObp1Y=
801801
github.com/devtron-labs/protos v0.0.3-0.20240802105333-92ee9bb85d80 h1:xwbTeijNTf4/j1v+tSfwVqwLVnReas/NqEKeQHvSTys=

‎pkg/pipeline/WorkflowService.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ func (impl *WorkflowServiceImpl) createWorkflowTemplate(workflowRequest *types.W
145145

146146
workflowTemplate.ConfigMaps = workflowConfigMaps
147147
workflowTemplate.Secrets = workflowSecrets
148-
workflowTemplate.Volumes = executors.ExtractVolumesFromCmCs(workflowConfigMaps, workflowSecrets)
148+
workflowTemplate.Volumes = executors.ExtractVolumes(workflowConfigMaps, workflowSecrets)
149149

150150
workflowRequest.AddNodeConstraintsFromConfig(&workflowTemplate, impl.ciCdConfig)
151151
infraConfiguration := &bean4.InfraConfig{}

‎pkg/pipeline/executors/WorkflowUtils.go

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
2222
"github.com/argoproj/argo-workflows/v3/pkg/client/clientset/versioned"
2323
v1alpha12 "github.com/argoproj/argo-workflows/v3/pkg/client/clientset/versioned/typed/workflow/v1alpha1"
24+
"github.com/devtron-labs/common-lib/utils"
2425
bean2 "github.com/devtron-labs/devtron/api/bean"
2526
"github.com/devtron-labs/devtron/internal/sql/repository"
2627
"github.com/devtron-labs/devtron/pkg/pipeline/bean"
@@ -34,6 +35,17 @@ import (
3435

3536
var ArgoWorkflowOwnerRef = v1.OwnerReference{APIVersion: "argoproj.io/v1alpha1", Kind: "Workflow", Name: "{{workflow.name}}", UID: "{{workflow.uid}}", BlockOwnerDeletion: &[]bool{true}[0]}
3637

38+
func ExtractVolumes(configMaps []bean2.ConfigSecretMap, secrets []bean2.ConfigSecretMap) []v12.Volume {
39+
var volumes []v12.Volume
40+
configMapVolumes := ExtractVolumesFromCmCs(configMaps, secrets)
41+
volumes = append(volumes, configMapVolumes...)
42+
43+
// Add downwardAPI volume
44+
downwardAPIVolume := createDownwardAPIVolume()
45+
volumes = append(volumes, downwardAPIVolume)
46+
return volumes
47+
}
48+
3749
func ExtractVolumesFromCmCs(configMaps []bean2.ConfigSecretMap, secrets []bean2.ConfigSecretMap) []v12.Volume {
3850
var volumes []v12.Volume
3951
configMapVolumes := extractVolumesFromConfigSecretMaps(true, configMaps)
@@ -45,9 +57,34 @@ func ExtractVolumesFromCmCs(configMaps []bean2.ConfigSecretMap, secrets []bean2.
4557
for _, volume := range secretVolumes {
4658
volumes = append(volumes, volume)
4759
}
60+
4861
return volumes
4962
}
5063

64+
func createDownwardAPIVolume() v12.Volume {
65+
return v12.Volume{
66+
Name: utils.DEVTRON_SELF_DOWNWARD_API_VOLUME,
67+
VolumeSource: v12.VolumeSource{
68+
DownwardAPI: &v12.DownwardAPIVolumeSource{
69+
Items: []v12.DownwardAPIVolumeFile{
70+
{
71+
Path: "labels",
72+
FieldRef: &v12.ObjectFieldSelector{
73+
FieldPath: "metadata.labels",
74+
},
75+
},
76+
{
77+
Path: "annotations",
78+
FieldRef: &v12.ObjectFieldSelector{
79+
FieldPath: "metadata.annotations",
80+
},
81+
},
82+
},
83+
},
84+
},
85+
}
86+
}
87+
5188
func extractVolumesFromConfigSecretMaps(isCm bool, configSecretMaps []bean2.ConfigSecretMap) []v12.Volume {
5289
var volumes []v12.Volume
5390
for _, configSecretMap := range configSecretMaps {

‎pkg/pipeline/types/Workflow.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,13 @@ func (workflowRequest *WorkflowRequest) GetWorkflowMainContainer(config *CiCdCon
497497
TerminationMessagePath: workFlow.GetTerminalLogFilePath(),
498498
Resources: workflowRequest.GetLimitReqCpuMem(config, infraConfigurations),
499499
}
500+
// add volumeMount for downwardAPI volume
501+
workflowMainContainer.VolumeMounts = append(workflowMainContainer.VolumeMounts,
502+
v1.VolumeMount{
503+
Name: utils.DEVTRON_SELF_DOWNWARD_API_VOLUME,
504+
MountPath: utils.DEVTRON_SELF_DOWNWARD_API_VOLUME_PATH,
505+
},
506+
)
500507
if workflowRequest.Type == bean.CI_WORKFLOW_PIPELINE_TYPE || workflowRequest.Type == bean.JOB_WORKFLOW_PIPELINE_TYPE {
501508
workflowMainContainer.Ports = []v1.ContainerPort{{
502509
// exposed for user specific data from ci container
@@ -547,7 +554,7 @@ func (workflowRequest *WorkflowRequest) updateVolumeMountsForCi(config *CiCdConf
547554
return err
548555
}
549556
workflowTemplate.Volumes = append(workflowTemplate.Volumes, volume...)
550-
workflowMainContainer.VolumeMounts = volumeMounts
557+
workflowMainContainer.VolumeMounts = append(workflowMainContainer.VolumeMounts, volumeMounts...)
551558
return nil
552559
}
553560

‎vendor/github.com/devtron-labs/common-lib/utils/CommonUtils.go

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vendor/modules.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -336,15 +336,15 @@ github.com/davecgh/go-spew/spew
336336
# github.com/deckarep/golang-set v1.8.0
337337
## explicit; go 1.17
338338
github.com/deckarep/golang-set
339-
# github.com/devtron-labs/authenticator v0.4.35-0.20240809073103-6e11da8083f8 => github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241216110450-9f2f2d5a0281
339+
# github.com/devtron-labs/authenticator v0.4.35-0.20240809073103-6e11da8083f8 => github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241220103339-f61a1734c0f4
340340
## explicit; go 1.21
341341
github.com/devtron-labs/authenticator/apiToken
342342
github.com/devtron-labs/authenticator/client
343343
github.com/devtron-labs/authenticator/jwt
344344
github.com/devtron-labs/authenticator/middleware
345345
github.com/devtron-labs/authenticator/oidc
346346
github.com/devtron-labs/authenticator/password
347-
# github.com/devtron-labs/common-lib v0.18.1-0.20241001061923-eda545dc839e => github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241216110450-9f2f2d5a0281
347+
# github.com/devtron-labs/common-lib v0.18.1-0.20241001061923-eda545dc839e => github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241220103339-f61a1734c0f4
348348
## explicit; go 1.21
349349
github.com/devtron-labs/common-lib/async
350350
github.com/devtron-labs/common-lib/blob-storage
@@ -2213,8 +2213,8 @@ xorm.io/xorm/log
22132213
xorm.io/xorm/names
22142214
xorm.io/xorm/schemas
22152215
xorm.io/xorm/tags
2216-
# github.com/devtron-labs/authenticator => github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241216110450-9f2f2d5a0281
2217-
# github.com/devtron-labs/common-lib => github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241216110450-9f2f2d5a0281
2216+
# github.com/devtron-labs/authenticator => github.com/devtron-labs/devtron-services/authenticator v0.0.0-20241220103339-f61a1734c0f4
2217+
# github.com/devtron-labs/common-lib => github.com/devtron-labs/devtron-services/common-lib v0.0.0-20241220103339-f61a1734c0f4
22182218
# github.com/go-check/check => github.com/go-check/check v0.0.0-20180628173108-788fd7840127
22192219
# github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.5.5
22202220
# k8s.io/api => k8s.io/api v0.29.7

‎wire_gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)