Skip to content

Commit a720200

Browse files
committed
fix for chart version
1 parent 7a7627e commit a720200

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

pkg/generateManifest/DeploymentTemplateService.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ func (impl DeploymentTemplateServiceImpl) fetchResolvedTemplateForPublishedEnvs(
335335
impl.Logger.Errorw("error in getting overridden values", "err", err)
336336
return nil, err
337337
}
338-
_, _, version, _, err := impl.chartRefService.GetRefChart(request.ChartRefId)
338+
_, _, version, _, err := impl.chartRefService.GetRefChart(override.EnvironmentConfig.ChartRefId)
339339
if err != nil {
340340
impl.Logger.Errorw("error in getting chart ref by chartRefId ", "chartRefId", request.ChartRefId, "err", err)
341341
return nil, err

pkg/pipeline/PropertiesConfig.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,9 @@ func (impl PropertiesConfigServiceImpl) GetEnvironmentProperties(appId, environm
129129
IsBasicViewLocked: envOverride.IsBasicViewLocked,
130130
CurrentViewEditor: envOverride.CurrentViewEditor,
131131
}
132+
if chartRefId == 0 && envOverride.Chart != nil {
133+
environmentProperties.ChartRefId = envOverride.Chart.ChartRefId
134+
}
132135

133136
if environmentPropertiesResponse.Namespace == "" {
134137
environmentPropertiesResponse.Namespace = envOverride.Namespace
@@ -140,8 +143,10 @@ func (impl PropertiesConfigServiceImpl) GetEnvironmentProperties(appId, environm
140143
}
141144
if errors.IsNotFound(err) {
142145
environmentProperties.Id = 0
143-
environmentProperties.ChartRefId = chartRefId
144146
environmentProperties.IsOverride = false
147+
if chartRefId > 0 {
148+
environmentProperties.ChartRefId = chartRefId
149+
}
145150
} else {
146151
environmentProperties.Id = ecOverride.Id
147152
environmentProperties.Latest = ecOverride.Latest
@@ -153,6 +158,9 @@ func (impl PropertiesConfigServiceImpl) GetEnvironmentProperties(appId, environm
153158
environmentProperties.Active = ecOverride.Active
154159
environmentProperties.IsBasicViewLocked = ecOverride.IsBasicViewLocked
155160
environmentProperties.CurrentViewEditor = ecOverride.CurrentViewEditor
161+
if chartRefId == 0 && ecOverride.Chart != nil {
162+
environmentProperties.ChartRefId = ecOverride.Chart.ChartRefId
163+
}
156164
}
157165
environmentPropertiesResponse.ChartRefId = chartRefId
158166
environmentPropertiesResponse.EnvironmentConfig = *environmentProperties

0 commit comments

Comments
 (0)