minor fix

prakash100198 · prakash100198 · commit b766ef6d31ad · 2024-12-04T02:47:40.000+05:30
diff --git a/pkg/pipeline/repository/PipelineStageRepository.go b/pkg/pipeline/repository/PipelineStageRepository.go
@@ -17,6 +17,7 @@
 package repository
 
 import (
+	"github.com/devtron-labs/devtron/internal/util"
 	"github.com/devtron-labs/devtron/pkg/plugin/repository"
 	"github.com/devtron-labs/devtron/pkg/sql"
 	"github.com/go-pg/pg"
@@ -907,9 +908,11 @@ func (impl *PipelineStageRepositoryImpl) CheckIfPluginExistsInPipelineStage(pipe
 		query.Where("ps.cd_pipeline_id= ?", pipelineId)
 	}
 	err := query.Select()
-	if err != nil {
+	if err != nil && !util.IsErrNoRows(err) {
 		impl.logger.Errorw("error in getting plugin stage step by pipelineId, stageType nad plugin id", "pipelineId", pipelineId, "stageType", stageType.ToString(), "pluginId", pluginId, "err", err)
 		return false, err
+	} else if util.IsErrNoRows(err) {
+		return false, nil
 	}
 	return step.Id != 0, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`package repository`
`18`	`18`
`19`	`19`	`import (`
	`20`	`+ "github.com/devtron-labs/devtron/internal/util"`
`20`	`21`	`"github.com/devtron-labs/devtron/pkg/plugin/repository"`
`21`	`22`	`"github.com/devtron-labs/devtron/pkg/sql"`
`22`	`23`	`"github.com/go-pg/pg"`
`@@ -907,9 +908,11 @@ func (impl *PipelineStageRepositoryImpl) CheckIfPluginExistsInPipelineStage(pipe`
`907`	`908`	`query.Where("ps.cd_pipeline_id= ?", pipelineId)`
`908`	`909`	`}`
`909`	`910`	`err := query.Select()`
`910`		`- if err != nil {`
	`911`	`+ if err != nil && !util.IsErrNoRows(err) {`
`911`	`912`	`impl.logger.Errorw("error in getting plugin stage step by pipelineId, stageType nad plugin id", "pipelineId", pipelineId, "stageType", stageType.ToString(), "pluginId", pluginId, "err", err)`
`912`	`913`	`return false, err`
	`914`	`+ } else if util.IsErrNoRows(err) {`
	`915`	`+ return false, nil`
`913`	`916`	`}`
`914`	`917`	`return step.Id != 0, nil`
`915`	`918`	`}`