feat: Link helm release (#6454)

* wip:deployment config old data migration code

* updating repo url get usage

* comments

* adding comments

* wip: adding repo name in deployment config struct

* migration files

* migration update

* feat: updated the target revision

* review changes

* nil handling

* dev testing bug fixes

* fixes

* value file name fix

* fixes

* repo url function update

* git repo url handing using code

* fixing import cycle

* feat: dynamic chart loaction and valuesfile path

* CRUD operations

* repo clone and env override create flow

* wip: self review changes

* feat: trigger flows updated

* self review changes

* refactoring

* self review fix: env override create

* skipping checks

* feat: Skip GitOps config CRUD ACD operation if argo module is not installed

* handling for IsGitOpsConfigured

* feat: release mode data adaptor

* validation api

* deployment status changes and application filter logic change

* self review changes

* delete acd app handling

* adding route

* modifying validate link request

* pipeline crud operation

* dev testing fix

* wip: release config data type fix

* fixing check

* updated wire gen

* added api /environment-variables

* added releaseMode validation

* fix: isGitOpsEnable flag

* updated EnvironmentVariableList response

* updated git repo validations

* updated migration number

* fix: skip pipeline create validation

* panic handler for cd pipeline creation

* updated wire dep

* fix: cd trigger panic fix

* fix: validation migrate cd pipeline api

* updated ValidateGitOpsRepoUrl request for custom gitops logic

* fix: git clone logic for validate migration request

* fix: updated API key

* chart name handling for migrate release

* fix: chart validation

* fix: chart validation

* fix: pipeline creation

* feat: is gitops repo configured flag updated

* wip: trigger fix

* feat: filter external argo app list

* read service for circular import

* fix nil poniter panic

* fix: empty argo app list

* fix empty app name

* updated dep of DeploymentConfigService instead of DeploymentConfigReadService in ArgoApplicationService

* minor refactorings

* replaced release app name from util function

* validation and flag if config is for external helm release

* fix migrated from flag

* fix: resource tree api with scoop

* fix: error handling for GetResourceTree

* fixing set chart location function

* updating config type

* fix: scoop argo_cd GetResourceTree

* fix: updated validation error

* fix: updated BuildDeployedAppName references

* fix: common wire set

* updating chart location while delete

* fix user id

* common function for url already present

* removing duplicate logic for pipeline filter

* fix: nil checker issues

* updated global api

* pg no rows handling

* manual sync mode fix for trigger/deployment statys

* fix: resource tree

* fix: panic handling

* fix default namespace

* wip

* fix: pipeline delete flow

* fix: delete apllication object

* fix: delete application object

* chore: refactored AppDetailsReadService

* added: vlaidation for link external release

* review comment incorporated

* fix: pointer datatype

* added: EnforcedPolicyViolation validation

* fix app clone

* make fix

* fix: workflow_execution_stage cloumn

* added gitops adapter

* helm deployment status fix

* updated deployment config queries

* fix: generate manifest diff

* wire gen updated

* updated feature flag name

* updated env_gen.md file

* feat: argocd resource tree support

* fix: nil handling updated

* fix: context handling

* review changes

* chore: deployment config refactorings

* fix: on-board argocd issues

* updated updateArgoAppDeleteStatus func

* review changes

* make fix

* delete argo app error handling fixes

* payload changes

* argo app listing api updated

* updated wire_gen files

* chore: Argocd dependabot fixes (#6402)

* version matched with enterprise

* vulnerability fix

* argocd dependabot fixes

* argo workflow dependabot fixes

* fix: link request

* updated migration script

* fix: GetDeploymentConfigMinForAppAndEnv for app stage api

* fix: helm app gitops target revision

* fix: cd pipeline create blocked if argo module not installed

* setting repo url in new deployment config also

* default branch (backward compatibility) if branch is not passed

* updated target revision

* fix: release config target revision

* updated not deployed status to degraded

* go mod tidy

* helm list api moved from enterprise

* fix: app delete flow

* listing api

* query fix

* fix: git commit ref not found

* fix: git commit ref not found

* fix: gitops branch pull error

* validate api for external helm release

* fix enum

* fix: removed unused import

* chore: func renamed

* rest handler update

* updating chart location when base version is changed

* chart location update in deployment config

* chart env override fix

* wip: fixed pg no rows

* wip: bug fixes

* fix empty env id

* integration fixes

* is linkable true

* fix chart name

* enterprise code moved

* function rename

* fix empty cluster url

* namespace fix

* listing api fix

* wip: installed app query fix

* fix for argo module not installed

* wip: adding chart loaction

* renaming

* wip

* wip: head validation

* refactoring

* deployment app type change fix

* chart location heal

* wip: validation for linked pipeline in app change api

* fix deployment change api

* review changes

* migration update

* validation in create api

* fixing issues

* fix argo unsupported spec error parsingg

* zero time handling

* revert time parse

* empty createdAt handling

* fixing messaging around gitOps

* removing hard coding

* wip: deployment app name added

* fix cluster nil pointer

* fix panic if values file is empty

* renaming

---------

Co-authored-by: Ash-exp <[email protected]>

Author: iamayushm

api/helm-app/HelmAppRestHandler.go

@@ -62,6 +62,7 @@ type HelmAppRestHandler interface {
 	UpdateApplication(w http.ResponseWriter, r *http.Request)
 	TemplateChart(w http.ResponseWriter, r *http.Request)
 	SaveHelmAppDetailsViewedTelemetryData(w http.ResponseWriter, r *http.Request)
+	ListHelmApplicationsForEnvironment(w http.ResponseWriter, r *http.Request)
 }
 
 const HELM_APP_ACCESS_COUNTER = "HelmAppAccessCounter"
@@ -588,3 +589,46 @@ func (handler *HelmAppRestHandlerImpl) SaveHelmAppDetailsViewedTelemetryData(w h
 	common.WriteJsonResp(w, err, nil, http.StatusOK)
 
 }
+
+func (handler *HelmAppRestHandlerImpl) ListHelmApplicationsForEnvironment(w http.ResponseWriter, r *http.Request) {
+
+	query := r.URL.Query()
+
+	clusterIdString := query.Get("clusterId")
+	var (
+		clusterId int
+		envId     int
+		err       error
+	)
+
+	if len(clusterIdString) != 0 {
+		clusterId, err = strconv.Atoi(clusterIdString)
+		if err != nil {
+			common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
+			return
+		}
+	}
+
+	envIdString := query.Get("envId")
+	if len(envIdString) != 0 {
+		envId, err = strconv.Atoi(envIdString)
+		if err != nil {
+			common.WriteJsonResp(w, err, nil, http.StatusBadRequest)
+			return
+		}
+	}
+
+	token := r.Header.Get("token")
+	if ok := handler.enforcer.Enforce(token, casbin.ResourceGlobal, casbin.ActionGet, "*"); !ok {
+		common.WriteJsonResp(w, errors.New("unauthorized"), nil, http.StatusForbidden)
+		return
+	}
+	releaseList, err := handler.helmAppService.ListHelmApplicationsForClusterOrEnv(r.Context(), clusterId, envId)
+	if err != nil {
+		handler.logger.Errorw("error in fetching helm release for given env", "err", err)
+		common.WriteJsonResp(w, err, "error in fetching helm release", http.StatusInternalServerError)
+		return
+	}
+	common.WriteJsonResp(w, nil, releaseList, http.StatusOK)
+	return
+}

api/helm-app/HelmAppRouter.go

@@ -45,6 +45,10 @@ func (impl *HelmAppRouterImpl) InitAppListRouter(helmRouter *mux.Router) {
 	helmRouter.Path("/hibernate").Queries("appType", "{appType}").HandlerFunc(impl.helmAppRestHandler.Hibernate).Methods("POST")
 	helmRouter.Path("/unhibernate").Queries("appType", "{appType}").HandlerFunc(impl.helmAppRestHandler.UnHibernate).Methods("POST")
 
+	helmRouter.Path("/external-helm-release").
+		HandlerFunc(impl.helmAppRestHandler.ListHelmApplicationsForEnvironment).
+		Methods("GET")
+
 	// GetReleaseInfo used only for external apps
 	helmRouter.Path("/release-info").Queries("appId", "{appId}").
 		HandlerFunc(impl.helmAppRestHandler.GetReleaseInfo).Methods("GET")

api/helm-app/bean/bean.go

@@ -26,6 +26,7 @@ const (
 	SOURCE_DEVTRON_APP       SourceAppType = "devtron-app"
 	SOURCE_HELM_APP          SourceAppType = "helm-app"
 	SOURCE_EXTERNAL_HELM_APP SourceAppType = "external-helm-app"
+	SOURCE_LINKED_HELM_APP   SourceAppType = "linked-helm-app"
 	SOURCE_UNKNOWN           SourceAppType = "unknown"
 	ErrReleaseNotFound       string        = "release: not found"
 )

api/helm-app/gRPC/applicationClient.go

@@ -52,6 +52,7 @@ type HelmAppClient interface {
 	InstallReleaseWithCustomChart(ctx context.Context, in *HelmInstallCustomRequest) (*HelmInstallCustomResponse, error)
 	GetNotes(ctx context.Context, request *InstallReleaseRequest) (*ChartNotesResponse, error)
 	ValidateOCIRegistry(ctx context.Context, OCIRegistryRequest *RegistryCredential) (*OCIRegistryResponse, error)
+	GetReleaseDetails(ctx context.Context, in *ReleaseIdentifier) (*DeployedAppDetail, error)
 	GetExternalFluxAppDetail(ctx context.Context, in *FluxAppDetailRequest) (*FluxAppDetail, error)
 }
 
@@ -395,6 +396,19 @@ func (impl *HelmAppClientImpl) ListFluxApplication(ctx context.Context, req *App
 	}
 	return stream, nil
 }
+
+func (impl *HelmAppClientImpl) GetReleaseDetails(ctx context.Context, in *ReleaseIdentifier) (*DeployedAppDetail, error) {
+	applicationClient, err := impl.getApplicationClient()
+	if err != nil {
+		return nil, err
+	}
+	response, err := applicationClient.GetReleaseDetails(ctx, in)
+	if err != nil {
+		return nil, err
+	}
+	return response, nil
+}
+
 func (impl *HelmAppClientImpl) GetExternalFluxAppDetail(ctx context.Context, in *FluxAppDetailRequest) (*FluxAppDetail, error) {
 	applicationClient, err := impl.getApplicationClient()
 	if err != nil {

api/helm-app/gRPC/applist.pb.go

@@ -109,6 +109,8 @@ message DeployedAppDetail {
   EnvironmentDetails environmentDetail = 5;
   google.protobuf.Timestamp LastDeployed = 6;
   string chartVersion = 7;
+  string releaseStatus = 8;
+  string home = 9;
 }
 message EnvironmentDetails{
   string clusterName = 1;