Skip to content

Commit cf86d19

Browse files
committed
fix for Hibernating Filter
1 parent 89109d3 commit cf86d19

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pkg/app/AppListingService.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import (
3737
"go.opentelemetry.io/otel"
3838
"golang.org/x/exp/slices"
3939
"net/http"
40-
"sigs.k8s.io/kustomize/kyaml/sliceutil"
4140
"strconv"
4241
"strings"
4342
"time"
@@ -386,8 +385,10 @@ func (impl AppListingServiceImpl) FetchAppsByEnvironmentV2(fetchAppListingReques
386385
// fun to check if "HIBERNATING" exists in fetchAppListingRequest.AppStatuses
387386
isFilteredOnHibernatingStatus := impl.isFilteredOnHibernatingStatus(fetchAppListingRequest)
388387
// remove ""HIBERNATING" from fetchAppListingRequest.AppStatuses
388+
appStatusesFilter := make([]string, 0)
389389
if isFilteredOnHibernatingStatus {
390-
fetchAppListingRequest.AppStatuses = sliceutil.Remove(fetchAppListingRequest.AppStatuses, bean2.HIBERNATING)
390+
appStatusesFilter = fetchAppListingRequest.AppStatuses
391+
fetchAppListingRequest.AppStatuses = []string{}
391392
}
392393

393394
appListingFilter := helper.AppListingFilter{
@@ -448,7 +449,7 @@ func (impl AppListingServiceImpl) FetchAppsByEnvironmentV2(fetchAppListingReques
448449
if isFilteredOnHibernatingStatus {
449450
filteredContainers := make([]*AppView.AppEnvironmentContainer, 0)
450451
for _, container := range envContainers {
451-
if container.AppStatus == bean2.HIBERNATING {
452+
if slices.Contains(appStatusesFilter, container.AppStatus) {
452453
filteredContainers = append(filteredContainers, container)
453454
}
454455
}

0 commit comments

Comments
 (0)