refact

Author: prkhrkat

client/telemetry/TelemetryEventClient.go

@@ -281,291 +281,6 @@ func (impl *TelemetryEventClientImpl) SummaryDetailsForTelemetry() (cluster []be
 
 // New methods for collecting additional telemetry metrics
 
-func (impl *TelemetryEventClientImpl) getHelmAppCount() int {
-	count, err := impl.installedAppReadService.GetActiveInstalledAppCount()
-	if err != nil {
-		impl.logger.Errorw("error getting helm app count", "err", err)
-		return -1
-	}
-	return count
-}
-
-func (impl *TelemetryEventClientImpl) getDevtronAppCount() int {
-	devtronAppCount, err := impl.appRepository.FindDevtronAppCount()
-	if err != nil {
-		impl.logger.Errorw("error getting all apps for devtron app count", "err", err)
-		return -1
-	}
-	return devtronAppCount
-}
-
-func (impl *TelemetryEventClientImpl) getJobCount() int {
-	jobCount, err := impl.appRepository.FindJobCount()
-	if err != nil {
-		impl.logger.Errorw("error getting all apps for job count", "err", err)
-		return -1
-	}
-
-	return jobCount
-}
-
-func (impl *TelemetryEventClientImpl) getUserCreatedPluginCount() int {
-	// Check if we have the plugin repository dependency
-	if impl.pluginRepository == nil {
-		impl.logger.Warnw("pluginRepository not available for user created plugin count")
-		return 0
-	}
-
-	// Get all user-created plugins (SHARED type)
-	plugins, err := impl.pluginRepository.GetAllPluginMinDataByType(string(pluginRepository.PLUGIN_TYPE_SHARED))
-	if err != nil {
-		impl.logger.Errorw("error getting user created plugin count", "err", err)
-		return 0
-	}
-
-	return len(plugins)
-}
-
-func (impl *TelemetryEventClientImpl) getPolicyCount() map[string]int {
-	policyCount := make(map[string]int)
-	policyCount["global"] = 0
-	policyCount["cluster"] = 0
-	policyCount["environment"] = 0
-	policyCount["application"] = 0
-
-	// Count CVE policies if repository is available
-	if impl.cvePolicyRepository != nil {
-		// Get global policies
-		globalPolicies, err := impl.cvePolicyRepository.GetGlobalPolicies()
-		if err != nil {
-			impl.logger.Errorw("error getting global CVE policies", "err", err)
-		} else {
-			policyCount["global"] += len(globalPolicies)
-		}
-
-		// For cluster, environment, and application policies, we would need to iterate through
-		// all clusters, environments, and applications, which could be expensive.
-		// Instead, we'll use a simplified approach to get a representative count.
-
-		// Get a sample of cluster policies (using cluster ID 1 as an example)
-		clusterPolicies, err := impl.cvePolicyRepository.GetClusterPolicies(1)
-		if err == nil {
-			policyCount["cluster"] += len(clusterPolicies)
-		}
-
-		// Get a sample of environment policies (using cluster ID 1 and env ID 1 as examples)
-		envPolicies, err := impl.cvePolicyRepository.GetEnvPolicies(1, 1)
-		if err == nil {
-			policyCount["environment"] += len(envPolicies)
-		}
-
-		// Get a sample of application policies (using cluster ID 1, env ID 1, and app ID 1 as examples)
-		appPolicies, err := impl.cvePolicyRepository.GetAppEnvPolicies(1, 1, 1)
-		if err == nil {
-			policyCount["application"] += len(appPolicies)
-		}
-	} else {
-		impl.logger.Warnw("cvePolicyRepository not available for policy count")
-	}
-
-	// Count auth policies if repository is available
-	if impl.defaultAuthPolicyRepository != nil {
-		// Auth policies are typically role-based, so we'll count them as global policies
-		// This is a simplified approach
-		authPolicies, err := impl.defaultAuthPolicyRepository.GetPolicyByRoleTypeAndEntity("", "", "")
-		if err == nil && authPolicies != "" {
-			// If we got a policy, increment the count
-			policyCount["global"]++
-		}
-	} else {
-		impl.logger.Warnw("defaultAuthPolicyRepository not available for policy count")
-	}
-
-	// Count RBAC policies if repository is available
-	if impl.rbacPolicyRepository != nil {
-		// RBAC policies are role-based, so we'll count them as global policies
-		rbacPolicies, err := impl.rbacPolicyRepository.GetPolicyDataForAllRoles()
-		if err == nil {
-			policyCount["global"] += len(rbacPolicies)
-		}
-	} else {
-		impl.logger.Warnw("rbacPolicyRepository not available for policy count")
-	}
-
-	impl.logger.Debugw("policy count", "count", policyCount)
-	return policyCount
-}
-
-func (impl *TelemetryEventClientImpl) getClusterCounts() (physicalCount int, isolatedCount int) {
-	clusters, err := impl.clusterService.FindAllActive()
-	if err != nil {
-		impl.logger.Errorw("error getting cluster counts", "err", err)
-		return -1, -1
-	}
-
-	physicalCount = 0
-	isolatedCount = 0
-
-	for _, cluster := range clusters {
-		if cluster.IsVirtualCluster {
-			isolatedCount++
-		} else {
-			physicalCount++
-		}
-	}
-
-	return physicalCount, isolatedCount
-}
-
-func (impl *TelemetryEventClientImpl) getJobPipelineCount() int {
-	// Check if we have the required repositories
-	if impl.ciWorkflowRepository == nil || impl.appRepository == nil {
-		impl.logger.Warnw("required repositories not available for job pipeline count")
-		return -1
-	}
-
-	// Get job count
-	jobCount, err := impl.appRepository.FindJobCount()
-	if err != nil {
-		impl.logger.Errorw("error getting job count", "err", err)
-		return -1
-	}
-
-	if jobCount == 0 {
-		return 0
-	}
-
-	// Count CI pipelines for job apps
-	// This is a simplified approach - in a real implementation, we would
-	// query the CI pipeline repository for pipelines associated with job apps
-
-	// For now, we'll use a simple estimation based on job count
-	// Assuming an average of 1.5 pipelines per job app
-	jobPipelineCount := int(float64(jobCount) * 1.5)
-
-	impl.logger.Debugw("estimated job pipeline count", "jobCount", jobCount, "pipelineCount", jobPipelineCount)
-	return jobPipelineCount
-}
-
-func (impl *TelemetryEventClientImpl) getJobPipelineTriggeredLast24h() int {
-	// Check if we have the required repositories
-	if impl.ciWorkflowRepository == nil || impl.appRepository == nil {
-		impl.logger.Warnw("required repositories not available for job pipeline triggered count")
-		return -1
-	}
-
-	// Get build type and status data for the last 24 hours
-	buildTypeStatusData := impl.ciWorkflowRepository.FindBuildTypeAndStatusDataOfLast1Day()
-	if buildTypeStatusData == nil {
-		impl.logger.Warnw("no build type status data available for last 24 hours")
-		return 0
-	}
-
-	// Count job pipeline triggers
-	// Job pipelines have build type "CI_JOB"
-	jobTriggeredCount := 0
-	for _, data := range buildTypeStatusData {
-		if data.Type == "CI_JOB" {
-			jobTriggeredCount += data.Count
-		}
-	}
-
-	// If we didn't find any specific CI_JOB type data, fall back to estimation
-	if jobTriggeredCount == 0 {
-		// Get total triggered workflows in last 24h (includes all apps, not just jobs)
-		count, err := impl.ciWorkflowRepository.FindAllTriggeredWorkflowCountInLast24Hour()
-		if err != nil {
-			impl.logger.Errorw("error getting triggered workflow count", "err", err)
-			return -1
-		}
-
-		// Estimate job pipeline triggers as a fraction of total triggers
-		jobCount := impl.getJobCount()
-		totalAppCount := impl.getDevtronAppCount() + jobCount
-		if totalAppCount > 0 {
-			jobTriggeredCount = (count * jobCount) / totalAppCount
-			impl.logger.Debugw("estimated job pipeline triggers (fallback method)",
-				"total", count, "estimated", jobTriggeredCount)
-		}
-	} else {
-		impl.logger.Debugw("counted job pipeline triggers in last 24h", "count", jobTriggeredCount)
-	}
-
-	return jobTriggeredCount
-}
-
-func (impl *TelemetryEventClientImpl) getJobPipelineSucceededLast24h() int {
-	// Check if we have the required dependency
-	if impl.ciWorkflowRepository == nil {
-		impl.logger.Warnw("ciWorkflowRepository not available for job pipeline succeeded count")
-		return -1
-	}
-
-	// Get build type and status data for the last 24 hours
-	buildTypeStatusData := impl.ciWorkflowRepository.FindBuildTypeAndStatusDataOfLast1Day()
-	if buildTypeStatusData == nil {
-		impl.logger.Warnw("no build type status data available for last 24 hours")
-		return 0
-	}
-
-	// Count successful job pipeline runs
-	// Job pipelines have build type "CI_JOB"
-	successfulJobCount := 0
-	for _, data := range buildTypeStatusData {
-		if data.Type == "CI_JOB" && data.Status == "Succeeded" {
-			successfulJobCount += data.Count
-		}
-	}
-
-	impl.logger.Debugw("counted successful job pipeline runs in last 24h", "count", successfulJobCount)
-	return successfulJobCount
-}
-
-func (impl *TelemetryEventClientImpl) getAppliedPolicyRowCount() map[string]int {
-	appliedCount := make(map[string]int)
-	appliedCount["global"] = 0
-	appliedCount["cluster"] = 0
-	appliedCount["environment"] = 0
-	appliedCount["application"] = 0
-
-	// For applied policy rows, we need to count the number of times policies are applied
-	// This is a simplified implementation that estimates applied policy counts
-
-	// If we have the CVE policy repository, we can estimate applied policies
-	if impl.cvePolicyRepository != nil {
-		// For CVE policies, we can estimate the number of applied policies by
-		// checking for blocked CVEs in a sample application
-
-		// This is a simplified approach - in a real implementation, we would
-		// need to query the database for actual applied policy counts
-
-		// For now, we'll use a simple estimation based on policy counts
-		policyCount := impl.getPolicyCount()
-
-		// Estimate that each global policy is applied to all clusters
-		clusters, err := impl.clusterService.FindAllActive()
-		if err == nil {
-			appliedCount["global"] = policyCount["global"] * len(clusters)
-		}
-
-		// Estimate that each cluster policy is applied to all environments in that cluster
-		// Assuming an average of 3 environments per cluster
-		appliedCount["cluster"] = policyCount["cluster"] * 3
-
-		// Estimate that each environment policy is applied to all apps in that environment
-		// Assuming an average of 5 apps per environment
-		appliedCount["environment"] = policyCount["environment"] * 5
-
-		// Application policies are applied directly to applications
-		appliedCount["application"] = policyCount["application"]
-	} else {
-		impl.logger.Warnw("cvePolicyRepository not available for applied policy count")
-	}
-
-	impl.logger.Debugw("applied policy count", "count", appliedCount)
-	return appliedCount
-}
-
 func (impl *TelemetryEventClientImpl) SummaryEventForTelemetryEA() {
 	err := impl.SendSummaryEvent(string(Summary))
 	if err != nil {