Skip to content

Commit e5a6a00

Browse files
committed
bug fix
1 parent b5008f3 commit e5a6a00

File tree

1 file changed

+27
-5
lines changed

1 file changed

+27
-5
lines changed

pkg/configDiff/utils/utils.go

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,12 @@ func GetKeyValMapForSecretConfigDataAndMaskData(configDataList []*bean.ConfigDat
4040
if secretConfigData.IsESOExternalSecretType() || secretConfigData.External {
4141
continue
4242
}
43+
secretRawData := secretConfigData.Data
44+
if secretConfigData.Global {
45+
secretRawData = secretConfigData.DefaultData
46+
}
4347
var secretData map[string]string
44-
if err := json.Unmarshal(secretConfigData.Data, &secretData); err != nil {
48+
if err := json.Unmarshal(secretRawData, &secretData); err != nil {
4549
return nil, err
4650
}
4751
newMaskedSecretData := make(map[string]string, len(secretData))
@@ -56,7 +60,11 @@ func GetKeyValMapForSecretConfigDataAndMaskData(configDataList []*bean.ConfigDat
5660
if err != nil {
5761
return nil, err
5862
}
59-
secretConfigData.Data = maskedSecretJson
63+
if secretConfigData.Global {
64+
secretConfigData.DefaultData = maskedSecretJson
65+
} else {
66+
secretConfigData.Data = maskedSecretJson
67+
}
6068
}
6169
return keyValMapForSecretConfig, nil
6270
}
@@ -72,8 +80,12 @@ func CompareAndMaskSecretValuesInConfigData(configDataList []*bean.ConfigData, k
7280
if secretConfigData.IsESOExternalSecretType() || secretConfigData.External {
7381
continue
7482
}
83+
secretConfig := secretConfigData.Data
84+
if secretConfigData.Global {
85+
secretConfig = secretConfigData.DefaultData
86+
}
7587
var secretDataMap map[string]string
76-
if err := json.Unmarshal(secretConfigData.Data, &secretDataMap); err != nil {
88+
if err := json.Unmarshal(secretConfig, &secretDataMap); err != nil {
7789
return err
7890
}
7991
if _, ok := keyValMapForSecretConfig1[secretConfigData.Name]; ok {
@@ -94,7 +106,12 @@ func CompareAndMaskSecretValuesInConfigData(configDataList []*bean.ConfigData, k
94106
if err != nil {
95107
return err
96108
}
97-
secretConfigData.Data = maskedSecretJson
109+
if secretConfigData.Global {
110+
secretConfigData.DefaultData = maskedSecretJson
111+
} else {
112+
secretConfigData.Data = maskedSecretJson
113+
}
114+
98115
} else {
99116
//mask all the secret values with SecretMaskedValue(i.e. "********")
100117
newMaskedSecretData := make(map[string]string, len(secretDataMap))
@@ -105,7 +122,12 @@ func CompareAndMaskSecretValuesInConfigData(configDataList []*bean.ConfigData, k
105122
if err != nil {
106123
return err
107124
}
108-
secretConfigData.Data = maskedSecretJson
125+
if secretConfigData.Global {
126+
secretConfigData.DefaultData = maskedSecretJson
127+
} else {
128+
secretConfigData.Data = maskedSecretJson
129+
}
130+
109131
}
110132
}
111133
return nil

0 commit comments

Comments
 (0)