Skip to content

Commit e6ede29

Browse files
committed
override method update
1 parent c86b395 commit e6ede29

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

cmd/external-app/wire_gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/chart/ChartService.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -363,11 +363,11 @@ func (impl *ChartServiceImpl) updateChartLocationForEnvironmentConfigs(ctx conte
363363
}
364364

365365
envOverriddenMap := impl.getEnvOverriddenMap(envOverrides)
366-
for envId, override := range envOverriddenMap {
367-
if !override {
368-
err := impl.deploymentConfigService.UpdateChartLocationInDeploymentConfig(tx, appId, envId, chartRefId, userId, version)
366+
for _, override := range envOverrides {
367+
if isOverridden, ok := envOverriddenMap[override.TargetEnvironment]; ok && isOverridden {
368+
err := impl.deploymentConfigService.UpdateChartLocationInDeploymentConfig(tx, appId, override.TargetEnvironment, chartRefId, userId, version)
369369
if err != nil {
370-
impl.logger.Errorw("error in updating chart location for env level deployment configs", "appId", appId, "envId", envId, "err", err)
370+
impl.logger.Errorw("error in updating chart location for env level deployment configs", "appId", appId, "envId", override.TargetEnvironment, "err", err)
371371
return err
372372
}
373373
}

0 commit comments

Comments
 (0)