review comment to check wfr terminal status

ayu-devtron · ayu-devtron · commit ef60bc434aad · 2025-01-30T00:28:47.000+05:30
diff --git a/pkg/eventProcessor/in/WorkflowEventProcessorService.go b/pkg/eventProcessor/in/WorkflowEventProcessorService.go
@@ -170,7 +170,7 @@ func (impl *WorkflowEventProcessorImpl) SubscribeCDStageCompleteEvent() error {
 			return
 		}
 		wfr.IsArtifactUploaded = cdStageCompleteEvent.IsArtifactUploaded
-		if wfr.Status != string(v1alpha1.NodeSucceeded) && wfr.Status != string(v1alpha1.NodeFailed) {
+		if slices.Contains(cdWorkflowModelBean.WfrTerminalStatusList, wfr.Status) {
 			impl.logger.Debugw("event received from ci runner, updating workflow runner status as succeeded", "savedWorkflowRunnerId", wfr.Id, "oldStatus", wfr.Status, "podStatus", wfr.PodStatus)
 			if cdStageCompleteEvent.IsSuccess {
 				wfr.Status = string(v1alpha1.NodeSucceeded)

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ func (impl *WorkflowEventProcessorImpl) SubscribeCDStageCompleteEvent() error {`
`170`	`170`	`return`
`171`	`171`	`}`
`172`	`172`	`wfr.IsArtifactUploaded = cdStageCompleteEvent.IsArtifactUploaded`
`173`		`- if wfr.Status != string(v1alpha1.NodeSucceeded) && wfr.Status != string(v1alpha1.NodeFailed) {`
	`173`	`+ if slices.Contains(cdWorkflowModelBean.WfrTerminalStatusList, wfr.Status) {`
`174`	`174`	`impl.logger.Debugw("event received from ci runner, updating workflow runner status as succeeded", "savedWorkflowRunnerId", wfr.Id, "oldStatus", wfr.Status, "podStatus", wfr.PodStatus)`
`175`	`175`	`if cdStageCompleteEvent.IsSuccess {`
`176`	`176`	`wfr.Status = string(v1alpha1.NodeSucceeded)`