Skip to content

Commit f53b58a

Browse files
committed
ci pipeline get change
1 parent 59d2a66 commit f53b58a

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

api/restHandler/app/pipeline/configure/BuildPipelineRestHandler.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -565,16 +565,24 @@ func (handler *PipelineConfigRestHandlerImpl) GetCiPipeline(w http.ResponseWrite
565565
common.WriteJsonResp(w, fmt.Errorf("unauthorized user"), "Unauthorized User", http.StatusForbidden)
566566
return
567567
}
568-
ciConf, err := handler.pipelineBuilder.GetCiPipeline(appId)
568+
ciConf, err := handler.getCiPipelineRespResolved(appId)
569569
if err != nil {
570570
handler.Logger.Errorw("service err, GetCiPipeline", "err", err, "appId", appId)
571571
common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
572572
return
573573
}
574+
common.WriteJsonResp(w, err, ciConf, http.StatusOK)
575+
}
576+
577+
func (handler *PipelineConfigRestHandlerImpl) getCiPipelineRespResolved(appId int) (*bean.CiConfigRequest, error) {
578+
ciConf, err := handler.pipelineBuilder.GetCiPipeline(appId)
579+
if err != nil {
580+
return nil, err
581+
}
574582
if ciConf == nil || ciConf.Id == 0 {
575583
err = &util.ApiError{Code: "404", HttpStatusCode: 200, UserMessage: "no data found"}
576584
}
577-
common.WriteJsonResp(w, err, ciConf, http.StatusOK)
585+
return ciConf, err
578586
}
579587

580588
func (handler *PipelineConfigRestHandlerImpl) GetExternalCi(w http.ResponseWriter, r *http.Request) {

0 commit comments

Comments
 (0)