Skip to content

Comments

chore: infra configuration refactored#6286

Merged
Ash-exp merged 22 commits intodevelopfrom
feat-build-infra-cm-cs
Jan 22, 2025
Merged

chore: infra configuration refactored#6286
Ash-exp merged 22 commits intodevelopfrom
feat-build-infra-cm-cs

Conversation

@Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jan 15, 2025 •
edited
Loading

Description

Chore: refactoring for infra config service

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1283

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 15, 2025

The migration files have successfully passed the criteria!!

kartik-579
kartik-579 suggested changes Jan 15, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 15, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 16, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

The migration files have successfully passed the criteria!!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 22, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

The migration files have successfully passed the criteria!!

5 similar comments
@github-actions
Copy link

github-actions bot commented Jan 22, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

The migration files have successfully passed the criteria!!

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

The migration files have successfully passed the criteria!!

@Ash-exp Ash-exp merged commit 822fa30 into develop Jan 22, 2025
17 of 18 checks passed
@Ash-exp Ash-exp deleted the feat-build-infra-cm-cs branch January 22, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

2 more reviewers

@nishant-d nishant-d nishant-d approved these changes

@kartik-579 kartik-579 kartik-579 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:Ready-to-Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ash-exp @nishant-d @kartik-579