misc: Refactor vulnerability query implementation and cleanup unused code #6907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Details**: - Replaced `GetVulnerabilitiesWithFixedVersionByFilters` with `GetVulnerabilityRawData` for a more generic approach. - Removed unused `GetVulnerabilitiesWithFixedVersionByFilters` method and related SQL logic. - Simplified vulnerability processing by removing deduplication logic in `ImageScanService`.
prakash100198
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
…with a single query **Details**: - Added `FindScannedDeployInfoWithFilters` to `ImageScanDeployInfoRepository` for streamlined data retrieval. - Introduced `FetchScannedDeployInfoWithFilters` in `ImageScanService` for improved performance. - Replaced multi-step filtering logic in `ImageScanRestHandler` with optimized query implementation. - Enhanced RBAC handling and super-admin-specific optimizations.
|
vikramdevtron
approved these changes
Jan 5, 2026
|
Bito Automatic Review Skipped – PR Already Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
GetVulnerabilitiesWithFixedVersionByFilterswithGetVulnerabilityRawDatafor a more generic approach.GetVulnerabilitiesWithFixedVersionByFiltersmethod and related SQL logic.ImageScanService.Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2766
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito