Testing TagAdminForm and remove check of size by ensuring constraint at model level

Author: Fantomas42

tagging/forms.py

@@ -19,10 +19,6 @@ def clean_name(self):
         tag_names = parse_tag_input(value)
         if len(tag_names) > 1:
             raise forms.ValidationError(_('Multiple tags were given.'))
-        elif len(tag_names[0]) > settings.MAX_TAG_LENGTH:
-            raise forms.ValidationError(
-                _('A tag may be no more than %s characters long.') %
-                settings.MAX_TAG_LENGTH)
         return value
 
 

tagging/models.py

@@ -470,7 +470,7 @@ class Tag(models.Model):
     A tag.
     """
     name = models.CharField(
-        _('name'), max_length=50,
+        _('name'), max_length=settings.MAX_TAG_LENGTH,
         unique=True, db_index=True)
 
     objects = TagManager()

tagging/tests/tests.py

@@ -12,6 +12,7 @@
 
 from tagging import settings
 from tagging.forms import TagField
+from tagging.forms import TagAdminForm
 from tagging.models import Tag
 from tagging.models import TaggedItem
 from tagging.tests.models import Article
@@ -1035,6 +1036,27 @@ def test_tag_d_validation(self):
             forms.ValidationError, t.clean,
             'foo qwertyuiopasdfghjklzxcvbnmqwertyuiopasdfghjklzxcvbn bar')
 
+#########
+# Forms #
+#########
+
+
+class TestTagAdminForm(TestCase):
+
+    def test_clean_name(self):
+        datas = {'name': 'tag'}
+        form = TagAdminForm(datas)
+        self.assertTrue(form.is_valid())
+
+    def test_clean_name_multi(self):
+        datas = {'name': 'tag error'}
+        form = TagAdminForm(datas)
+        self.assertFalse(form.is_valid())
+
+    def test_clean_name_too_long(self):
+        datas = {'name': 't' * (settings.MAX_TAG_LENGTH + 1)}
+        form = TagAdminForm(datas)
+        self.assertFalse(form.is_valid())
 
 #########
 # Views #