Tests and fixe the TaggedObjectList view

Author: Fantomas42

tagging/tests/tests.py

@@ -7,6 +7,8 @@
 from django.utils import six
 from django.db.models import Q
 from django.test import TestCase
+from django.test.utils import override_settings
+from django.core.exceptions import ImproperlyConfigured
 
 from tagging import settings
 from tagging.forms import TagField
@@ -1031,3 +1033,61 @@ def test_tag_d_validation(self):
         self.assertRaises(
             forms.ValidationError, t.clean,
             'foo qwertyuiopasdfghjklzxcvbnmqwertyuiopasdfghjklzxcvbn bar')
+
+
+#########
+# Views #
+#########
+
+
+@override_settings(
+    ROOT_URLCONF='tagging.tests.urls',
+    TEMPLATE_LOADERS=(
+        'tagging.tests.utils.VoidLoader',
+    ),
+)
+class TestTaggedObjectList(TestCase):
+
+    def setUp(self):
+        self.a1 = Article.objects.create(name='article 1')
+        self.a2 = Article.objects.create(name='article 2')
+        Tag.objects.update_tags(self.a1, 'static tag test')
+        Tag.objects.update_tags(self.a2, 'static test')
+
+    def get_view(self, url, queries=1, code=200,
+                 expected_items=1,
+                 friendly_context='article_list',
+                 template='tests/article_list.html'):
+        with self.assertNumQueries(queries):
+            response = self.client.get(url)
+        self.assertEquals(response.status_code, code)
+
+        if code == 200:
+            self.assertTrue(isinstance(response.context['tag'], Tag))
+            self.assertEqual(len(response.context['object_list']),
+                             expected_items)
+            self.assertEqual(response.context['object_list'],
+                             response.context[friendly_context])
+            self.assertTemplateUsed(response, template)
+        return response
+
+    def test_view_static(self):
+        self.get_view('/static/', expected_items=2)
+
+    def test_view_dynamic(self):
+        self.get_view('/tag/', expected_items=1)
+
+    def test_view_related(self):
+        response = self.get_view('/static/related/',
+                                 queries=2, expected_items=2)
+        self.assertEquals(len(response.context['related_tags']), 2)
+
+    def test_view_no_queryset_no_model(self):
+        self.assertRaises(ImproperlyConfigured, self.get_view,
+                          '/no-query-no-model/')
+
+    def test_view_no_tag(self):
+        self.assertRaises(AttributeError, self.get_view, '/no-tag/')
+
+    def test_view_404(self):
+        self.get_view('/unavailable/', code=404)

tagging/tests/urls.py

@@ -0,0 +1,20 @@
+"""Test urls for tagging."""
+from django.conf.urls import url
+
+from tagging.views import TaggedObjectList
+from tagging.tests.models import Article
+
+
+class StaticTaggedObjectList(TaggedObjectList):
+    tag = 'static'
+    queryset = Article.objects.all()
+
+
+urlpatterns = [
+    url(r'^static/$', StaticTaggedObjectList.as_view()),
+    url(r'^static/related/$', StaticTaggedObjectList.as_view(
+        related_tags=True)),
+    url(r'^no-tag/$', TaggedObjectList.as_view(model=Article)),
+    url(r'^no-query-no-model/$', TaggedObjectList.as_view()),
+    url(r'^(?P<tag>[^/]+(?u))/$', TaggedObjectList.as_view(model=Article)),
+]

tagging/tests/utils.py

@@ -0,0 +1,16 @@
+"""
+Tests utils for tagging.
+"""
+
+from django.template.loader import BaseLoader
+
+class VoidLoader(BaseLoader):
+    """
+    Template loader which is always returning
+    an empty template.
+    """
+    is_usable = True
+    _accepts_engine_in_init = True
+
+    def load_template_source(self, template_name, template_dirs=None):
+        return ('', 'voidloader:%s' % template_name)

tagging/views.py

@@ -9,6 +9,7 @@
 from tagging.models import Tag
 from tagging.models import TaggedItem
 from tagging.utils import get_tag
+from tagging.utils import get_queryset_and_model
 
 
 class TaggedObjectList(ListView):
@@ -71,7 +72,7 @@ def get_context_data(self, **kwargs):
         context['tag'] = self.tag_instance
 
         if self.related_tags:
+            queryset, model = get_queryset_and_model(self.queryset_or_model)
             context['related_tags'] = Tag.objects.related_for_model(
-                self.tag_instance, self.queryset_or_model,
-                counts=self.related_tag_counts)
+                self.tag_instance, model, counts=self.related_tag_counts)
         return context