fix: fix review comments

Author: meness

src/handlers/summary.handler.ts

@@ -2,9 +2,11 @@ import { RestEndpointMethodTypes } from '@octokit/plugin-rest-endpoint-methods';
 import { generateObject } from 'ai';
 import { Context } from 'probot';
 import { toneDetails } from '~common/consts';
+import { Severity } from '~common/enums';
 import { Handler } from '~common/interfaces';
 import { Config, FileContent, SummaryObject } from '~common/types';
 import { aiConfig, appConfig } from '~configs';
+import { SystemError } from '~errors';
 import { summaryObjectSchema } from '~schemas';
 import { AiService, CacheService, GitHubService, QueueService, TemplateService } from '~services';
 import { summaryCommentTemplate, summaryPromptTemplate, summarySystemTemplate } from '~templates';
@@ -25,7 +27,7 @@ export class SummaryHandler implements Handler<'pull_request'> {
     }
 
     const fileContents = await this.queueService.schedule(() => GitHubService.getPullRequestFilesContent(context));
-    const summaryObject = await this.generateFileContexts(apiKey, config, fileContents);
+    const summaryObject = await this.generateSummaryObject(apiKey, config, fileContents);
     const summary = this.generateMarkdown(summaryObject.data);
     const existingComment = await this.findExistingComment(context);
 
@@ -75,30 +77,34 @@ export class SummaryHandler implements Handler<'pull_request'> {
       .join('\n');
   }
 
-  private async generateFileContexts(
+  private async generateSummaryObject(
     apiKey: string,
     config: Config,
     fileContents: FileContent[]
   ): Promise<SummaryObject> {
-    const filesContext = fileContents.map((file) => file.path + ': ' + file.content).join('\n');
+    const filesContext = JSON.stringify(fileContents);
 
-    const result = await this.queueService.schedule(() =>
-      generateObject<SummaryObject>({
-        topP: aiConfig.topP.summary,
-        model: this.aiService.getModel(aiConfig.model.summary, apiKey, true),
-        system: TemplateService.render(summarySystemTemplate, {
-          tone: toneDetails[config.summary.tone],
-          language: config.language
-        }),
-        prompt: TemplateService.render(summaryPromptTemplate, {
-          tone: toneDetails[config.summary.tone],
-          language: config.language,
-          filesContext
-        }),
-        schema: summaryObjectSchema
-      })
-    );
+    try {
+      const result = await this.queueService.schedule(() =>
+        generateObject<SummaryObject>({
+          topP: aiConfig.topP.summary,
+          model: this.aiService.getModel(aiConfig.model.summary, apiKey, true),
+          system: TemplateService.render(summarySystemTemplate, {
+            tone: toneDetails[config.summary.tone],
+            language: config.language
+          }),
+          prompt: TemplateService.render(summaryPromptTemplate, {
+            tone: toneDetails[config.summary.tone],
+            language: config.language,
+            filesContext
+          }),
+          schema: summaryObjectSchema
+        })
+      );
 
-    return result.object;
+      return result.object;
+    } catch (error) {
+      throw new SystemError('Failed to generate summary object', Severity.ERROR, error);
+    }
   }
 }

src/handlers/walkthrough.handler.ts

@@ -27,7 +27,7 @@ export class WalkthroughHandler implements Handler<'pull_request'> {
     }
 
     const fileContents = await this.queueService.schedule(() => GitHubService.getPullRequestFilesContent(context));
-    const walkthroughObject = await this.generateWalkthrough(apiKey, config, fileContents);
+    const walkthroughObject = await this.generateWalkthroughObject(apiKey, config, fileContents);
     const existingComment = await this.findExistingComment(context);
     const changes = this.generateMarkdown(walkthroughObject.changes);
 
@@ -69,11 +69,13 @@ export class WalkthroughHandler implements Handler<'pull_request'> {
     return header + rows;
   }
 
-  private async generateWalkthrough(
+  private async generateWalkthroughObject(
     apiKey: string,
     config: Config,
     fileContents: FileContent[]
   ): Promise<WalkthroughObject> {
+    const filesContext = JSON.stringify(fileContents);
+
     try {
       const result = await this.queueService.schedule(() =>
         generateObject<WalkthroughObject>({
@@ -84,15 +86,15 @@ export class WalkthroughHandler implements Handler<'pull_request'> {
             language: config.language
           }),
           prompt: TemplateService.render(walkthroughPromptTemplate, {
-            filesContext: JSON.stringify(fileContents)
+            filesContext
           }),
           schema: walkthroughObjectSchema
         })
       );
 
       return result.object;
     } catch (error) {
-      throw new SystemError('Failed to generate walkthrough', Severity.ERROR, error);
+      throw new SystemError('Failed to generate walkthrough object', Severity.ERROR, error);
     }
   }
 }