Skip to content

Commit 1267244

Browse files
committed
build: update node to avoid strict-engines error caused by npm
Avoids: ``` Lockfile is up to date, resolution step is skipped  ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version) Your Node version is incompatible with "[email protected]". Expected version: ^20.17.0 || >=22.9.0 Got: v20.11.1 ```
1 parent e2f606f commit 1267244

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20.11.1
1+
20.17.0

WORKSPACE

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
workspace(name = "angular_cli")
22

3-
DEFAULT_NODE_VERSION = "20.11.1"
3+
DEFAULT_NODE_VERSION = "20.17.0"
44

55
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_file")
66

@@ -62,13 +62,14 @@ rules_pkg_dependencies()
6262
load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
6363

6464
NODE_20_REPO = {
65-
"20.11.1-darwin_arm64": ("node-v20.11.1-darwin-arm64.tar.gz", "node-v20.11.1-darwin-arm64", "e0065c61f340e85106a99c4b54746c5cee09d59b08c5712f67f99e92aa44995d"),
66-
"20.11.1-darwin_amd64": ("node-v20.11.1-darwin-x64.tar.gz", "node-v20.11.1-darwin-x64", "c52e7fb0709dbe63a4cbe08ac8af3479188692937a7bd8e776e0eedfa33bb848"),
67-
"20.11.1-linux_arm64": ("node-v20.11.1-linux-arm64.tar.xz", "node-v20.11.1-linux-arm64", "c957f29eb4e341903520caf362534f0acd1db7be79c502ae8e283994eed07fe1"),
68-
"20.11.1-linux_ppc64le": ("node-v20.11.1-linux-ppc64le.tar.xz", "node-v20.11.1-linux-ppc64le", "51343cacf5cdf5c4b5e93e919d19dd373d6ef43d5f2c666eae299f26e31d08b5"),
69-
"20.11.1-linux_s390x": ("node-v20.11.1-linux-s390x.tar.xz", "node-v20.11.1-linux-s390x", "b32616b705cd0ddbb230b95c693e3d7a37becc2ced9bcadea8dc824cceed6be0"),
70-
"20.11.1-linux_amd64": ("node-v20.11.1-linux-x64.tar.xz", "node-v20.11.1-linux-x64", "d8dab549b09672b03356aa2257699f3de3b58c96e74eb26a8b495fbdc9cf6fbe"),
71-
"20.11.1-windows_amd64": ("node-v20.11.1-win-x64.zip", "node-v20.11.1-win-x64", "bc032628d77d206ffa7f133518a6225a9c5d6d9210ead30d67e294ff37044bda"),
65+
# From: https://github.com/bazel-contrib/rules_nodejs/blob/main/nodejs/private/node_versions.bzl.
66+
"20.17.0-darwin_arm64": ("node-v20.17.0-darwin-arm64.tar.gz", "node-v20.17.0-darwin-arm64", "476324108c4361935465631eec47df1c943ba2c87bc050853385b1d1c71f0b1f"),
67+
"20.17.0-darwin_amd64": ("node-v20.17.0-darwin-x64.tar.gz", "node-v20.17.0-darwin-x64", "eefe9447dbb0b5b233d42730989c6c364487de4043145db2f63da94e9623c380"),
68+
"20.17.0-linux_arm64": ("node-v20.17.0-linux-arm64.tar.xz", "node-v20.17.0-linux-arm64", "7ebbb636c23f89dbf66648e227fbd0998ce33db4c588520256425102d97dd1a4"),
69+
"20.17.0-linux_ppc64le": ("node-v20.17.0-linux-ppc64le.tar.xz", "node-v20.17.0-linux-ppc64le", "5de1314b090bb95d63a246920baa84c10ed6d60740f28127ce57cda7f13eddc2"),
70+
"20.17.0-linux_s390x": ("node-v20.17.0-linux-s390x.tar.xz", "node-v20.17.0-linux-s390x", "0b2bd20c0047b48da55b87b041971b44f7e31a3d6af6b4b435e4c9203c4c2176"),
71+
"20.17.0-linux_amd64": ("node-v20.17.0-linux-x64.tar.xz", "node-v20.17.0-linux-x64", "a24db3dcd151a52e75965dba04cf1b3cd579ff30d6e0af9da1aede4d0f17486b"),
72+
"20.17.0-windows_amd64": ("node-v20.17.0-win-x64.zip", "node-v20.17.0-win-x64", "e323fff0aba197090faabd29c4c23f334557ff24454324f0c83faa7e399dbb74"),
7273
}
7374

7475
# Set the default nodejs toolchain to the latest supported major version

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
},
3434
"packageManager": "[email protected]",
3535
"engines": {
36-
"node": "^20.11.1 || >=22.0.0",
36+
"node": "^20.17.0 || >=22.0.0",
3737
"npm": "Please use yarn instead of NPM to install dependencies",
3838
"yarn": "Please use pnpm instead of Yarn to install dependencies",
3939
"pnpm": "^9.15.6"

0 commit comments

Comments
 (0)