fix test

Author: devversion

.github/shared-actions/windows-bazel-test/action.yml

@@ -32,7 +32,7 @@ runs:
     #   * symlink_prefix=/:    Needed as otherwise we will create unix symlinks in the Windows host.
     - run: |
         ${{inputs.command}} \
-          --//e2e/legacy-cli:enable_native_windows_testing=true \
+          --//tests/legacy-cli:enable_native_windows_testing=true \
           --test_env="NG_E2E_RUNNER_WSL_ROOT=${{steps.init_wsl.outputs.wsl_root_path}}" \
           --test_env="NG_E2E_RUNNER_WSL_UNC_BASE=${{steps.init_wsl.outputs.wsl_root_unc_path}}" \
           --test_env="NG_E2E_RUNNER_WINDOWS_CMD=${{steps.init_wsl.outputs.cmd_path}}" \

tests/legacy-cli/e2e.bzl

@@ -126,23 +126,18 @@ def _e2e_tests(name, runner, windows_node_repo, **kwargs):
     toolchains = toolchains + ["@npm//@angular/build-tooling/bazel/browsers/chromium:toolchain_alias"]
     data = data + ["@npm//@angular/build-tooling/bazel/browsers/chromium"]
 
-    windows_node_files = [
+    windows_test_files = [
         "@%s//:node_files" % windows_node_repo,
         "@%s//:npm_files" % windows_node_repo,
         "@%s//:bin/npm.cmd" % windows_node_repo,
+        "@org_chromium_chromedriver_windows//:metadata",
+        "@org_chromium_chromium_windows//:metadata",
     ]
 
     # In Windows native testing mode, add Windows dependencies. Those are not
     # available by default as we technically execute inside Linux/WSL.
-    toolchains = select({
-        "//e2e/legacy-cli:native_windows_testing": toolchains + [
-            "@org_chromium_chromedriver_windows//:metadata",
-            "@org_chromium_chromium_windows//:metadata",
-        ],
-        "//conditions:default": toolchains,
-    })
     data = select({
-        "//e2e/legacy-cli:native_windows_testing": data + windows_node_files,
+        "//tests/legacy-cli:native_windows_testing": data + windows_test_files,
         "//conditions:default": data,
     })
 

tests/legacy-cli/e2e/setup/003-windows-wsl-prep.ts

@@ -22,4 +22,8 @@ export default async function () {
   // Expose Git binary in path. Node is already exposes via the NPM directory.
   // These global tools are used by e2e tests.
   process.env['PATH'] = [process.env.PATH, windowsMode.gitBinaryDirForWindows].join(path.delimiter);
+
+  process.env.CHROME_BIN = windowsMode?.windowsChromiumPath;
+  process.env.CHROME_PATH = windowsMode?.windowsChromiumPath;
+  process.env.CHROMEDRIVER_BIN = windowsMode?.windowsChromedriverPath;
 }

tests/legacy-cli/e2e/tests/commands/completion/completion-prompt.ts

@@ -10,6 +10,7 @@ import {
   execWithEnv,
   silentNpm,
 } from '../../../utils/process';
+import { isWindowsTestMode } from '../../../utils/wsl';
 
 const AUTOCOMPLETION_PROMPT = /Would you like to enable autocompletion\?/;
 const DEFAULT_ENV = Object.freeze({
@@ -30,7 +31,7 @@ const testRegistry = getGlobalVariable('package-registry');
 export default async function () {
   // Windows Cmd and Powershell do not support autocompletion. Run a different set of tests to
   // confirm autocompletion skips the prompt appropriately.
-  if (process.platform === 'win32') {
+  if (isWindowsTestMode()) {
     await windowsTests();
     return;
   }

tests/legacy-cli/e2e_runner.ts

@@ -12,7 +12,6 @@ import { findFreePort } from './e2e/utils/network';
 import { extractFile } from './e2e/utils/tar';
 import { realpathSync } from 'node:fs';
 import { PkgInfo } from './e2e/utils/packages';
-import { isWindowsTestMode } from './e2e/utils/wsl';
 
 Error.stackTraceLimit = Infinity;
 
@@ -207,19 +206,15 @@ setGlobalVariable('argv', argv);
 setGlobalVariable('package-manager', argv['package-manager']);
 setGlobalVariable('bazel-test-working-dir', process.cwd());
 
-const windowsMode = isWindowsTestMode();
-
 // Use the chrome supplied by bazel or the puppeteer chrome and webdriver-manager driver outside.
 // This is needed by karma-chrome-launcher, protractor etc.
 // https://github.com/karma-runner/karma-chrome-launcher#headless-chromium-with-puppeteer
 //
 // Resolve from relative paths to absolute paths within the bazel runfiles tree
 // so subprocesses spawned in a different working directory can still find them.
-process.env.CHROME_BIN = windowsMode?.windowsChromiumPath ?? path.resolve(process.env.CHROME_BIN!);
-process.env.CHROME_PATH =
-  windowsMode?.windowsChromiumPath ?? path.resolve(process.env.CHROME_PATH!);
-process.env.CHROMEDRIVER_BIN =
-  windowsMode?.windowsChromedriverPath ?? path.resolve(process.env.CHROMEDRIVER_BIN!);
+process.env.CHROME_BIN = path.resolve(process.env.CHROME_BIN!);
+process.env.CHROME_PATH = path.resolve(process.env.CHROME_PATH!);
+process.env.CHROMEDRIVER_BIN = path.resolve(process.env.CHROMEDRIVER_BIN!);
 
 // Find free ports sequentially, reducing the risk of collisions.
 // Note for Windows test mode on CI: Verdaccio runs inside WSL, so we