build: use the repo name mapping in use_repo instead of replacing the naming during usages of npm_typescript #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… naming during usages of npm_typescript
sbarfurth
reviewed
Aug 13, 2025
Collaborator
sbarfurth
left a comment
sbarfurth
left a comment
There was a problem hiding this comment.
Much better than before! Thanks.
Can we test this fix by having the test module use the default repo name for its own rules_ts?
sbarfurth
approved these changes
Aug 15, 2025
Collaborator
sbarfurth
left a comment
sbarfurth
left a comment
There was a problem hiding this comment.
Approving because I think this is definitely an improvement. I might port this approach to my company's monorepo. Although I maintain that rules_ts should not inherently have this issue.
Owner
|
@josephperrott is this still something you want to land? |
Collaborator
|
There's also the option to have a repo-private wrapper for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.