Skip to content

Commit d501df1

Browse files
committed
update summary instructions - resolves #6
9244ee6: Fixed som settings - #6 97bed3f: updated the symmary instruction and fixed som mad references - #6
1 parent 0ebeab9 commit d501df1

File tree

6 files changed

+23
-9
lines changed

6 files changed

+23
-9
lines changed

.githooks/pre-commit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ echo "🔍 Running pre-commit checks..."
2121

2222
# Ruff check
2323
if [ "$RUN_RUFF" == "TRUE" ]; then
24-
printf "Pytest with coverage\r"
24+
printf "Ruff check.git\r"
2525
RUFF_OUT=$(ruff check --output-format=concise . 2>&1)
2626

2727
if [ $? -eq 0 ]; then

.github/instructions/summary.instructions.md

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,25 @@
11
---
22
applyTo: '**'
33
---
4-
When using the @github agent to create issues and comments to issues, please consider that I'm using zsh and unescaped use of backtick are likely to be mistaken as command substitutions. So for that reason prefer to generate the markdown in intermediate `*.md` files in the `./temp` folder and restrain from using the `--body` flag to `gh issue create` and `gh issue comment` when you markdown contains backticks. But favor the `--body-file` flag instead. Name the file the same as the branch we're working on, with a `.md` extension, and store it in the `./temp` folder. Open it in the editor for my review and annotations.
4+
# Annotate summaries to issues
55

6-
When in @github agent mode and I ask to _annotate a comment on the current changeset to the issue_ you can always read the implied issue number from the current git branch - development branches are prefixed with an integer, and that is a reference to the issue being worked on. The branch name is part of the zsh prompt in the @terminal, and can be directly accessed; The `$PS1` is set up to show the branch name too (e.g. `vscode ➜ /workspaces/gh-tt (321-Update_summary_instructions) $` equals issue 321). Let summary serve as a work log note to future self and current colleagues. It should summarize the changes made in the branch we're working on (including any dirty files) since we left `main` (equivalent to `git diff main...HEAD`).
6+
## Default behaviour
77

8-
Only summarize on the accumulated change set in the branch. Do not dive into - or reference - the individual commits on the branch. The branch will be squashed into one commit before it hits main so not BOM (Bill of Material) is need - just a summary in prose. Make it a high-level overview of what was done (describe the changes), why it was done (the rationale behind our decisions), and any relevant context (maybe external links of general architectural or design decisions). The summary should have the header `##Change log summary` and even if I did ask you to create such a summary earlier on this branch, you should create the full summary again (don't just summarize the increment since last).
8+
If you recieved noting but a reference to this file, the default behaviour is to annotate a summary of the changeset to the issue being worked on.
9+
10+
## Use an itermediate md file
11+
12+
When in agent mode, and you are asked to create issues and comments to issues, please consider that I'm using zsh and unescaped use of backtick are likely to be mistaken as command substitutions. So for that reason prefer to generate the markdown in intermediate `*.md` files in the `./temp` folder and restrain from using the `--body` flag to `gh issue create` and `gh issue comment`. But favor the `--body-file` flag instead. Name the file the same as the branch we're working on, with a `.md` extension, and store it in the `./temp` folder. Open it in the editor for my review and annotations.
13+
14+
## Read issue number from branch name
15+
16+
When agent mode and I ask to _annotate a comment on the current changeset to the issue_ you can always read the implied issue number from the current git branch - development branches are prefixed with an integer, and that is a reference to the issue being worked on. The branch name is part of the zsh prompt in the @terminal, and can be directly accessed; The `$PS1` is set up to show the branch name too (e.g. `vscode ➜ /workspaces/gh-tt (321-Update_summary_instructions) $` equals issue 321). Let summary serve as a work log note to future self and current colleagues. It should summarize the changes made in the branch we're working on since we left `main`.
17+
18+
Equivalent to `git diff main...HEAD --name-status && git diff main...HEAD`.
19+
20+
## Change set summary
21+
22+
Only summarize on the accumulated change set in the branch. Do not dive into - or reference - the individual commits on the branch. The branch will be squashed into one commit before it hits main so no BOM (Bill of Material) is need - just a summary in prose. Make it a high-level overview of what was done (describe the changes), why it was done (the rationale behind our decisions), and any relevant context (maybe external links of general architectural or design decisions). The summary should have the header `## Change log summary` and even if I did ask you to create such a summary earlier on this branch, you should create the full change set summary again (don't just summarize the increment since last).
923

1024
The purpose of the summary is to help my future self and current team mates to recall and understand the purpose of - and rationale behind - the changes without needing to read through all the code or commit messages.
1125

.github/workflows/wrapup.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ jobs:
9595

9696
markdown_linter:
9797
name: Linting
98+
needs: mark-pending
9899
permissions:
99100
statuses: write
100101
contents: read

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Feel free to create a fork and fool around - following your own rules. But if yo
66

77
If you are a trusted contributor and already have write access to the repo, consider:
88

9-
1. No commit can be accepted on _our_ `main`, unless it references a [GitHub issue](../../gh-tt/issues)[^issue] in the commit message.
9+
1. No commit can be accepted on _our_ `main`, unless it references a [GitHub issue](../../issues)[^issue] in the commit message.
1010
2. Development branches must be created using `gh tt workon` - so they refer to the issue they belong to.
1111
3. Development branches with more than one commit must all reference the issue they belong to - `gh tt wrapup` does that for you!
1212
4. Development branches must be squezeed to branches with just one single commit that can be merged _fast-forward only_. These branches must be prefixed with `ready/` to trigger the right workflow. `gh tt deliver` does that for you.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ This utility supports an [opinionated flow](docs/workflow.md). If you share our
104104

105105
**More goodies in the discussions**
106106

107-
- [The Discussions on the repo](../../gh-tt/discussions) contains a lot of additional perspective and reflections on how the get the most our of this `gh tt` utility.
107+
- [The Discussions on the repo](../../discussions) contains a lot of additional perspective and reflections on how the get the most our of this `gh tt` utility.
108108

109109
## Introduction
110110

@@ -134,7 +134,7 @@ Read about it in more detail in [docs/workflow.md](docs/workflow.md).
134134

135135
## Feedback, discussions, contributing
136136

137-
Issues are open on the repo: [`devx-cafe/gh-tt`](../../gh-tt/issues). If you experience errors, misbehavior, or have feature requests, feel free to join the discussion.
137+
Issues are open on the repo: [`devx-cafe/gh-tt`](../../issues). If you experience errors, misbehavior, or have feature requests, feel free to join the discussion.
138138

139139
For contributing, see [CONTRIBUTING.md](CONTRIBUTING.md).
140140

@@ -287,4 +287,4 @@ gh responsibles # instead of gh tt responsibles
287287
gh semver # instead of gh tt semver
288288
```
289289

290-
Your feedback - or request for help - is always welcome: Use [the Issues](../../gh-tt/issues) or [the Discussions](../../gh-tt/discussions) to communicate.
290+
Your feedback - or request for help - is always welcome: Use [the Issues](../../issues) or [the Discussions](../../discussions) to communicate.

cspell.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"ignorePaths": [
55
"**/node_modules/**",
66
"**/.git/**",
7-
"**/.github/**",
87
"**/.vscode/**",
98
"**/.cspell/**",
109
"**/logs/**",

0 commit comments

Comments
 (0)