close #63 open issue in browser from terminal

Author: groenborg

ci/notes/CHANGELOG.md

@@ -0,0 +1,10 @@
+The release brings some much needed features to the phlow. Requests for opening GitHub issues have been heard, and here it is.
+We have also tried to address the issues with the workon command, where in some cases it was unable to locate the issues on github.
+As always we strive for perfection and try to make the code pretty as a butterfly.
+
+#### Features
+- web command #63 (Browser can be started from phlow) @groenborg
+- list issues #69 (Lists opens issues in the terminal)
+
+#### Bug fixes
+- now finds remote issues #64 (both ssh and https urls now work) @groenborg

ci/notes/release-notes.md

@@ -117,7 +117,7 @@ jobs:
       name: resource-version/version 
       tag: resource-version/version
       tag_prefix: v 
-      body: git-phlow/ci/notes/release-notes.md
+      body: git-phlow/ci/notes/CHANGELOG.md
       globs: 
         - phlow-artifact-linux-s3/git-phlow-*-linux-amd64.tar.gz
         - phlow-artifact-darwin-s3/git-phlow-*-darwin-amd64.tar.gz
@@ -137,7 +137,7 @@ jobs:
       name: resource-version/version 
       tag: resource-version/version
       tag_prefix: v 
-      body: git-phlow/ci/notes/release-notes.md
+      body: git-phlow/ci/notes/CHANGELOG.md
       globs: 
         - phlow-artifact-linux-s3/git-phlow-*-linux-amd64.tar.gz
         - phlow-artifact-darwin-s3/git-phlow-*-darwin-amd64.tar.gz
@@ -157,7 +157,7 @@ jobs:
       name: resource-version/version 
       tag: resource-version/version
       tag_prefix: v 
-      body: git-phlow/ci/notes/release-notes.md
+      body: git-phlow/ci/notes/CHANGELOG.md
       globs: 
         - phlow-artifact-linux-s3/git-phlow-*-linux-amd64.tar.gz
         - phlow-artifact-darwin-s3/git-phlow-*-darwin-amd64.tar.gz

ci/pipeline.yml

@@ -0,0 +1,38 @@
+package cmd
+
+import (
+	"fmt"
+
+	"github.com/spf13/cobra"
+	"github.com/praqma/git-phlow/phlow"
+	"strconv"
+	"os"
+)
+
+// webCmd represents the web command
+var webCmd = &cobra.Command{
+	Use:   "web [issue]",
+	Short: "open your issues on github",
+	Long: `
+web opens a github issue or githubs issue list based on it's arguments'
+If no argument is passed, it tries to locate an issue on the current checked out branch,
+if that fails it will simply open GitHubs issue list in your default browser
+`,
+	Run: func(cmd *cobra.Command, args []string) {
+
+		if len(args) > 0 {
+			if val, err := strconv.Atoi(args[0]); err == nil {
+				phlow.Web(val)
+			} else {
+				fmt.Println("argument must be a number")
+				os.Exit(0)
+			}
+		} else {
+			phlow.Web(-1)
+		}
+	},
+}
+
+func init() {
+	RootCmd.AddCommand(webCmd)
+}

cmd/web.go

@@ -0,0 +1,49 @@
+package phlow
+
+import (
+	"github.com/praqma/git-phlow/executor"
+	"github.com/praqma/git-phlow/githandler"
+	"github.com/praqma/git-phlow/plugins"
+	"fmt"
+	"os"
+)
+
+func Web(userIssue int) {
+
+	var issueListURL = "https://github.com/%s/%s/issues"
+	var issueInfoURL = "https://github.com/%s/%s/issues/%d"
+
+	//Get organisation and repository for repository
+	orgAndRepo, err := githandler.Remote()
+	if err != nil {
+		fmt.Println(err)
+		os.Exit(1)
+	}
+
+	//Get your current branch
+	branchInfo, err := githandler.Branch()
+	if err != nil {
+		fmt.Println(err)
+		os.Exit(1)
+	}
+
+	branchIssue := plugins.IssueFromBranchName(branchInfo.Current)
+
+	if userIssue != -1 {
+		issueInfoURL = fmt.Sprintf(issueInfoURL, orgAndRepo.Organisation, orgAndRepo.Repository, userIssue)
+		_, err := executor.ExecuteCommand("open", issueInfoURL)
+		if err != nil {
+			fmt.Println(err)
+		}
+		os.Exit(0)
+	}
+
+	if branchIssue != -1 {
+		issueInfoURL = fmt.Sprintf(issueInfoURL, orgAndRepo.Organisation, orgAndRepo.Repository, branchIssue)
+		executor.ExecuteCommand("open", issueInfoURL)
+		os.Exit(0)
+	}
+
+	issueListURL = fmt.Sprintf(issueListURL, orgAndRepo.Organisation, orgAndRepo.Repository)
+	executor.ExecuteCommand("open", issueListURL)
+}

phlow/web.go

@@ -3,9 +3,6 @@ package phlow
 import (
 	"fmt"
 	"os"
-	"strconv"
-	"strings"
-
 	"github.com/praqma/git-phlow/githandler"
 	"github.com/praqma/git-phlow/plugins"
 	"github.com/praqma/git-phlow/ui"
@@ -29,13 +26,13 @@ func WorkOn(issue int) {
 	}
 
 	fmt.Fprintln(os.Stdout, "Locating existing issue branches")
-	if GetIssueFromBranch(branchInfo.Current) == issue {
+	if plugins.IssueFromBranchName(branchInfo.Current) == issue {
 		fmt.Fprintf(os.Stdout, "You are already on branch %s \n", ui.BranchFormat(branchInfo.Current))
 		return
 	}
 
 	for _, branch := range branchInfo.List {
-		if GetIssueFromBranch(branch) == issue {
+		if plugins.IssueFromBranchName(branch) == issue {
 			if err = githandler.CheckOut(branch); err != nil {
 				fmt.Println(err)
 			}
@@ -96,13 +93,3 @@ func UpdateIssue(issue int) {
 	fmt.Println("----------------------------------")
 	return
 }
-
-//GetIssueFromBranch ...
-//Extracts the issue number from the branch name
-func GetIssueFromBranch(branch string) int {
-	iss, err := strconv.Atoi(strings.Split(branch, "-")[0])
-	if err != nil {
-		return -1
-	}
-	return iss
-}

phlow/workon.go

@@ -79,6 +79,18 @@ func BranchNameFromIssue(issue int, name string) string {
 	return strconv.Itoa(issue) + "-" + result
 }
 
+
+//IssueFromBranchName
+//Extracts the issue number from the branch name
+func IssueFromBranchName(branch string) int {
+	iss, err := strconv.Atoi(strings.Split(branch, "-")[0])
+	if err != nil {
+		return -1
+	}
+	return iss
+}
+
+
 //efficientConcatString
 //Concatenate strings in an effective way
 func efficientConcatString(args ...string) string {