close #300 fix choco release job

Author: groenborg

ci/chocolatey/chocolatey.ps1

@@ -1,16 +1,15 @@
 ## concourse task for releasing a package on chocolatey
+$env:Path = [System.Environment]::GetEnvironmentVariable("Path","Machine")
+$ErrorActionPreference = "Stop"
 
 ls   #debugging
 
 # read version from file
 $version = Get-Content .\gp-version\version
 
-Expand-Archive .\phlow-artifact-windows-s3\git-phlow-*.zip -DestinationPath .\phlow-artifact-windows-s3
-
 # list artifact for debugging purpose
 ls .\phlow-artifact-windows-s3
 
-
 mv phlow-artifact-windows-s3/git-phlow.exe git-phlow/ci/chocolatey/tools/
 
 cd git-phlow/ci/chocolatey
@@ -29,4 +28,4 @@ choco pack
 
 choco push --api-key $token
 
-exit $lastexitcode
+exit $LastExitCode

ci/chocolatey/chocolatey.yml

@@ -12,6 +12,5 @@ params:
 run:
   path: powershell.exe 
   args:
-  - -File
   - '.\git-phlow\ci\chocolatey\chocolatey.ps1'
 

ci/pipeline.yml

@@ -164,6 +164,8 @@ jobs:
     - get: git-phlow
     - get: phlow-artifact-windows-s3
       passed: [takeoff]
+      params:
+        unpack: true
     - get: gp-version
       passed: [takeoff]
       trigger: true

ci/windows/windows.yml

@@ -7,5 +7,4 @@ inputs:
 run:
   path: powershell.exe 
   args:
-  - -File
   - '.\git-phlow\ci\windows\go-test-windows.ps1'